diff options
| author | Pedro Alves <pedro@palves.net> | 2022-06-24 12:42:38 +0100 |
|---|---|---|
| committer | Pedro Alves <pedro@palves.net> | 2022-06-27 13:55:36 +0100 |
| commit | 171fba11ab27089cffd6f85655ab987a937fea25 (patch) | |
| tree | 06df4b59c96e60247abbbef27d1f6ddcd6ec65c2 /gdbsupport/config.in | |
| parent | e3e5ae049371a27fd1737aba946fe26d06e029b5 (diff) | |
| download | binutils-gdb-171fba11ab27089cffd6f85655ab987a937fea25.tar.gz | |
Make GDBserver abort on internal error in development mode
Currently, if GDBserver hits some internal assertion, it exits with
error status, instead of aborting. This makes it harder to debug
GDBserver, as you can't just debug a core file if GDBserver fails an
assertion. I've had to hack the code to make GDBserver abort to debug
something several times before.
I believe the reason it exits instead of aborting, is to prevent
potentially littering the filesystem of smaller embedded targets with
core files. I think I recall Daniel Jacobowitz once saying that many
years ago, but I can't be sure. Anyhow, that seems reasonable to me.
Since we nowadays have a distinction between development and release
modes, I propose to make GDBserver abort on internal error if in
development mode, while keeping the status quo when in release mode.
Thus, after this patch, in development mode, you get:
$ ../gdbserver/gdbserver
../../src/gdbserver/server.cc:3711: A problem internal to GDBserver has been detected.
captured_main: Assertion `0' failed.
Aborted (core dumped)
$
while in release mode, you'll continue to get:
$ ../gdbserver/gdbserver
../../src/gdbserver/server.cc:3711: A problem internal to GDBserver has been detected.
captured_main: Assertion `0' failed.
$ echo $?
1
I do not think that this requires a separate configure switch.
A "--target_board=native-extended-gdbserver" run on Ubuntu 20.04 ends
up with:
=== gdb Summary ===
# of unexpected core files 29
...
for me, of which 8 are GDBserver core dumps, 7 more than without this
patch.
Change-Id: I6861e08ad71f65a0332c91ec95ca001d130b0e9d
Diffstat (limited to 'gdbsupport/config.in')
| -rw-r--r-- | gdbsupport/config.in | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gdbsupport/config.in b/gdbsupport/config.in index a7ae23b4984..577866c97b3 100644 --- a/gdbsupport/config.in +++ b/gdbsupport/config.in @@ -11,6 +11,9 @@ /* Define to 1 if using `alloca.c'. */ #undef C_ALLOCA +/* Define if development-mode features are enabled. */ +#undef DEVELOPMENT + /* Define to 1 if translation of program messages to the user's native language is requested. */ #undef ENABLE_NLS |