diff options
| author | Sergio Durigan Junior <sergiodj@redhat.com> | 2019-03-29 17:34:54 -0400 |
|---|---|---|
| committer | Sergio Durigan Junior <sergiodj@redhat.com> | 2019-04-01 10:58:12 -0400 |
| commit | 9d1447e09d4aa673826039321163b5a684e8e043 (patch) | |
| tree | e9af1807d26dcc67327847c369b9d032afccb102 /gdb/top.c | |
| parent | 34ef62f46541d423b991850b2b7ba34d8749a6ba (diff) | |
| download | binutils-gdb-9d1447e09d4aa673826039321163b5a684e8e043.tar.gz | |
Destroy allocated values when exiting GDB
When the user exits GDB, we might still have some allocated values in
the chain, which, in specific scenarios, can cause problems when GDB
attempts to destroy them in "quit_force". For example, see the bug
reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=1690120
And the thread starting at:
https://sourceware.org/ml/gdb-patches/2019-03/msg00475.html
Message-ID: <87r2azkhmq.fsf@redhat.com>
In order to avoid that, and to be more aware of our allocated
resources, this commit implements a new function "finalize_values" and
calls it from inside "quit_force".
Tested by the BuildBot.
2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
Pedro Alves <palves@redhat.com>
* top.c (quit_force): Call 'finalize_values'.
* value.c (finalize_values): New function.
* value.h (finalize_values): Declare.
Diffstat (limited to 'gdb/top.c')
| -rw-r--r-- | gdb/top.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/gdb/top.c b/gdb/top.c index afb77c0ec95..1fc259fe0f4 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -1673,6 +1673,12 @@ quit_force (int *exit_arg, int from_tty) } END_CATCH + /* Destroy any values currently allocated now instead of leaving it + to global destructors, because that may be too late. For + example, the destructors of xmethod values call into the Python + runtime, which is finalized via a final cleanup. */ + finalize_values (); + /* Do any final cleanups before exiting. */ TRY { |