diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2022-12-05 16:38:24 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2022-12-05 16:38:24 -0500 |
| commit | 30add7ee24bf88630ee38cd73b6a1dd3aa384999 (patch) | |
| tree | 31126cc2c4495ec816d449387c35fe90fdeb5f16 /gdb/testsuite/gdb.cp | |
| parent | 09a5d200e6166522e0d0a9276bd6b2227ac5ace1 (diff) | |
| download | binutils-gdb-30add7ee24bf88630ee38cd73b6a1dd3aa384999.tar.gz | |
gdb/testsuite: remove perror calls when failing to run
I noticed that when running these two tests in sequence:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/arrayptr.exp ...
ERROR: GDB process no longer exists
ERROR: Couldn't run foo-all
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/assign_1.exp ...
The results in gdb.sum are:
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/arrayptr.exp ...
PASS: gdb.ada/arrayptr.exp: scenario=all: compilation foo.adb
ERROR: GDB process no longer exists
UNRESOLVED: gdb.ada/arrayptr.exp: scenario=all: gdb_breakpoint: set breakpoint at foo.adb:40 (eof)
ERROR: Couldn't run foo-all
Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/assign_1.exp ...
UNRESOLVED: gdb.ada/assign_1.exp: changing the language to ada
PASS: gdb.ada/assign_1.exp: set convenience variable $xxx to 1
The UNRESOLVED for arrayptr.exp is fine, as GDB crashes in that test,
while trying to run to main. However, the UNRESOLVED in assign_1.exp
doesn't make sense, GDB behaves as expected in that test:
(gdb) set lang ada^M
(gdb) UNRESOLVED: gdb.ada/assign_1.exp: changing the language to ada
print $xxx := 1^M
$1 = 1^M
(gdb) PASS: gdb.ada/assign_1.exp: set convenience variable $xxx to 1
The problem is that arrayptr.exp calls perror when failing to run to
main, then returns. perror makes it so that the next test (as in
pass/fail) will be recorded as UNRESOLVED. However, here, the next test
(as in pass/fail) is in the next test (as in .exp). Hence the spurious
UNRESOLVED in assign_1.exp.
These perror when failing to run to X are not really useful, especially
since runto records a FAIL on error, by default. Remove all the
perrors on runto failure I could find.
When there wasn't one already, add a return statement when failing to
run, to avoid running the test of the test unnecessarily.
I thought of adding a check ran between test (in gdb_finish
probably) where we would emit a warning if errcnt > 0, meaning a test
quit and left a perror "active". However, reading that variable would
poke into the DejaGNU internals, not sure it's a good idea.
Change-Id: I2203df6d06e199540b36f56470d1c5f1dc988f7b
Diffstat (limited to 'gdb/testsuite/gdb.cp')
71 files changed, 0 insertions, 84 deletions
diff --git a/gdb/testsuite/gdb.cp/ambiguous.exp b/gdb/testsuite/gdb.cp/ambiguous.exp index 0f04668cbab..5d0d2f88b6e 100644 --- a/gdb/testsuite/gdb.cp/ambiguous.exp +++ b/gdb/testsuite/gdb.cp/ambiguous.exp @@ -37,7 +37,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/anon-ns.exp b/gdb/testsuite/gdb.cp/anon-ns.exp index 852d9bc2c40..bab7717b978 100644 --- a/gdb/testsuite/gdb.cp/anon-ns.exp +++ b/gdb/testsuite/gdb.cp/anon-ns.exp @@ -26,7 +26,6 @@ if {[prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" {c++ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/anon-union.exp b/gdb/testsuite/gdb.cp/anon-union.exp index 9f18545bbf8..fd51d790938 100644 --- a/gdb/testsuite/gdb.cp/anon-union.exp +++ b/gdb/testsuite/gdb.cp/anon-union.exp @@ -32,7 +32,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" continue } diff --git a/gdb/testsuite/gdb.cp/breakpoint.exp b/gdb/testsuite/gdb.cp/breakpoint.exp index e1f2d4c5dc5..31952b65cd6 100644 --- a/gdb/testsuite/gdb.cp/breakpoint.exp +++ b/gdb/testsuite/gdb.cp/breakpoint.exp @@ -33,7 +33,6 @@ proc test_breakpoint {name} { # Restart the program every time, so that a single failure doesn't # lead to a cascade. if {![runto_main]} { - perror "couldn't run to main when testing ${name}" return -code continue } else { gdb_breakpoint "${name}" diff --git a/gdb/testsuite/gdb.cp/bs15503.exp b/gdb/testsuite/gdb.cp/bs15503.exp index f00421a6702..b50333fc4b4 100644 --- a/gdb/testsuite/gdb.cp/bs15503.exp +++ b/gdb/testsuite/gdb.cp/bs15503.exp @@ -26,7 +26,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/casts.exp b/gdb/testsuite/gdb.cp/casts.exp index 43851d43aeb..f98f844ef92 100644 --- a/gdb/testsuite/gdb.cp/casts.exp +++ b/gdb/testsuite/gdb.cp/casts.exp @@ -34,7 +34,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } @@ -182,7 +181,6 @@ if {[prepare_for_testing "failed to prepare" ${testfile}03 $srcfile2 \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/class2.exp b/gdb/testsuite/gdb.cp/class2.exp index 9392e259be4..69e9809820e 100644 --- a/gdb/testsuite/gdb.cp/class2.exp +++ b/gdb/testsuite/gdb.cp/class2.exp @@ -35,7 +35,6 @@ gdb_test_no_output "set print object off" gdb_test_no_output "set print symbol off" if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/classes.exp b/gdb/testsuite/gdb.cp/classes.exp index beac2681749..c6d9c05354e 100644 --- a/gdb/testsuite/gdb.cp/classes.exp +++ b/gdb/testsuite/gdb.cp/classes.exp @@ -652,7 +652,6 @@ proc do_tests {} { gdb_test_no_output "set width 0" "" if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/constexpr-field.exp b/gdb/testsuite/gdb.cp/constexpr-field.exp index b1ecf13918d..f534961bc97 100644 --- a/gdb/testsuite/gdb.cp/constexpr-field.exp +++ b/gdb/testsuite/gdb.cp/constexpr-field.exp @@ -25,7 +25,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/converts.exp b/gdb/testsuite/gdb.cp/converts.exp index ea7a2f45d2f..9e4b6ea4d59 100644 --- a/gdb/testsuite/gdb.cp/converts.exp +++ b/gdb/testsuite/gdb.cp/converts.exp @@ -22,7 +22,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug c++} ############################################ if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/ctti.exp b/gdb/testsuite/gdb.cp/ctti.exp index 4a2012e4a05..aacda45c325 100644 --- a/gdb/testsuite/gdb.cp/ctti.exp +++ b/gdb/testsuite/gdb.cp/ctti.exp @@ -31,7 +31,6 @@ if {[prepare_for_testing "failed to prepare" $testfile \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/derivation.exp b/gdb/testsuite/gdb.cp/derivation.exp index f5d20a00a3f..67ec4c11fe0 100644 --- a/gdb/testsuite/gdb.cp/derivation.exp +++ b/gdb/testsuite/gdb.cp/derivation.exp @@ -56,7 +56,6 @@ with_test_prefix "before run" { # Set it up at a breakpoint so we can play with the variable values. if {![runto 'marker1']} { - perror "couldn't run to marker1" return } @@ -266,7 +265,6 @@ gdb_test "ptype N::Derived::value_type" "type = int" # Now run to N::Derived::doit and get the type of "value_type" if {![runto "N::Derived::doit"]} { - perror "couldn't run to N::Derived::doit" return } diff --git a/gdb/testsuite/gdb.cp/disasm-func-name.exp b/gdb/testsuite/gdb.cp/disasm-func-name.exp index 45f18abb4e6..bfc1739c6b4 100644 --- a/gdb/testsuite/gdb.cp/disasm-func-name.exp +++ b/gdb/testsuite/gdb.cp/disasm-func-name.exp @@ -28,7 +28,6 @@ if {[prepare_for_testing "failed to prepare" $testfile \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/dispcxx.exp b/gdb/testsuite/gdb.cp/dispcxx.exp index 9d2e340083f..e12b082135f 100644 --- a/gdb/testsuite/gdb.cp/dispcxx.exp +++ b/gdb/testsuite/gdb.cp/dispcxx.exp @@ -22,7 +22,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/filename.exp b/gdb/testsuite/gdb.cp/filename.exp index 6d97ee51257..91ee3308c12 100644 --- a/gdb/testsuite/gdb.cp/filename.exp +++ b/gdb/testsuite/gdb.cp/filename.exp @@ -22,7 +22,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/fpointer.exp b/gdb/testsuite/gdb.cp/fpointer.exp index 5fc99055a2c..b7befe92eb1 100644 --- a/gdb/testsuite/gdb.cp/fpointer.exp +++ b/gdb/testsuite/gdb.cp/fpointer.exp @@ -23,7 +23,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug c++} } if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/gdb1355.exp b/gdb/testsuite/gdb.cp/gdb1355.exp index e18bcc18f17..cd4ee9bad77 100644 --- a/gdb/testsuite/gdb.cp/gdb1355.exp +++ b/gdb/testsuite/gdb.cp/gdb1355.exp @@ -34,7 +34,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/gdb2384.exp b/gdb/testsuite/gdb.cp/gdb2384.exp index 7fc5a5ba0f8..e08ed9cb156 100644 --- a/gdb/testsuite/gdb.cp/gdb2384.exp +++ b/gdb/testsuite/gdb.cp/gdb2384.exp @@ -39,7 +39,6 @@ gdb_load_shlib ${sofile} if {![runto_main]} { - perror "couldn't run to breakpoint" return -1 } diff --git a/gdb/testsuite/gdb.cp/gdb2495.exp b/gdb/testsuite/gdb.cp/gdb2495.exp index 6ade5d91d4e..b2305a14e51 100644 --- a/gdb/testsuite/gdb.cp/gdb2495.exp +++ b/gdb/testsuite/gdb.cp/gdb2495.exp @@ -52,7 +52,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to main" return } @@ -97,7 +96,6 @@ gdb_test "p exceptions.throw_function()" \ # Restart the inferior back at main. if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/impl-this.exp b/gdb/testsuite/gdb.cp/impl-this.exp index 4a11fb21823..9ce409ee10e 100644 --- a/gdb/testsuite/gdb.cp/impl-this.exp +++ b/gdb/testsuite/gdb.cp/impl-this.exp @@ -52,7 +52,6 @@ with_test_prefix "before run" { # Run to D::f. if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/inherit.exp b/gdb/testsuite/gdb.cp/inherit.exp index c3cfefc803c..e1099fe5ed5 100644 --- a/gdb/testsuite/gdb.cp/inherit.exp +++ b/gdb/testsuite/gdb.cp/inherit.exp @@ -678,7 +678,6 @@ proc do_tests { } { gdb_test_no_output "set width 0" if {![runto_main]} { - perror "couldn't run to main" return } @@ -689,7 +688,6 @@ proc do_tests { } { test_ptype_mvi if {![runto 'inheritance2']} { - perror "couldn't run to inheritance2" return } @@ -708,7 +706,6 @@ proc do_tests { } { test_print_anon_union if { ![runto 'inheritance4'] } { - perror "couldn't run to inheritance4" return } diff --git a/gdb/testsuite/gdb.cp/iostream.exp b/gdb/testsuite/gdb.cp/iostream.exp index 5189a0dd3ed..aa7c5359e69 100644 --- a/gdb/testsuite/gdb.cp/iostream.exp +++ b/gdb/testsuite/gdb.cp/iostream.exp @@ -25,7 +25,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if ![runto_main] { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/koenig.exp b/gdb/testsuite/gdb.cp/koenig.exp index 912a7eaadc7..60aa130d006 100644 --- a/gdb/testsuite/gdb.cp/koenig.exp +++ b/gdb/testsuite/gdb.cp/koenig.exp @@ -23,7 +23,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ ############################################ if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/local.exp b/gdb/testsuite/gdb.cp/local.exp index 351f39f6365..378a5c31cc3 100644 --- a/gdb/testsuite/gdb.cp/local.exp +++ b/gdb/testsuite/gdb.cp/local.exp @@ -39,12 +39,10 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { # set it up at a breakpoint so we can play with the variable values # if {![runto_main]} { - perror "couldn't run to breakpoint" return } if {![runto 'marker1']} { - perror "couldn't run to marker1" return } diff --git a/gdb/testsuite/gdb.cp/m-data.exp b/gdb/testsuite/gdb.cp/m-data.exp index aca98c7c4c7..282b33a1f3f 100644 --- a/gdb/testsuite/gdb.cp/m-data.exp +++ b/gdb/testsuite/gdb.cp/m-data.exp @@ -31,7 +31,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/m-static.exp b/gdb/testsuite/gdb.cp/m-static.exp index 228c120fb7b..1acaf13ce90 100644 --- a/gdb/testsuite/gdb.cp/m-static.exp +++ b/gdb/testsuite/gdb.cp/m-static.exp @@ -39,7 +39,6 @@ if {[prepare_for_testing "failed to prepare" $testfile \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/many-args.exp b/gdb/testsuite/gdb.cp/many-args.exp index aba1e78a561..c9c02f44122 100644 --- a/gdb/testsuite/gdb.cp/many-args.exp +++ b/gdb/testsuite/gdb.cp/many-args.exp @@ -28,7 +28,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if ![runto_main] { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/mb-ctor.exp b/gdb/testsuite/gdb.cp/mb-ctor.exp index 3bf5ee3ebad..f60d071ead4 100644 --- a/gdb/testsuite/gdb.cp/mb-ctor.exp +++ b/gdb/testsuite/gdb.cp/mb-ctor.exp @@ -32,7 +32,6 @@ if {[test_compiler_info {clang-*-*} c++]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/member-name.exp b/gdb/testsuite/gdb.cp/member-name.exp index 7e413cac6f4..6e3e0f07ae2 100644 --- a/gdb/testsuite/gdb.cp/member-name.exp +++ b/gdb/testsuite/gdb.cp/member-name.exp @@ -22,7 +22,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/member-ptr.exp b/gdb/testsuite/gdb.cp/member-ptr.exp index 8e20c018203..abb20916a59 100644 --- a/gdb/testsuite/gdb.cp/member-ptr.exp +++ b/gdb/testsuite/gdb.cp/member-ptr.exp @@ -31,7 +31,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/meth-typedefs.exp b/gdb/testsuite/gdb.cp/meth-typedefs.exp index c11e9916cb3..b357e36c7bc 100644 --- a/gdb/testsuite/gdb.cp/meth-typedefs.exp +++ b/gdb/testsuite/gdb.cp/meth-typedefs.exp @@ -41,7 +41,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/method.exp b/gdb/testsuite/gdb.cp/method.exp index 07a17b013b6..7a3227b461c 100644 --- a/gdb/testsuite/gdb.cp/method.exp +++ b/gdb/testsuite/gdb.cp/method.exp @@ -44,7 +44,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { # set it up at a breakpoint so we can play with the variable values # if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/method2.exp b/gdb/testsuite/gdb.cp/method2.exp index ad0129cdc19..c657b38a9a2 100644 --- a/gdb/testsuite/gdb.cp/method2.exp +++ b/gdb/testsuite/gdb.cp/method2.exp @@ -27,7 +27,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/namespace-nested-import.exp b/gdb/testsuite/gdb.cp/namespace-nested-import.exp index a08a4e008df..43c6fcfb497 100644 --- a/gdb/testsuite/gdb.cp/namespace-nested-import.exp +++ b/gdb/testsuite/gdb.cp/namespace-nested-import.exp @@ -26,7 +26,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { # been imported. if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/namespace.exp b/gdb/testsuite/gdb.cp/namespace.exp index 2f3a766fd21..f2eb2a48ae6 100644 --- a/gdb/testsuite/gdb.cp/namespace.exp +++ b/gdb/testsuite/gdb.cp/namespace.exp @@ -47,12 +47,10 @@ gdb_test "show lang" "auto; currently c\\+\\+.*" # set it up at a breakpoint so we can play with the variable values # if {![runto_main]} { - perror "couldn't run to breakpoint" return } if {![runto 'marker1']} { - perror "couldn't run to marker1" return } @@ -193,7 +191,6 @@ gdb_test_multiple $test $test { # namespace. if {![runto "C::D::marker2"]} { - perror "couldn't run to marker2" return } diff --git a/gdb/testsuite/gdb.cp/nextoverthrow.exp b/gdb/testsuite/gdb.cp/nextoverthrow.exp index 58e54f849e0..fe6445cf96d 100644 --- a/gdb/testsuite/gdb.cp/nextoverthrow.exp +++ b/gdb/testsuite/gdb.cp/nextoverthrow.exp @@ -23,7 +23,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/nsdecl.exp b/gdb/testsuite/gdb.cp/nsdecl.exp index d1859f874f1..1b12917d986 100644 --- a/gdb/testsuite/gdb.cp/nsdecl.exp +++ b/gdb/testsuite/gdb.cp/nsdecl.exp @@ -23,7 +23,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/nsimport.exp b/gdb/testsuite/gdb.cp/nsimport.exp index 56a74e73ff1..61a8d6d269f 100644 --- a/gdb/testsuite/gdb.cp/nsimport.exp +++ b/gdb/testsuite/gdb.cp/nsimport.exp @@ -28,7 +28,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { # the function. if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/nsnested.exp b/gdb/testsuite/gdb.cp/nsnested.exp index 01aba767f7f..d9e5b6ff543 100644 --- a/gdb/testsuite/gdb.cp/nsnested.exp +++ b/gdb/testsuite/gdb.cp/nsnested.exp @@ -21,7 +21,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug c++} ############################################ if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/nsnoimports.exp b/gdb/testsuite/gdb.cp/nsnoimports.exp index 11bcdaed834..e5d3186cc4b 100644 --- a/gdb/testsuite/gdb.cp/nsnoimports.exp +++ b/gdb/testsuite/gdb.cp/nsnoimports.exp @@ -21,7 +21,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug c++} ############################################ if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/nsrecurs.exp b/gdb/testsuite/gdb.cp/nsrecurs.exp index 30eab175df3..b1592ff4a4c 100644 --- a/gdb/testsuite/gdb.cp/nsrecurs.exp +++ b/gdb/testsuite/gdb.cp/nsrecurs.exp @@ -21,7 +21,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/nsstress.exp b/gdb/testsuite/gdb.cp/nsstress.exp index 2ff88791180..3fbca5d20f2 100644 --- a/gdb/testsuite/gdb.cp/nsstress.exp +++ b/gdb/testsuite/gdb.cp/nsstress.exp @@ -23,7 +23,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint main" continue } diff --git a/gdb/testsuite/gdb.cp/nsusing.exp b/gdb/testsuite/gdb.cp/nsusing.exp index f767b6b8c58..18bb28208b6 100644 --- a/gdb/testsuite/gdb.cp/nsusing.exp +++ b/gdb/testsuite/gdb.cp/nsusing.exp @@ -23,7 +23,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { # Test printing of namespace imported within the function. if {![runto_main]} { - perror "couldn't run to breakpoint main" continue } diff --git a/gdb/testsuite/gdb.cp/operator.exp b/gdb/testsuite/gdb.cp/operator.exp index b5609ba687a..54c8cbb7573 100644 --- a/gdb/testsuite/gdb.cp/operator.exp +++ b/gdb/testsuite/gdb.cp/operator.exp @@ -23,7 +23,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ ############################################ if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/oranking.exp b/gdb/testsuite/gdb.cp/oranking.exp index b9aa27dee57..07c3f79e275 100644 --- a/gdb/testsuite/gdb.cp/oranking.exp +++ b/gdb/testsuite/gdb.cp/oranking.exp @@ -22,7 +22,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug c++} ############################################ if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/overload.exp b/gdb/testsuite/gdb.cp/overload.exp index 4dcd0efc171..fde9d73c90b 100644 --- a/gdb/testsuite/gdb.cp/overload.exp +++ b/gdb/testsuite/gdb.cp/overload.exp @@ -35,7 +35,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { # Set it up at a breakpoint so we can play with the variable values. if {![runto 'marker1']} { - perror "couldn't run to marker1" continue } @@ -360,7 +359,6 @@ with_test_prefix "list all overloads" { } if {![runto 'XXX::marker2']} { - perror "couldn't run to XXX::marker2" continue } diff --git a/gdb/testsuite/gdb.cp/ovldbreak.exp b/gdb/testsuite/gdb.cp/ovldbreak.exp index 0ed9eae055b..94b58a5080d 100644 --- a/gdb/testsuite/gdb.cp/ovldbreak.exp +++ b/gdb/testsuite/gdb.cp/ovldbreak.exp @@ -39,7 +39,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { # set it up at a breakpoint so we can play with the variable values # if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/ovsrch.exp b/gdb/testsuite/gdb.cp/ovsrch.exp index 767d12bce1d..32ac7ce72d0 100644 --- a/gdb/testsuite/gdb.cp/ovsrch.exp +++ b/gdb/testsuite/gdb.cp/ovsrch.exp @@ -63,7 +63,6 @@ if {[prepare_for_testing "failed to prepare" $testfile \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/pr-1023.exp b/gdb/testsuite/gdb.cp/pr-1023.exp index 390459a0bac..0cd310b7c34 100644 --- a/gdb/testsuite/gdb.cp/pr-1023.exp +++ b/gdb/testsuite/gdb.cp/pr-1023.exp @@ -31,7 +31,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/pr-1210.exp b/gdb/testsuite/gdb.cp/pr-1210.exp index c74e7aa1dbc..5fabf6f8a44 100644 --- a/gdb/testsuite/gdb.cp/pr-1210.exp +++ b/gdb/testsuite/gdb.cp/pr-1210.exp @@ -30,7 +30,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/pr-574.exp b/gdb/testsuite/gdb.cp/pr-574.exp index 32c7f634940..06b96ccc0e9 100644 --- a/gdb/testsuite/gdb.cp/pr-574.exp +++ b/gdb/testsuite/gdb.cp/pr-574.exp @@ -39,7 +39,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile $flags]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/pr10728.exp b/gdb/testsuite/gdb.cp/pr10728.exp index 8051eae71da..07db26a6428 100644 --- a/gdb/testsuite/gdb.cp/pr10728.exp +++ b/gdb/testsuite/gdb.cp/pr10728.exp @@ -43,7 +43,6 @@ if { [gdb_compile "${tfx}.o ${tfy}.o" ${binfile} executable {debug c++}] != "" clean_restart $binfile if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/pr12028.exp b/gdb/testsuite/gdb.cp/pr12028.exp index c9583bd1731..50c46e5f524 100644 --- a/gdb/testsuite/gdb.cp/pr12028.exp +++ b/gdb/testsuite/gdb.cp/pr12028.exp @@ -22,7 +22,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug c++} ############################################ if {![runto_main]} { - perror "couldn't run to breakpoint main" continue } diff --git a/gdb/testsuite/gdb.cp/pr9067.exp b/gdb/testsuite/gdb.cp/pr9067.exp index 417abb19f07..79d18b5f65d 100644 --- a/gdb/testsuite/gdb.cp/pr9067.exp +++ b/gdb/testsuite/gdb.cp/pr9067.exp @@ -26,7 +26,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/pr9631.exp b/gdb/testsuite/gdb.cp/pr9631.exp index c98e3e9bf3f..612feaab974 100644 --- a/gdb/testsuite/gdb.cp/pr9631.exp +++ b/gdb/testsuite/gdb.cp/pr9631.exp @@ -24,7 +24,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/printmethod.exp b/gdb/testsuite/gdb.cp/printmethod.exp index 94aaba3f246..1530a40220e 100644 --- a/gdb/testsuite/gdb.cp/printmethod.exp +++ b/gdb/testsuite/gdb.cp/printmethod.exp @@ -32,7 +32,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp index b04a4a4b8c9..8c42de837e7 100644 --- a/gdb/testsuite/gdb.cp/ptype-flags.exp +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp @@ -26,7 +26,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/ref-types.exp b/gdb/testsuite/gdb.cp/ref-types.exp index 8135a2845f8..fd99ea9c0d6 100644 --- a/gdb/testsuite/gdb.cp/ref-types.exp +++ b/gdb/testsuite/gdb.cp/ref-types.exp @@ -32,12 +32,10 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { # set it up at a breakpoint so we can play with the variable values # if {![runto_main]} { - perror "couldn't run to breakpoint" return } if {![runto 'marker1']} { - perror "couldn't run to marker1" return } @@ -58,12 +56,10 @@ proc gdb_start_again {} { # set it up at a breakpoint so we can play with the variable values # if {![runto_main]} { - perror "couldn't run to breakpoint" return } if {![runto 'marker1']} { - perror "couldn't run to marker1" return } @@ -129,7 +125,6 @@ gdb_test "print ras\[3\]" ".\[0-9\]* = 3" "print value of ras\[3\]" if {![runto 'f']} { - perror "couldn't run to f" return } diff --git a/gdb/testsuite/gdb.cp/rtti.exp b/gdb/testsuite/gdb.cp/rtti.exp index 77cc6b6c35e..c72777bebff 100644 --- a/gdb/testsuite/gdb.cp/rtti.exp +++ b/gdb/testsuite/gdb.cp/rtti.exp @@ -40,7 +40,6 @@ if {[prepare_for_testing "failed to prepare" $testfile \ } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/rvalue-ref-types.exp b/gdb/testsuite/gdb.cp/rvalue-ref-types.exp index 6056af415cf..e38393db40d 100644 --- a/gdb/testsuite/gdb.cp/rvalue-ref-types.exp +++ b/gdb/testsuite/gdb.cp/rvalue-ref-types.exp @@ -62,7 +62,6 @@ gdb_test "print rrat\[3\]" ".$decimal = 3" "print value of rrat\[3\]" if {![runto 'f']} { - perror "couldn't run to f" return } diff --git a/gdb/testsuite/gdb.cp/shadow.exp b/gdb/testsuite/gdb.cp/shadow.exp index 641feed752c..4ddfe38b8e3 100644 --- a/gdb/testsuite/gdb.cp/shadow.exp +++ b/gdb/testsuite/gdb.cp/shadow.exp @@ -24,7 +24,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/smartp.exp b/gdb/testsuite/gdb.cp/smartp.exp index c94dfae4394..75faefd6f62 100644 --- a/gdb/testsuite/gdb.cp/smartp.exp +++ b/gdb/testsuite/gdb.cp/smartp.exp @@ -22,7 +22,6 @@ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {debug c++} ############################################ if {![runto_main]} { - perror "couldn't run to breakpoint main" return } diff --git a/gdb/testsuite/gdb.cp/static-method.exp b/gdb/testsuite/gdb.cp/static-method.exp index efe56049239..1499955f308 100644 --- a/gdb/testsuite/gdb.cp/static-method.exp +++ b/gdb/testsuite/gdb.cp/static-method.exp @@ -65,7 +65,6 @@ gdb_test_multiple $test $test { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/try_catch.exp b/gdb/testsuite/gdb.cp/try_catch.exp index 437309ada51..25c20409990 100644 --- a/gdb/testsuite/gdb.cp/try_catch.exp +++ b/gdb/testsuite/gdb.cp/try_catch.exp @@ -31,7 +31,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/userdef.exp b/gdb/testsuite/gdb.cp/userdef.exp index 5eba7e2cd81..0245a6ee9d7 100644 --- a/gdb/testsuite/gdb.cp/userdef.exp +++ b/gdb/testsuite/gdb.cp/userdef.exp @@ -28,7 +28,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/var-tag.exp b/gdb/testsuite/gdb.cp/var-tag.exp index e69f7c9df53..3a04dc6f5f4 100644 --- a/gdb/testsuite/gdb.cp/var-tag.exp +++ b/gdb/testsuite/gdb.cp/var-tag.exp @@ -82,7 +82,6 @@ with_test_prefix "before start" { # Run to main and test again. if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/virtbase.exp b/gdb/testsuite/gdb.cp/virtbase.exp index b026cfb4fba..1b83daf506b 100644 --- a/gdb/testsuite/gdb.cp/virtbase.exp +++ b/gdb/testsuite/gdb.cp/virtbase.exp @@ -24,7 +24,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/virtbase2.exp b/gdb/testsuite/gdb.cp/virtbase2.exp index d58403b7fa0..d55b02451bb 100644 --- a/gdb/testsuite/gdb.cp/virtbase2.exp +++ b/gdb/testsuite/gdb.cp/virtbase2.exp @@ -24,7 +24,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to main" return } diff --git a/gdb/testsuite/gdb.cp/virtfunc.exp b/gdb/testsuite/gdb.cp/virtfunc.exp index 23088f75850..8c2dc51d28a 100644 --- a/gdb/testsuite/gdb.cp/virtfunc.exp +++ b/gdb/testsuite/gdb.cp/virtfunc.exp @@ -274,7 +274,6 @@ proc do_tests {} { gdb_test_no_output "set width 0" "" if {![runto_main]} { - perror "couldn't run to breakpoint" return } test_ptype_of_classes diff --git a/gdb/testsuite/gdb.cp/virtfunc2.exp b/gdb/testsuite/gdb.cp/virtfunc2.exp index 3ec05301036..b2798b300e6 100644 --- a/gdb/testsuite/gdb.cp/virtfunc2.exp +++ b/gdb/testsuite/gdb.cp/virtfunc2.exp @@ -29,7 +29,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to breakpoint" return } diff --git a/gdb/testsuite/gdb.cp/watch-cp.exp b/gdb/testsuite/gdb.cp/watch-cp.exp index 8ef64bb59b7..62bedde8d54 100644 --- a/gdb/testsuite/gdb.cp/watch-cp.exp +++ b/gdb/testsuite/gdb.cp/watch-cp.exp @@ -22,7 +22,6 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} { } if {![runto_main]} { - perror "couldn't run to main" return } |