summaryrefslogtreecommitdiff
path: root/gdb/testsuite/gdb.base/gcore-tls-pie.exp
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2020-07-13 14:14:47 +0200
committerTom de Vries <tdevries@suse.de>2020-07-13 14:14:47 +0200
commit963eeee42ab212c2512b829143986fd3bb2fd93b (patch)
tree981f5c54298474c14961cc30a3564274a8d4fd91 /gdb/testsuite/gdb.base/gcore-tls-pie.exp
parentcf88be6855e5bb3d43e1fd78f28aeb2ec5fc11a1 (diff)
downloadbinutils-gdb-963eeee42ab212c2512b829143986fd3bb2fd93b.tar.gz
[gdb/testsuite] Handle missing gold linker in gdb.base/morestack.exp
When running test-case gdb.base/morestack.exp without the gold linker installed, we run into: ... Running src/gdb/testsuite/gdb.base/morestack.exp ... gdb compile failed, collect2: fatal error: cannot find 'ld' compilation terminated. FAIL: gdb.base/morestack.exp: continue === gdb Summary === nr of expected passes 1 nr of unexpected failures 1 nr of untested testcases 1 ... The test-case needs the gold linker to run correctly (as explained in commit b8d38ee425 "testsuite: Fix false FAIL for gdb.base/morestack.exp"), but only prefers it, and doesn't require it. Fix this by requiring the gold linker in the test-case. Furthermore, silence the compilation error by introducing a caching proc have_fuse_ld_gold and using it in this and other test-cases that use -fuse-ld=gold. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-07-13 Tom de Vries <tdevries@suse.de> * lib/gdb.exp (have_fuse_ld_gold): New caching proc. * gdb.base/gcore-tls-pie.exp: Use have_fuse_ld_gold. * gdb.base/gold-gdb-index.exp: Same. * gdb.base/morestack.exp: Same.
Diffstat (limited to 'gdb/testsuite/gdb.base/gcore-tls-pie.exp')
-rw-r--r--gdb/testsuite/gdb.base/gcore-tls-pie.exp4
1 files changed, 4 insertions, 0 deletions
diff --git a/gdb/testsuite/gdb.base/gcore-tls-pie.exp b/gdb/testsuite/gdb.base/gcore-tls-pie.exp
index 87399abfd8e..c9386c0620f 100644
--- a/gdb/testsuite/gdb.base/gcore-tls-pie.exp
+++ b/gdb/testsuite/gdb.base/gcore-tls-pie.exp
@@ -19,6 +19,10 @@
standard_testfile
+if { [have_fuse_ld_gold] == 0} {
+ return -1
+}
+
if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-fpie "ldflags=-pie -fuse-ld=gold"}]} {
return -1
}