diff options
| author | Keith Seitz <keiths@redhat.com> | 2020-05-11 10:27:32 -0700 |
|---|---|---|
| committer | Keith Seitz <keiths@redhat.com> | 2020-05-11 10:28:17 -0700 |
| commit | ba3e70b008d63b13207339443ad3b9a61ab996bc (patch) | |
| tree | 7cd0b0e92566f00d218613e5cb6d824b9e8a8845 /gdb/testsuite/gdb.ada/arrayptr.exp | |
| parent | 7666722fce2a26a32d9d931e9ce0fea8a7209185 (diff) | |
| download | binutils-gdb-ba3e70b008d63b13207339443ad3b9a61ab996bc.tar.gz | |
Clean-up gdb.ada test names
This patch fixes all duplicate and tail parentheses test names.
These can really hinder automated test analysis such as used by
the buildbot.
Before:
$ cat testsuite/gdb.sum | egrep "^(PASS|FAIL|XPASS|XFAIL|KPASS|KFAIL)" \
| sort | uniq -c | sort -n | grep -v " 1 "
2 PASS: gdb.ada/attr_ref_and_charlit.exp: print s'last
2 PASS: gdb.ada/bp_on_var.exp: set breakpoint pending off
2 PASS: gdb.ada/complete.exp: complete p pck.inne
2 PASS: gdb.ada/fun_overload_menu.exp: multiple matches for f (f (1, null))
2 PASS: gdb.ada/type_coercion.exp: p q
2 PASS: gdb.ada/unc_arr_ptr_in_var_rec.exp: print My_P_Object.Ptr when no longer null
3 PASS: gdb.ada/fun_overload_menu.exp: 1
After:
<empty>
For parentheses, I've audited all occurrences of trailing parentheses.
Most offenders are of the form:
gdb_test "p func (..)" $expected_result
I've either added a unique test name or simply removed the whitespace
between the function name and the argument list.
gdb/testsuite/ChangeLog
2020-05-11 Keith Seitz <keiths@redhat.com>
* gdb.ada/arrayparam.exp: Resolve duplicate and tail parentheses
test names.
* gdb.ada/arrayptr.exp: Likewise.
* gdb.ada/assign_arr.exp: Likewise.
* gdb.ada/attr_ref_and_charlit.exp: Likewise.
* gdb.ada/bp_on_var.exp: Likewise.
* gdb.ada/call_pn.exp: Likewise.
* gdb.ada/complete.exp: Likewise.
* gdb.ada/fun_overload_menu.exp: Likewise.
* gdb.ada/funcall_param.exp: Likewise.
* gdb.ada/funcall_ref.exp: Likewise.
* gdb.ada/packed_array_assign.exp: Likewise.
* gdb.ada/same_component_name.exp: Likewise.
* gdb.ada/type_coercion.exp: Likewise.
* gdb.ada/unc_arr_ptr_in_var_rec.exp: Likewise.
* gdb.ada/variant_record_packed_array.exp: Likewise.
Diffstat (limited to 'gdb/testsuite/gdb.ada/arrayptr.exp')
| -rw-r--r-- | gdb/testsuite/gdb.ada/arrayptr.exp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gdb/testsuite/gdb.ada/arrayptr.exp b/gdb/testsuite/gdb.ada/arrayptr.exp index e13ba8db199..ed91fe079b6 100644 --- a/gdb/testsuite/gdb.ada/arrayptr.exp +++ b/gdb/testsuite/gdb.ada/arrayptr.exp @@ -32,15 +32,15 @@ if ![runto "foo.adb:$bp_location" ] then { gdb_test "print string_p" \ "= \\(foo\\.string_access\\) 0x\[0-9a-zA-Z\]+" -gdb_test "print string_p (3..4)" "= \"ll\"" +gdb_test "print string_p(3..4)" "= \"ll\"" gdb_test "print null_string" "= \\(foo\\.string_access\\) 0x0" gdb_test "print arr_ptr" "= \\(access foo\\.little_array\\) 0x\[0-9a-zA-Z\]+" -gdb_test "print arr_ptr (2)" "= 22" +gdb_test "print arr_ptr(2)" "= 22" -gdb_test "print arr_ptr (3..4)" "= \\(3 => 23, 24\\)" +gdb_test "print arr_ptr(3..4)" "= \\(3 => 23, 24\\)" gdb_test "ptype string_access" "= access array \\(<>\\) of character" |