diff options
| author | Tom Tromey <tom@tromey.com> | 2018-03-27 14:31:10 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-03-30 13:22:58 -0600 |
| commit | e83e4e24021acb4b095b1e8a45a51c2ea088a1ed (patch) | |
| tree | 4740a6532e556fbb49a7de4234c2913796366212 /gdb/target.c | |
| parent | 263db9a1f4105b76ddf00829d50430ea0a3bcba6 (diff) | |
| download | binutils-gdb-e83e4e24021acb4b095b1e8a45a51c2ea088a1ed.tar.gz | |
Change target_read_string to use unique_xmalloc_ptr
This changes the out parameter of target_read_string to be a
unique_xmalloc_ptr. This avoids a cleanup and sets the stage for more
cleanup removals.
This patch also removes a seemingly needless alloca from
print_subexp_standard.
gdb/ChangeLog
2018-03-30 Tom Tromey <tom@tromey.com>
* windows-nat.c (handle_output_debug_string, handle_exception):
Update.
* target.h (target_read_string): Update.
* target.c (target_read_string): Change "string" to
unique_xmalloc_ptr.
* solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
Update.
* solib-frv.c (frv_current_sos): Update.
* solib-dsbt.c (dsbt_current_sos): Update.
* solib-darwin.c (darwin_current_sos): Update.
* linux-thread-db.c (inferior_has_bug): Update.
* expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
Update. Remove alloca.
* ada-lang.c (ada_main_name): Update.
Diffstat (limited to 'gdb/target.c')
| -rw-r--r-- | gdb/target.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/gdb/target.c b/gdb/target.c index 84f52289197..b9b2e757dd5 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -993,7 +993,8 @@ target_xfer_status_to_string (enum target_xfer_status status) read. */ int -target_read_string (CORE_ADDR memaddr, char **string, int len, int *errnop) +target_read_string (CORE_ADDR memaddr, gdb::unique_xmalloc_ptr<char> *string, + int len, int *errnop) { int tlen, offset, i; gdb_byte buf[4]; @@ -1053,7 +1054,7 @@ target_read_string (CORE_ADDR memaddr, char **string, int len, int *errnop) nbytes_read += tlen; } done: - *string = buffer; + string->reset (buffer); if (errnop != NULL) *errnop = errcode; return nbytes_read; |