diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2017-06-25 12:57:13 +0200 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2017-06-25 12:57:13 +0200 |
| commit | cc75e0fdaeb179efc66ddd1cb1b6da40e6adacc1 (patch) | |
| tree | a128810a367aad12116bfbd7c2e8bdc9da926d44 /gdb/main.c | |
| parent | 07809eafc959a0c588663c0c949eaf8044a1b40a (diff) | |
| download | binutils-gdb-cc75e0fdaeb179efc66ddd1cb1b6da40e6adacc1.tar.gz | |
main: Don't add int to string
clang shows this warning:
/home/emaisin/src/binutils-gdb/gdb/main.c:227:56: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
char *tmp_sys_gdbinit = xstrdup (SYSTEM_GDBINIT + datadir_len);
~~~~~~~~~~~~~~~^~~~~~~~~~~~~
/home/emaisin/src/binutils-gdb/gdb/main.c:227:56: note: use array indexing to silence this warning
char *tmp_sys_gdbinit = xstrdup (SYSTEM_GDBINIT + datadir_len);
^
& [ ]
It's quite easy to get rid of it by using &foo[len] instead of foo + len.
I think this warning is relevant to keep enabled, because it can be an
easy mistake to do.
This warning is already discussed here in GCC bugzilla:
https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00729.html
and a patch series for it was submitted very recently.
gdb/ChangeLog:
* main.c (get_init_files): Replace "SYSTEM_GDBINIT +
datadir_len" with "&SYSTEM_GDBINIT[datadir_len]".
Diffstat (limited to 'gdb/main.c')
| -rw-r--r-- | gdb/main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/main.c b/gdb/main.c index df4b1110d6b..9813041bca3 100644 --- a/gdb/main.c +++ b/gdb/main.c @@ -224,7 +224,7 @@ get_init_files (const char **system_gdbinit, { /* Append the part of SYSTEM_GDBINIT that follows GDB_DATADIR to gdb_datadir. */ - char *tmp_sys_gdbinit = xstrdup (SYSTEM_GDBINIT + datadir_len); + char *tmp_sys_gdbinit = xstrdup (&SYSTEM_GDBINIT[datadir_len]); char *p; for (p = tmp_sys_gdbinit; IS_DIR_SEPARATOR (*p); ++p) |