diff options
| author | Gary Benson <gbenson@redhat.com> | 2015-08-21 17:09:20 +0100 |
|---|---|---|
| committer | Gary Benson <gbenson@redhat.com> | 2015-08-21 17:11:36 +0100 |
| commit | 4313b8c0ed5877feb5034bfff4056e1ccfe221f1 (patch) | |
| tree | b5585d614337ee376a5dc247272d846254e1dc88 /gdb/inf-child.c | |
| parent | f36b87190aed31b1ef7787e5966be542e8abdb58 (diff) | |
| download | binutils-gdb-4313b8c0ed5877feb5034bfff4056e1ccfe221f1.tar.gz | |
Warn when accessing binaries from remote targets
GDB provides no indicator of progress during file operations, and can
appear to have locked up during slow remote transfers. This commit
updates GDB to print a warning each time a file is accessed over RSP.
An additional message detailing how to avoid remote transfers is
printed for the first transfer only.
gdb/ChangeLog:
* target.h (struct target_ops) <to_fileio_open>: New argument
warn_if_slow. Update comment. All implementations updated.
(target_fileio_open_warn_if_slow): New declaration.
* target.c (target_fileio_open): Renamed as...
(target_fileio_open_1): ...this. New argument warn_if_slow.
Pass warn_if_slow to implementation. Update debug printing.
(target_fileio_open): New function.
(target_fileio_open_warn_if_slow): Likewise.
* gdb_bfd.c (gdb_bfd_iovec_fileio_open): Use new function
target_fileio_open_warn_if_slow.
gdb/testsuite/ChangeLog:
* gdb.trace/pending.exp: Cope with remote transfer warnings.
Diffstat (limited to 'gdb/inf-child.c')
| -rw-r--r-- | gdb/inf-child.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/inf-child.c b/gdb/inf-child.c index 0326a93ae32..ada570d96f6 100644 --- a/gdb/inf-child.c +++ b/gdb/inf-child.c @@ -209,7 +209,8 @@ inf_child_pid_to_exec_file (struct target_ops *self, int pid) static int inf_child_fileio_open (struct target_ops *self, struct inferior *inf, const char *filename, - int flags, int mode, int *target_errno) + int flags, int mode, int warn_if_slow, + int *target_errno) { int nat_flags; mode_t nat_mode; |