diff options
| author | Sanimir Agovic <sanimir.agovic@intel.com> | 2014-02-05 16:22:08 +0000 |
|---|---|---|
| committer | Sanimir Agovic <sanimir.agovic@intel.com> | 2014-04-11 13:43:55 +0100 |
| commit | 3bce82377f683870cc89925ff43aefb7dcce4a77 (patch) | |
| tree | a085e16104071c342a6678d9d0e1e11cb0b4cfff /gdb/gdbtypes.c | |
| parent | 92b09522dc5a93ba4bda3c1c0b3c58264e357c8a (diff) | |
| download | binutils-gdb-3bce82377f683870cc89925ff43aefb7dcce4a77.tar.gz | |
vla: evaluate operand of sizeof if its type is a vla
The c99 standard in "6.5.3.4 The sizeof operator" states:
If the type of the operand is a variable length array type, the operand
is evaluated;[...]
This patch mirrors the following c99 semantic in gdb:
1| int vla[n][m];
2| int i = 1;
3| sizeof(vla[i++][0]); // No sideffect
4| assert (i == 1);
5| sizeof(vla[i++]); // With sideffect
6| assert (i == 2);
Note: ptype/whatsis still do not allow any sideeffects.
This patch was motivated by:
https://sourceware.org/ml/gdb-patches/2014-01/msg00732.html
* eval.c (evaluate_subexp_for_sizeof): Add enum noside argument.
(evaluate_subexp_standard): Pass noside argument.
(evaluate_subexp_for_sizeof) <BINOP_SUBSCRIPT>: Handle subscript case
if noside equals EVAL_NORMAL. If the subscript yields a vla type
re-evaluate subscript operation with EVAL_NORMAL to enable sideffects.
* gdbtypes.c (resolve_dynamic_bounds): Mark bound as evaluated.
* gdbtypes.h (enum range_flags): Add RANGE_EVALUATED case.
testsuite/gdb.base/
* vla-sideeffect.c: New file.
* vla-sideeffect.exp: New file.
Diffstat (limited to 'gdb/gdbtypes.c')
| -rw-r--r-- | gdb/gdbtypes.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index b7b4210902f..47b21209115 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -1708,6 +1708,7 @@ resolve_dynamic_bounds (struct type *type, CORE_ADDR addr) range_type = create_range_type (NULL, TYPE_TARGET_TYPE (range_type), &low_bound, &high_bound); + TYPE_RANGE_DATA (range_type)->flag_bound_evaluated = 1; return create_array_type (copy_type (type), elt_type, range_type); |