diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2022-01-24 20:00:46 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2022-01-26 10:01:40 -0500 |
| commit | 5d10a2041eb843fd321ce1d850cf3e0df7648bc7 (patch) | |
| tree | a1bd00ecbd780dc194da8d44b713b09f10446c0a /gdb/cli | |
| parent | b583c328e71369f90f4042ac7973ce9edfdb44b3 (diff) | |
| download | binutils-gdb-5d10a2041eb843fd321ce1d850cf3e0df7648bc7.tar.gz | |
gdb: add string_file::release method
A common pattern for string_file is to want to move out the internal
string buffer, because it is the result of the computation that we want
to return. It is the reason why string_file::string returns a non-const
reference, as explained in the comment. I think it would make sense to
have a dedicated method for that instead and make string_file::string
return a const reference.
This allows removing the explicit std::move in the typical case. Note
that compile_program::compute was missing a move, meaning that the
resulting string was copied. With the new version, it's not possible to
forget to move.
Change-Id: Ieaefa35b73daa7930b2f3a26988b6e3b4121bb79
Diffstat (limited to 'gdb/cli')
| -rw-r--r-- | gdb/cli/cli-setshow.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c index 4f563d9e0e1..99f35eb5092 100644 --- a/gdb/cli/cli-setshow.c +++ b/gdb/cli/cli-setshow.c @@ -659,7 +659,7 @@ get_setshow_command_value_string (const setting &var) gdb_assert_not_reached ("bad var_type"); } - return std::move (stb.string ()); + return stb.release (); } |