diff options
| author | Kevin Buettner <kevinb@redhat.com> | 2020-07-03 13:32:08 -0700 |
|---|---|---|
| committer | Kevin Buettner <kevinb@redhat.com> | 2020-07-22 12:44:13 -0700 |
| commit | 7e183d273682fe94c6b9777ae2f3d981f415b8cd (patch) | |
| tree | aaaba0da3cfd0faf29d83537da10d1c03fe6a7cc /gdb/arch-utils.h | |
| parent | 5efb677960e786a7cfa3b5a53f15cc6656f33f02 (diff) | |
| download | binutils-gdb-7e183d273682fe94c6b9777ae2f3d981f415b8cd.tar.gz | |
Add new gdbarch method, read_core_file_mappings
The new gdbarch method, read_core_file_mappings, will be used for
reading file-backed mappings from a core file. It'll be used
for two purposes: 1) to construct a table of file-backed mappings
in corelow.c, and 2) for display of core file mappings.
For Linux, I tried a different approach in which knowledge of the note
format was placed directly in corelow.c. This seemed okay at first;
it was only one note format and the note format was fairly simple.
After looking at FreeBSD's note/mapping reading code, I concluded
that it's best to leave architecture specific details for decoding
the note in (architecture specific) tdep files.
With regard to display of core file mappings, I experimented with
placing the mappings display code in corelow.c. It has access to the
file-backed mappings which were read in when the core file was loaded.
And, better, still common code could be used for all architectures.
But, again, the FreeBSD mapping code convinced me that this was not
the best approach since it has even more mapping info than Linux.
Display code which would work well for Linux will leave out mappings
as well as protection info for mappings.
So, for these reasons, I'm introducing a new gdbarch method for
reading core file mappings.
gdb/ChangeLog:
* arch-utils.c (default_read_core_file_mappings): New function.
* arch-utils.c (default_read_core_file_mappings): Declare.
* gdbarch.sh (read_core_file_mappings): New gdbarch method.
* gdbarch.h, gdbarch.c: Regenerate.
Diffstat (limited to 'gdb/arch-utils.h')
| -rw-r--r-- | gdb/arch-utils.h | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/gdb/arch-utils.h b/gdb/arch-utils.h index 43d64b1f4f2..8cb0db04c8c 100644 --- a/gdb/arch-utils.h +++ b/gdb/arch-utils.h @@ -280,4 +280,16 @@ extern ULONGEST default_type_align (struct gdbarch *gdbarch, extern std::string default_get_pc_address_flags (frame_info *frame, CORE_ADDR pc); +/* Default implementation of gdbarch read_core_file_mappings method. */ +extern void default_read_core_file_mappings (struct gdbarch *gdbarch, + struct bfd *cbfd, + gdb::function_view<void (ULONGEST count)> + pre_loop_cb, + gdb::function_view<void (int num, + ULONGEST start, + ULONGEST end, + ULONGEST file_ofs, + const char *filename, + const void *other)> + loop_cb); #endif /* ARCH_UTILS_H */ |