diff options
| author | Alan Modra <amodra@gmail.com> | 2021-02-23 12:10:58 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-02-24 09:34:42 +1030 |
| commit | c42c71a1527dd70417d3966dce7ba9edbcf4bdb4 (patch) | |
| tree | c84495ca493b5b03e8e144701fcc276a01d736d5 /binutils/bucomm.h | |
| parent | cca8873dd5a6015d5557ea44bc1ea9c252435a29 (diff) | |
| download | binutils-gdb-c42c71a1527dd70417d3966dce7ba9edbcf4bdb4.tar.gz | |
Use make_tempname file descriptor in smart_rename
This patch makes use of the temp file descriptor in smart_rename
rather than reopening the file. I don't believe there is a security
issue in reopening the file, but this way is one less directory
operation. The patch also attempts to preserve S_ISUID and S_ISGID.
PR 27456
* bucomm.h (smart_rename): Update prototype.
* rename.c (smart_rename): Add fromfd and preserve_dates params.
Pass fromfd and target_stat to simple_copy. Call set_times
when preserve_dates.
(simple_copy): Accept fromfd rather than from filename. Add
target_stat param. Rewind fromfd rather than opening. Open
"to" file without O_CREAT. Try to preserve S_ISUID and S_ISGID.
* ar.c (write_archive): Rename ofd to tmpfd. Dup tmpfd before
closing output temp file, and pass tmpfd to smart_rename.
* arsup.c (temp_fd): Rename from real_fd.
(ar_save): Dup temp_fd and pass to smart_rename.
* objcopy.c (strip_main, copy_main): Likewise, and pass
preserve_dates.
Diffstat (limited to 'binutils/bucomm.h')
| -rw-r--r-- | binutils/bucomm.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/binutils/bucomm.h b/binutils/bucomm.h index aa7e33d8cd1..f1ae47fa1b5 100644 --- a/binutils/bucomm.h +++ b/binutils/bucomm.h @@ -71,7 +71,8 @@ extern void print_version (const char *); /* In rename.c. */ extern void set_times (const char *, const struct stat *); -extern int smart_rename (const char *, const char *, struct stat *); +extern int smart_rename (const char *, const char *, int, + struct stat *, bfd_boolean); /* In libiberty. */ |