diff options
| author | Alan Modra <amodra@gmail.com> | 2021-03-29 09:42:37 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-03-29 11:22:21 +1030 |
| commit | f4f9ede04272c1417b187afe6964e5c0687f1904 (patch) | |
| tree | c8a3f5bfa5203c3fe01dba909ad82b76b4af8be6 /bfd/vms-lib.c | |
| parent | 1201fda61b3bcf0028a57e622aebb16ec614f7dc (diff) | |
| download | binutils-gdb-f4f9ede04272c1417b187afe6964e5c0687f1904.tar.gz | |
Miscellaneous BFD int vs bfd_boolean fixes
nds32 hyper_relax takes values of 0, 1 and 2. vms_write_data_block
return TRUE/FALSE not positive/negative.
* coff-z80.c (z80_is_local_label_name): Return bfd_boolean.
* elf32-z80.c (z80_is_local_label_name): Likewise.
* elf32-spu.c (spu_elf_modify_headers): Likewise.
* elf32-nds32.h (struct elf_nds32_link_hash_table <hyper_relax>):
Change type to int.
* vms-lib.c (_bfd_vms_lib_write_archive_contents): Correct test
for error return from vms_write_data_block.
Diffstat (limited to 'bfd/vms-lib.c')
| -rw-r--r-- | bfd/vms-lib.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/bfd/vms-lib.c b/bfd/vms-lib.c index eaac8af2a22..72038b4c89e 100644 --- a/bfd/vms-lib.c +++ b/bfd/vms-lib.c @@ -2280,7 +2280,7 @@ _bfd_vms_lib_write_archive_contents (bfd *arch) else { /* Write the MHD. */ - if (vms_write_data_block (arch, &data, &off, blk, sz, 0) < 0) + if (!vms_write_data_block (arch, &data, &off, blk, sz, 0)) goto input_err; /* Write the member. */ @@ -2289,13 +2289,13 @@ _bfd_vms_lib_write_archive_contents (bfd *arch) sz = bfd_bread (blk, sizeof (blk), current); if (sz == 0) break; - if (vms_write_data_block (arch, &data, &off, blk, sz, 0) < 0) + if (!vms_write_data_block (arch, &data, &off, blk, sz, 0)) goto input_err; } /* Write the end of module marker. */ - if (vms_write_data_block (arch, &data, &off, - eotdesc, sizeof (eotdesc), 1) < 0) + if (!vms_write_data_block (arch, &data, &off, + eotdesc, sizeof (eotdesc), 1)) goto input_err; } } |