diff options
| author | Jon Turney <jon.turney@dronecode.org.uk> | 2020-06-29 15:54:41 +0100 |
|---|---|---|
| committer | Jon Turney <jon.turney@dronecode.org.uk> | 2020-08-12 15:08:21 +0100 |
| commit | ff2084b9ef793b98241c6801217d3c3465baabbe (patch) | |
| tree | e52692e6c70e8e3d3977009a36791bad49ef6049 /bfd/elf.c | |
| parent | c0ab14ae2a448941bc3bdc4266795e6ef2c38d85 (diff) | |
| download | binutils-gdb-ff2084b9ef793b98241c6801217d3c3465baabbe.tar.gz | |
Read tid from correct offset in win32pstatus NOTE_INFO_THREAD
Fix the offset used to read the tid from a win32pstatus ELF note.
This probably meant that registers were only being correctly recovered
from the core dump for the current thread.
It looks like this has beeen incorrect since 4a6636fb.
Also fix offsets used in NOTE_INFO_PROCESS (which is not actually
generated by the Cygwin dumper tool).
Also improve comment.
bfd/ChangeLog:
2020-07-01 Jon Turney <jon.turney@dronecode.org.uk>
* elf.c (elfcore_grok_win32pstatus): Fix the offset used to read
the tid from a win32pstatus NOTE_INFO_THREAD ELF note. Fix
offsets used to read NOTE_INFO_PROCESS.
Diffstat (limited to 'bfd/elf.c')
| -rw-r--r-- | bfd/elf.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/bfd/elf.c b/bfd/elf.c index cc2b46ccc7f..0bae0aacdb6 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -10151,15 +10151,16 @@ elfcore_grok_win32pstatus (bfd *abfd, Elf_Internal_Note *note) case 1 /* NOTE_INFO_PROCESS */: /* FIXME: need to add ->core->command. */ /* process_info.pid */ - elf_tdata (abfd)->core->pid = bfd_get_32 (abfd, note->descdata + 8); + elf_tdata (abfd)->core->pid = bfd_get_32 (abfd, note->descdata + 4); /* process_info.signal */ - elf_tdata (abfd)->core->signal = bfd_get_32 (abfd, note->descdata + 12); + elf_tdata (abfd)->core->signal = bfd_get_32 (abfd, note->descdata + 8); break; case 2 /* NOTE_INFO_THREAD */: - /* Make a ".reg/999" section. */ + /* Make a ".reg/<tid>" section containing the Win32 API thread CONTEXT + structure. */ /* thread_info.tid */ - sprintf (buf, ".reg/%ld", (long) bfd_get_32 (abfd, note->descdata + 8)); + sprintf (buf, ".reg/%ld", (long) bfd_get_32 (abfd, note->descdata + 4)); len = strlen (buf) + 1; name = (char *) bfd_alloc (abfd, len); |