summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-03-25 08:50:21 +1030
committerAlan Modra <amodra@gmail.com>2020-03-25 08:54:18 +1030
commita18cd0cab43f45b05e9f8bcbf8fed1d67834442d (patch)
treeb8464b95e02f76bd28141b06ad4d16dd837c7ca8
parent5ab2fbf185935f387fd5c1f8b14ba9fe04b41b39 (diff)
downloadbinutils-gdb-a18cd0cab43f45b05e9f8bcbf8fed1d67834442d.tar.gz
Uninitialised memory read in z80-dis.c
objdump -d -m ez80-adl testcase: .byte 0x40,0xfd * z80-dis.c (suffix): Init mybuf.
-rw-r--r--opcodes/ChangeLog4
-rw-r--r--opcodes/z80-dis.c1
2 files changed, 5 insertions, 0 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 4c05e849daf..bdfccbac78c 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-25 Alan Modra <amodra@gmail.com>
+
+ * z80-dis.c (suffix): Init mybuf.
+
2020-03-22 Alan Modra <amodra@gmail.com>
* h8300-dis.c (bfd_h8_disassemble): Limit data[] access to that
diff --git a/opcodes/z80-dis.c b/opcodes/z80-dis.c
index b23e8e99fd8..cd840444511 100644
--- a/opcodes/z80-dis.c
+++ b/opcodes/z80-dis.c
@@ -804,6 +804,7 @@ suffix (struct buffer *buf, disassemble_info *info, const char *txt)
old_stream = info->stream;
info->fprintf_func = (fprintf_ftype) &sprintf;
info->stream = mybuf;
+ mybuf[0] = 0;
buf->base++;
if (print_insn_z80_buf (buf, info) >= 0)
buf->n_used++;