diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2022-12-01 11:44:41 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2022-12-01 11:44:41 -0500 |
| commit | 00a5867df72983c3f8a11c9955c5032d6f601b70 (patch) | |
| tree | 07e39cd403db4bc84f577f1e09067c4b9dbaba5e | |
| parent | 616d7b31c8f468043bf6b858cbcb42fee6a86a9a (diff) | |
| download | binutils-gdb-00a5867df72983c3f8a11c9955c5032d6f601b70.tar.gz | |
gdb/dwarf: add some QUIT macros
While testing the fix for PR 29105, I noticed I couldn't ctrl-C my way
out of GDB expanding many symtabs. GDB was busy in a loop in
cooked_index_functions::expand_symtabs_matching. Add a QUIT there. I
also happened to see a spot in
cooked_index_functions::expand_matching_symbols where a QUIT would be
useful too, since we iterate over a potentially big number of index
entries and expand CUs in the loop. Add one there too.
Change-Id: Ie1d650381df7f944c16d841b3e592d2dce7306c3
Approved-By: Kevin Buettner <kevinb@redhat.com>
| -rw-r--r-- | gdb/dwarf2/read.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 87c0914d839..dd7fea40027 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -18653,6 +18653,8 @@ cooked_index_functions::expand_matching_symbols (per_objfile->per_bfd->index_table.get ())); for (const cooked_index_entry *entry : table->all_entries ()) { + QUIT; + if (entry->parent_entry != nullptr) continue; @@ -18728,6 +18730,8 @@ cooked_index_functions::expand_symtabs_matching for (const cooked_index_entry *entry : table->find (name_vec.back (), completing)) { + QUIT; + /* No need to consider symbols from expanded CUs. */ if (per_objfile->symtab_set_p (entry->per_cu)) continue; |