diff options
| author | Nick Alcock <nick.alcock@oracle.com> | 2021-02-03 14:09:02 +0000 |
|---|---|---|
| committer | Nick Alcock <nick.alcock@oracle.com> | 2021-02-04 22:15:19 +0000 |
| commit | 3b0aa7f1b2033ab4f82b2351ccca61c3f396523a (patch) | |
| tree | cf5c4ca0714d0e501bf38ecc388b5d4dd3b28c26 | |
| parent | ce00f78576d71f4ba2cbaa2712946ae499955621 (diff) | |
| download | binutils-gdb-users/nalcock/included-gettext.tar.gz | |
libctf: add missing header in BFD ELF checkusers/nalcock/included-gettext
Without this, GCC warns:
In file included from conftest.c:36:
../../libctf/../bfd/elf-bfd.h: In function 'bfd_section_is_ctf':
../../libctf/../bfd/elf-bfd.h:3089:10: warning: implicit declaration of function 'strncmp' [-Wimplicit-function-declaration]
3089 | return strncmp (name, ".ctf", 4) == 0 && (name[4] == 0 || name[4] == '.');
| ^~~~~~~
../../libctf/../bfd/elf-bfd.h:3089:33: warning: 'strncmp' argument 3 type is 'int' where 'long unsigned int' is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch]
3089 | return strncmp (name, ".ctf", 4) == 0 && (name[4] == 0 || name[4] == '.');
| ^
<built-in>: note: built-in 'strncmp' declared here
These warnings do not currently throw off the result of the configure
check, but it's better to squash them anyway.
libctf/ChangeLog
2021-02-03 Nick Alcock <nick.alcock@oracle.com>
* configure.ac (ac_cv_libctf_bfd_elf): Include string.h.
* configure: Regenerated.
| -rw-r--r-- | libctf/ChangeLog | 5 | ||||
| -rwxr-xr-x | libctf/configure | 8 | ||||
| -rw-r--r-- | libctf/configure.ac | 1 |
3 files changed, 12 insertions, 2 deletions
diff --git a/libctf/ChangeLog b/libctf/ChangeLog index 135add5a6c2..cf529038d70 100644 --- a/libctf/ChangeLog +++ b/libctf/ChangeLog @@ -1,5 +1,10 @@ 2021-02-03 Nick Alcock <nick.alcock@oracle.com> + * configure.ac (ac_cv_libctf_bfd_elf): Include string.h. + * configure: Regenerated. + +2021-02-03 Nick Alcock <nick.alcock@oracle.com> + * configure.ac (EXPECT): Check for, in order to define... (TCL_TRY): ... this, if Tcl supports try/catch. * Makefile.am (TCL_TRY): Run the testsuite only if set. diff --git a/libctf/configure b/libctf/configure index fcd555ab1e3..d5b78611574 100755 --- a/libctf/configure +++ b/libctf/configure @@ -636,6 +636,9 @@ am__EXEEXT_TRUE LTLIBOBJS LIBOBJS VERSION_FLAGS +TCL_TRY_FALSE +TCL_TRY_TRUE +EXPECT CTF_LIBADD SHARED_LDFLAGS NEED_CTF_QSORT_R_FALSE @@ -11539,7 +11542,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 11542 "configure" +#line 11545 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -11645,7 +11648,7 @@ else lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 lt_status=$lt_dlunknown cat > conftest.$ac_ext <<_LT_EOF -#line 11648 "configure" +#line 11651 "configure" #include "confdefs.h" #if HAVE_DLFCN_H @@ -12872,6 +12875,7 @@ else cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ #include <stdlib.h> + #include <string.h> #include "bfd.h" #include "elf-bfd.h" int diff --git a/libctf/configure.ac b/libctf/configure.ac index c6b80442e07..90e3c437d60 100644 --- a/libctf/configure.ac +++ b/libctf/configure.ac @@ -88,6 +88,7 @@ intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty -lz $intl $LIBS" AC_CACHE_CHECK([for ELF support in BFD], ac_cv_libctf_bfd_elf, [AC_TRY_LINK([#include <stdlib.h> + #include <string.h> #include "bfd.h" #include "elf-bfd.h"], [(void) bfd_section_from_elf_index (NULL, 0); |