diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2016-02-22 19:10:14 -0800 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2016-02-22 19:10:35 -0800 |
| commit | 5f0e933d5c1f9667ef83e5d1bd62bc350c04191a (patch) | |
| tree | 762c2ca6e805e8a8b87ce05265cb3255bb5df8cc | |
| parent | 2d8dcb8135e454c47bc8609e3f9d89b29ef0b8d2 (diff) | |
| download | binutils-gdb-users/hjl/pr19698/master.tar.gz | |
Update symbol version for symbol from linker scriptusers/hjl/pr19698/master
We need to update symbol version for symbols from linker script.
bfd/
PR ld/19698
* elflink.c (bfd_elf_record_link_assignment): Set versioned if
symbol version is unknown.
ld/
PR ld/19698
* testsuite/ld-elf/pr19698.d: New file.
* testsuite/ld-elf/pr19698.s: Likewise.
* testsuite/ld-elf/pr19698.t: Likewise.
| -rw-r--r-- | bfd/elflink.c | 13 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/pr19698.d | 10 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/pr19698.s | 5 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/pr19698.t | 11 |
4 files changed, 39 insertions, 0 deletions
diff --git a/bfd/elflink.c b/bfd/elflink.c index 89a6dea7614..1fa793adcc4 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -555,6 +555,19 @@ bfd_elf_record_link_assignment (bfd *output_bfd, if (h == NULL) return provide; + if (h->versioned == unknown) + { + /* Set versioned if symbol version is unknown. */ + char *version = strrchr (name, ELF_VER_CHR); + if (version) + { + if (version > name && version[-1] != ELF_VER_CHR) + h->versioned = versioned_hidden; + else + h->versioned = versioned; + } + } + switch (h->root.type) { case bfd_link_hash_defined: diff --git a/ld/testsuite/ld-elf/pr19698.d b/ld/testsuite/ld-elf/pr19698.d new file mode 100644 index 00000000000..a39f67a3ba9 --- /dev/null +++ b/ld/testsuite/ld-elf/pr19698.d @@ -0,0 +1,10 @@ +#ld: -shared $srcdir/$subdir/pr19698.t +#readelf : --dyn-syms --wide +#target: *-*-linux* *-*-gnu* *-*-solaris* + +Symbol table '\.dynsym' contains [0-9]+ entries: +#... + +[0-9]+: +[0-9a-f]+ +[0-9a-f]+ +FUNC +GLOBAL +DEFAULT +[0-9]+ +foo@VERS.1 +#... + +[0-9]+: +[0-9a-f]+ +[0-9a-f]+ +FUNC +GLOBAL +DEFAULT +[0-9]+ +foo@@VERS.2 +#pass diff --git a/ld/testsuite/ld-elf/pr19698.s b/ld/testsuite/ld-elf/pr19698.s new file mode 100644 index 00000000000..875dca49288 --- /dev/null +++ b/ld/testsuite/ld-elf/pr19698.s @@ -0,0 +1,5 @@ + .text + .globl foo + .type foo, %function +foo: + .byte 0 diff --git a/ld/testsuite/ld-elf/pr19698.t b/ld/testsuite/ld-elf/pr19698.t new file mode 100644 index 00000000000..09d9125019f --- /dev/null +++ b/ld/testsuite/ld-elf/pr19698.t @@ -0,0 +1,11 @@ +"foo@VERS.1" = foo; + +VERSION { +VERS.2 { + global: + foo; +}; + +VERS.1 { +}; +} |