diff options
| author | mengqinggang <mengqinggang@loongson.cn> | 2023-01-09 16:35:26 +0800 |
|---|---|---|
| committer | liuzhensong <liuzhensong@loongson.cn> | 2023-01-16 09:05:46 +0800 |
| commit | 87cb95ba8c4d86de23b6ba694a126995a17c5fcd (patch) | |
| tree | 2ee2f645c6e7ebd3c9744df567839a52140e3950 | |
| parent | 9d131130d2f35f1515855d786a9905d8eb8cce8f (diff) | |
| download | binutils-gdb-binutils-2_39-branch.tar.gz | |
LoongArch: ld: Fix hidden ifunc symbol linker error bug.binutils-2_39-branch
For hidden ifunc symbols, it not have GOT entry, only have gotplt entry. When
process R_LARCH_SOP_PUSH_GPREL, the offset is gotplt entry address minus GOT
address. When call bfd_put_NN(got->contents + offset), the absolute value of
offset is grather than got size, and other memory not belonging to GOT is be
overwritten.
bfd/ChangeLog:
* elfnn-loongarch.c (loongarch_elf_relocate_section): If hidden ifunc
symbol, don't call bfd_put_NN.
| -rw-r--r-- | bfd/elfnn-loongarch.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c index fafdc7c7458..449fad6d25d 100644 --- a/bfd/elfnn-loongarch.c +++ b/bfd/elfnn-loongarch.c @@ -2502,7 +2502,10 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info, if ((off & 1) != 0) off &= ~1; - else + /* If h has processed (h->got.offset |= 1) or h is hideen + ifunc (h->got.offset == -1), skip it. Hidden ifunc symbol + not has got entry, only has got.plt entry. */ + else if ((h->got.offset & 1) == 0) { /* The pr21964-4. Create relocate entry. */ if (is_pic && h->start_stop) |