| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I ran this on each directory with C files:
clang-format -i *.[ch]
"-i" is the in-place option.
I also adjusted the order of #includes for some files which failed to
build after that:
Clang-format reorders blocks of #include directives alphabetically,
but they can be grouped and separated by blank lines. If there is a
blank line between blocks, like
#include "zork.h"
#include "bar.h"
#include "foo.h"
then it will not put zork.h after the other two. The last two header
files will be sorted alphabetically.
We can adjust the formatting of chunks of code by hand with comments
like these:
/* clang-format off */
this code {
is, formatted, by, hand;
}
/* clang-format on */
See https://clang.llvm.org/docs/ClangFormat.html for the general
manual and https://clang.llvm.org/docs/ClangFormatStyleOptions.html
for the style options and the comments described above.
|
| |
|
|
|
|
| |
I have no idea what that even was :)
|
|
|
|
|
|
|
|
|
|
| |
really bad down the line
Fixes static-scan warnings of this kind:
../../../dbind/dbtest.c:83:18: warning: The left operand of '==' is a garbage value [core.UndefinedBinaryOperatorResult]
g_assert (v2 == 42);
~~ ^
|
|
|
|
|
| |
va_arg() will just consume each value; there is no need to store it
anywhere.
|
|
|
|
| |
The code is testing the demarshaled value, which lives in q, not in p.
|
| |
|
|
|
|
|
| |
Printing to stderr makes testsuite analysis think there were some
errors.
|
|
|
|
| |
Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/2
|
| |
|
|
|
|
|
| |
Use the appropriate pointer type when testing dbind_any_marshal() and
dbind_any_demarshal().
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the atspi library definition in meson.build to `library()`
instead of `shared_library()` so that when meson is called with
`--default-library static` a static library is built.
For this to work, also change the `declare_dependency()` in
`dbind/meson.build` to be a list of sources instead of a `link_with:`
`static_library()`.
https://bugzilla.gnome.org/show_bug.cgi?id=793762
|
| |
|
|
|
|
| |
Fix typo
|
|
|
|
|
|
|
|
| |
We use AM_SILENT_RULES but ask for automake 1.9 at the minimum, which
didn't have AM_SILENT_RULES (they were introduced in 1.11.2).
Additionally, we want AM_PROC_CC_C_O, not AC_PROG_CC, to find out our
C compiler.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Meson is a meta-build system which provides us with various advantages
over Autotools:
- it's portable to various platforms
- it's easy to understand
- it's fast
- it's well maintained
Various libraries in the GNOME stack have been ported to it, including
GTK+ itself.
|
|
|
|
|
|
|
|
|
| |
Since the AC_CHECK_ALIGNOF() macro fills the config.h header with
ALIGNOF_<type> definitions, there's no longer a need for the
DBIND_ALIGNOF_<type> definitions. This commit gets rid of them, and
also gets rid of the dbing-config.h file.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As recommended during autoreconf:
dbind/Makefile.am:1: while processing Libtool library 'libdbind.la'
dbind/Makefile.am:23: warning: source file '../atspi/atspi-gmain.c' is in a subdirectory,
dbind/Makefile.am:23: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled. For now, the corresponding output
automake: object file(s) will be placed in the top-level directory. However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DBIND_CHECK_ALIGNOF() is a custom autoconf macro from at-spi2-core
that tests the alignment required on the current platform for a given
C type. Unfortunately, this macro uses AC_TRY_RUN(), which requires
running a test program on the target platform, which is fundamentally
incompatible with cross-compilation.
Therefore, this patch switches the configure.ac code to use
AC_CHECK_ALIGNOF() instead, which is available in the standard set of
autoconf macros, and is able to test the required alignment for C
types without using AC_TRY_RUN(). Consequently, it adjusts the
dbind/dbind-config.h.in definitions to use the definitions created by
the AC_CHECK_ALIGNOF() macros, which are not substituted by autoconf,
but directly available from config.h.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
dbind isn't currently running a GMainLoop, so it shouldn't call
atspi_dbus_connection_setup_with_g_main, and calling this is harmful if
it is being called from a context other than the default context, since
D-Bus messages will no longer be delivered.
https://bugzilla.gnome.org/show_bug.cgi?id=707218
|
|
|
|
|
|
| |
dbus_connection_dispatch is trying to lock the connection when it is
already locked, resulting in a deadlock, so just don't call it
recursively for now.
|
|
|
|
|
|
|
|
|
|
| |
If no main loop is running, then the dbus connection's incoming message
queue was never emptied, so with, eg, dogtail,
dbus_connection_send_with_reply_and_block would take longer and longer
to look through the message queue to find a reply. This also effectively
led to a memory leak.
https://bugzilla.gnome.org/show_bug.cgi?id=701145
|
|
|
|
|
|
|
|
|
|
|
| |
When timing out without having received a reply from a pending call,
then
cancel the call so that it will be removed from the DBusConnection's
queue. This will hopefully prevent the call and the
SpiReentrantCallClosure from being leaked.
Note that this code is still behaving oddly (why isn't a notification
being sent by libdbus when the specified amount of time has ellapsed?)
|
| |
|
|
|
|
|
|
|
| |
Dbind-config.h is generated by configure and should not be part of the
release.
https://bugzilla.gnome.org/show_bug.cgi?id=688083
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=684033
|
|
|
|
|
| |
When a method reply of the wrong type was received, the parameters were
still sent backwards when formatting the GError.
|
|
|
|
|
| |
The message displayed by dbind for a type mismatch had its parameters
inverted.
|
|
|
|
|
|
| |
When making a method call, we should check that the signature of the
reply matches what we expect and throw an error if not. Otherwise we may
crash.
|
|
|
|
|
|
|
|
|
| |
If a method call times out, record the process as being hung, and send a
ping. Consider the process to be no longer hung when a response to the
ping is received.
Hopefully this will prevent long delays if an AT makes consecutive calls
on an application that is not responding.
|
|
|
|
|
| |
Include atspi-gmain.h from dbind rather than atspi.h, since atspi.h includes
atspi-enum-types.h, which has not yet been built.
|
|
|
|
|
|
|
| |
Putting reentrant call closures on the stack can be dangerous if set_reply
is called after the caller has timed out and returned, for instance, so better
to dynamically allocate them. This will hopefully fix some crashes and
hopefully not leak memory.
|
|
|
|
|
|
|
|
|
|
| |
- atspi-application.h makes use of DBusConnection* .
- -Werror-implicit-function-declaration doesn't contain an equal sign in
my copy of gcc, and is gcc specific.
- The default behaviour of AC_CHECK_LIB glib-2.0 is to add -lglib-2.0 to
LIBS which can then cause the search for a dlopen function to fail
because the flags to find libglib aren't included. Solution is to
tell AC_CHECK_LIB to do nothing(!)
|
| |
|
| |
|
|
|
|
|
|
| |
Add in a modified version of dbus-gmain.c so that we can stop dependeing on
dbus-glib and include a currently unreviewed fix for FDO#35115.
Also add a pc file and bump version to 1.91.92.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=641164
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Events and DeviceEvents are now sent with transfer full to work around
a possible pygi bug.
Various other fixes.
|
| |
|
| |
|