diff options
| author | Federico Mena Quintero <federico@gnome.org> | 2022-12-01 20:14:54 -0600 |
|---|---|---|
| committer | Federico Mena Quintero <federico@gnome.org> | 2022-12-01 20:14:54 -0600 |
| commit | 4402c74d6d6ac5faccd63fcc8dd11c4002c9e85d (patch) | |
| tree | 5e51cf927f5d8aa13ccb69e715f4ceb8c4f3d5eb /registryd | |
| parent | 2455a4f330e8ea7fbce9fc2d1418f6f33e66d8e4 (diff) | |
| download | at-spi2-core-4402c74d6d6ac5faccd63fcc8dd11c4002c9e85d.tar.gz | |
SpiDEController: don't push the controller itself into the message_queue
These two pointers were pushed at the same time into controller->message_queue:
message to be processed later
user_data / controller
And later they were popped to handle the message. But since we now
weave the controller via the user_data everywhere, there's no need to
keep an extra copy in the message_queue.
This also leaves homogeneous elements, of the same type, in the
message_queue, for peace of mind.
Diffstat (limited to 'registryd')
| -rw-r--r-- | registryd/deviceeventcontroller.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/registryd/deviceeventcontroller.c b/registryd/deviceeventcontroller.c index 6c42c9c8..8bb25fd3 100644 --- a/registryd/deviceeventcontroller.c +++ b/registryd/deviceeventcontroller.c @@ -1996,7 +1996,6 @@ message_queue_dispatch (gpointer data) while (!g_queue_is_empty (controller->message_queue)) { DBusMessage *message = g_queue_pop_head (controller->message_queue); - data = g_queue_pop_head (controller->message_queue); handle_dec_method_from_idle (controller->bus, message, controller); dbus_message_unref (message); } @@ -2019,7 +2018,6 @@ handle_dec_method (DBusConnection *bus, DBusMessage *message, void *user_data) dbus_message_ref (message); g_queue_push_tail (controller->message_queue, message); - g_queue_push_tail (controller->message_queue, user_data); if (!controller->message_queue_idle) { controller->message_queue_idle = g_idle_add (message_queue_dispatch, controller); g_source_set_name_by_id (controller->message_queue_idle, "[at-spi2-core] message_queue_dispatch"); |