atspi_register_device_event_listener(): turn into a no-op.

This function is never called from pyatspi2 nor from orca.  It was
meant to be the way to register for mouse events, but that is done
with the Registry.RegisterEvent("mouse", ...) method instead.

I've turned the function into a no-op to avoid ABI breakage.  We can
remove it when we have an ABI break.

1 files changed, 5 insertions, 32 deletions

diff --git a/atspi/atspi-registry.c b/atspi/atspi-registry.c
index 752ef8af..823ca934 100644
--- a/atspi/atspi-registry.c
+++ b/atspi/atspi-registry.c
@@ -360,45 +360,18 @@ atspi_deregister_keystroke_listener (AtspiDeviceListener *listener,
 
 /**
  * atspi_register_device_event_listener:
- * @listener:  a pointer to the #AtspiDeviceListener which requests
- *             the events.
- * @event_types: an #AtspiDeviceEventMask mask indicating which
- *             types of key events are requested (%ATSPI_KEY_PRESSED, etc.).
- * @filter: (allow-none): Unused parameter.
- * @error: (allow-none): a pointer to a %NULL #GError pointer, or %NULL
- *             
- * Registers a listener for device events, for instance button events.
  *
- * Returns: %TRUE if successful, otherwise %FALSE.
+ * This function does nothing and should not be called.
+ *
+ * Returns: Always returns %FALSE.
  **/
 gboolean
 atspi_register_device_event_listener (AtspiDeviceListener  *listener,
 				 AtspiDeviceEventMask  event_types,
 				 void                      *filter, GError **error)
 {
-  gboolean                          retval = FALSE;
-  dbus_uint32_t d_event_types = event_types;
-  gchar *path;
-  DBusError d_error;
-
-  if (!listener)
-    {
-      return retval;
-    }
-
-  dbus_error_init (&d_error);
-
-  path = _atspi_device_listener_get_path (listener);
-
-    dbind_method_call_reentrant (_atspi_bus(), atspi_bus_registry, atspi_path_dec, atspi_interface_dec, "RegisterDeviceEventListener", &d_error, "ou=>b", path, d_event_types, &retval);
-    if (dbus_error_is_set (&d_error))
-      {
-        g_warning ("RegisterDeviceEventListener failed: %s", d_error.message);
-        dbus_error_free (&d_error);
-      }
-
-  g_free (path);
-  return retval;
+  /* See https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/94 for why this code is removed */
+  return FALSE;
 }
 
 /**