| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
| |
Replace use of old `ansible.module_utils._text` and add a unit test to maintain backwards compatibility.
|
| |
|
|
|
|
|
| |
(#80449)
validate the full user and perm strings instead of just first character
fixes unhelpful unarchive error for some invalid modes
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Symbolic modes with X or =[ugo] always use original mode (Fixes #80128)
Here's what's happening, by way of this mode example: u=,u=rX
At the first step in the loop, the "u" bits of are set to 0. On the next
step in the loop, the current stat of the filesystem object is used to
determine X, not the "new_mode" in the previous iteration of the loop. So
while most operations kind of operate left to right, "X" is always going
back to the original file to determine whether to set x bit.
The Linux "chmod" (the only one I've tested) doesn't operate this way. In
it, "X" operates on the current state the loop understands it is in,
based on previous operations (and starting with the file permissions).
This is an issue with "X" and any of the "=[ugo]" settings, because
they are lookups. For example, if a file is 755 and you do "ug=rx,o=u",
file module produces 0557 and chmod produces 0555.
This really becomes a problem when you want to recursively change a
directory of files, and the files are currently 755, but you want to
change the directory to 750 and the files to 640. In chmod you can do
"a=,ug=rX,u+w" (or "a=,u=rwX,g=rX"), and have it apply equally to the
directory and the files. I can't come up with a single way in the ansible
file module to deterministically, recursively, set a directory to 750
and the contents to 640 no matter what the current permissions are,
as the code currently is.
The fix is to pass in "new_mode" to _get_octal_mode_from_symbolic_perms
in lib/ansible/module_utils/basic.py inside _symbolic_mode_to_octal. And
then take "new_mode" as an argument and use it instead of the filesystem
object stat.st_mode value.
* Fixing my new unit test, fixing bug in test comments
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update `collections.abc` imports
- Use `six.moves` for modules and module_utils
- Use `collections.abc` for controller code
This avoids using `ansible.module_utils.common._collections_compat`,
which was added before the vendored `six` was updated to provide these
imports.
* Update _collections_compat to use six.moves
Also update the custom pylint rule to reflect this change.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
* Fix io_buffer_size option.
* Remove ignore.txt entry by adding action plugin only options to module's argument spec.
* Add changelog fragment.
* Adjust unit tests.
|
| |
|
|
| |
* Remove obsolete units.compat.mock compat layer.
* Update remaining units.compat.mock references.
|
| |
|
|
|
|
|
|
| |
* add DebianStrategy tests
* ensure hostname can be changed by using become
* use Systemd strat for debian and Base for generic.
* add test to ensure all strategies are available
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
|
| |
|
|
|
|
| |
creation and deletion
fixes #25099
closes #32158
|
| |
|
|
|
|
|
| |
- On Python 3, decode bytes to str
- Tolerate whitespace around the line.
- Report a missing HOSTNAME line as an error.
- Don't clobber line separators when setting a new hostname.
- Add some tests for this strategy to verify correct operation.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* pip - Use pip from the current Python interpreter.
If `executable` and `virtualenv` were not specified, and
the `pip` Python module is available for the current interpreter,
use that `pip` module instead of searching for a `pip` command.
* Add comment about needing `__main__` to run `pip`.
* Fix unit test.
* Add porting guide entry.
* Update changelog to match porting guide description.
ci_complete
|
| |
|
|
|
|
|
| |
Rather than adding further complexity to the regex, preprocess the output to
remove any empty lines. Now the only purpose of the regex is to fix
wrapped lines.
Fixes #70949
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* modules moved to use best_parsable_locale
* fixed invocations
* better better
* also module_utils
* converted to function as per fb
* patch testt
* whitespace
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since moving to distro, it is possible to return this information for all platforms, not just Linux.
Also return version information for all platfrom not just Linux.
Update unit tests.
Remove some duplicate unit tests though I think there are more to remove.
* Fix docstring formatting
* Minor docstring changes
* Mock distro.id for Solaris service test
* Update comment
|
| |
|
|
|
|
|
|
|
| |
* apt_key: add --recv argument as last one
* Add unit test
* Add the required boilerplate
Co-authored-by: Marius Gedminas <marius@gedmin.as>
|
| |
|
|
|
|
|
|
|
| |
Test for the required binaries in the can_handle_archive() method and fail there. This
prevents failures for missing binaries unrelated to the archive type.
* Update missing zip binary message to match tar message
* Update unit tests
* Add integration tests
* Define packages based on the system rather than ignoring failures
|
| |
|
|
|
| |
Fixes: #39029
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
| |
|
| |
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
| |
|
|
| |
Apply #74744 and #69929 to #70828
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change:
- Hostname strategies' get_*() methods should never write to the
filesystem. They are used in check_mode by default to determine if
there is any work to be done.
Test Plan:
- New unit tests to ensure that (at least when in check_mode) the get
methods don't ever call write.
Tickets:
- Fixes #66432
Signed-off-by: Rick Elrod <rick@elrod.me>
|
| |
|
|
|
|
| |
be consistent on information returned
normalize 'return functions'
fix unit test
add a bit more context on some failures
|
| |
|
| |
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Reorder comment postition
* Add comment unit test
* Fix unit test
* Fix unit test
* Add changelog
* Add paramaters which would be problematic without this fix
* Fix typo
* Fix unit test
* Fix unit test
|
| |
|
|
|
|
|
|
|
|
| |
* service_facts: return service state information on AIX
AIX uses the System Resource Controller (SRC) to manage services.
See https://www.ibm.com/support/knowledgecenter/ssw_aix_72/osmanagement/sysrescon.htm
Use lssrc command on AIX to return service state information.
Co-authored-by: dberg1 <dberg1@github.com>
|
| |
|
|
|
|
| |
* Updated docs and ignore.txt
* Replaced with correct function calls
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
| |
|
|
|
|
|
| |
* Add unit tests for basic._set_cwd
* incidental coverage for dict_merge
* add test for async stderr inclusion
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Flatten the directory hierarchy of modules
* Update ignore.txt, flatten units
* Update imports
* Completely flatten the modules directory
* Update sanity ignore
* Fix some sanity test ignores
* Fix relative import
* Fix docs builds without category
* ci_complete
* Clean up docs. ci_complete
* Adjust needs/file alias
* ci_complete
* fix hardcoded ping module paths
Co-authored-by: Matt Davis <mrd@redhat.com>
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
