junos_netconf: fix check mode, fixes #57929 (#57930)

2 files changed, 63 insertions, 0 deletions

diff --git a/test/integration/targets/junos_netconf/tests/cli/changeport.yaml b/test/integration/targets/junos_netconf/tests/cli/changeport.yaml
index aee2cae92b..a6c42ed190 100644
--- a/test/integration/targets/junos_netconf/tests/cli/changeport.yaml
+++ b/test/integration/targets/junos_netconf/tests/cli/changeport.yaml
@@ -59,4 +59,29 @@
 - name: Ensure we can communicate over netconf
   include: "{{ role_path }}/tests/utils/junos_command.yaml ansible_connection=netconf ansible_port=830 is_ignore_errors=false"
 
+- name: Change port (check mode)
+  junos_netconf:
+    state: present
+    netconf_port: 12345
+  register: result
+  check_mode: true
+
+- assert:
+    that:
+      - "result.changed == true"
+
+- name: wait for netconf server to come up
+  pause:
+    seconds: 10
+
+- name: Ensure we can NOT communicate over non-default port
+  include: "{{ role_path }}/tests/utils/junos_command.yaml ansible_connection=netconf ansible_port=12345 is_ignore_errors=true"
+
+- assert:
+    that:
+      - "result.failed == true"
+
+- name: Ensure we can communicate over default port
+  include: "{{ role_path }}/tests/utils/junos_command.yaml ansible_connection=netconf ansible_port=830 is_ignore_errors=false"
+
 - debug: msg="END netconf/changeport.yaml on connection={{ ansible_connection }}"
diff --git a/test/integration/targets/junos_netconf/tests/cli/netconf.yaml b/test/integration/targets/junos_netconf/tests/cli/netconf.yaml
index 95db4deeae..9cc69ba356 100644
--- a/test/integration/targets/junos_netconf/tests/cli/netconf.yaml
+++ b/test/integration/targets/junos_netconf/tests/cli/netconf.yaml
@@ -25,6 +25,23 @@
 - name: Ensure we can communicate over netconf
   include: "{{ role_path }}/tests/utils/junos_command.yaml ansible_connection=netconf ansible_port=830 is_ignore_errors=false"
 
+- name: Disable netconf (check mode)
+  junos_netconf:
+    state: absent
+  register: result
+  check_mode: yes
+
+- assert:
+    that:
+      - "result.changed == true"
+
+- name: wait for persistent socket to timeout
+  pause:
+    seconds: 120
+
+- name: Ensure we can communicate over netconf
+  include: "{{ role_path }}/tests/utils/junos_command.yaml ansible_connection=netconf ansible_port=830 is_ignore_errors=false"
+
 # Disable netconf
 - name: Disable netconf
   junos_netconf:
@@ -55,6 +72,27 @@
     that:
       - "result.failed == true"
 
+- name: Enable netconf (check mode)
+  junos_netconf:
+    state: present
+  register: result
+  check_mode: yes
+
+- assert:
+    that:
+      - "result.changed == true"
+
+- name: wait for netconf server to come up
+  pause:
+    seconds: 10
+
+- name: Ensure we can NOT talk via netconf
+  include: "{{ role_path }}/tests/utils/junos_command.yaml ansible_connection=netconf ansible_port=830 is_ignore_errors=true"
+
+- assert:
+    that:
+      - "result.failed == true"
+
 - name: re-enable netconf
   junos_netconf:
     state: present