diff options
author | Matt Martz <matt@sivel.net> | 2019-05-31 15:35:26 -0500 |
---|---|---|
committer | ansibot <ansibot@users.noreply.github.com> | 2019-05-31 16:35:25 -0400 |
commit | 8bd4e2a144f5830a526f8ab18dd1e1df986a779a (patch) | |
tree | 40b47729dd6b7b7c6b02de017a449c16c127be44 /test/integration/targets/get_url | |
parent | c493593b4b8be1c3a33a0831da566292189d2b75 (diff) | |
download | ansible-8bd4e2a144f5830a526f8ab18dd1e1df986a779a.tar.gz |
cert validation fixes - Attempt 2 (#55953)
* Attempt 2 of cert validation fixes
* Remove unused code
* Cleanup the tmp cert using atexit
* Fix linting issues
* Only add SSLValidationHandler when not HAS_SSLCONTEXT
* Catch value errors on non PEM certs
* Only catch NotImplementedError to avoid masking issues
* set self._context even with PyOpenSSLContext for conformity
* Fix error building
* normalize how we interact with the context we create
* Remove unused code
* Address test for py3.7 message difference
* open_url should pass the ca_path through
* Account for new error in url lookup test
* Guard some code behind whether or not we are validating certs
* Make _make_context public
* Move atexit.register up to where the tmp file is created
Diffstat (limited to 'test/integration/targets/get_url')
-rw-r--r-- | test/integration/targets/get_url/tasks/main.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/integration/targets/get_url/tasks/main.yml b/test/integration/targets/get_url/tasks/main.yml index 829d55c63f..587b8c58f1 100644 --- a/test/integration/targets/get_url/tasks/main.yml +++ b/test/integration/targets/get_url/tasks/main.yml @@ -119,7 +119,7 @@ assert: that: - "result is failed" - - "'Failed to validate the SSL certificate' in result.msg or ( result.msg is match('hostname .* doesn.t match .*'))" + - "'Failed to validate the SSL certificate' in result.msg or 'Hostname mismatch' in result.msg or ( result.msg is match('hostname .* doesn.t match .*'))" - "stat_result.stat.exists == false" - name: test https fetch to a site with mismatched hostname and certificate and validate_certs=no |