diff options
| author | Antonio Ospite <ao2@ao2.it> | 2016-12-09 14:02:29 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2016-12-09 17:21:57 +0100 |
| commit | b235b50129b6195e502a5b25841a13d725a4766b (patch) | |
| tree | 699103d90766daae832df83747ec8bf792e03880 | |
| parent | c21b3a4b62767fe0fbc720ad109e35e7cfff4347 (diff) | |
| download | alsa-utils-b235b50129b6195e502a5b25841a13d725a4766b.tar.gz | |
configure.ac: fix the check for xmlto availability
The same $xmlto variable is used both in AC_ARG_ENABLE and
AC_CHECK_PROG, but the latter is not setting a value to it when the
program is not found.
These two facts result in the "yes" value from the AC_ARG_ENABLE macro
to be still kept in the variable when the program is not found by
AC_CHECK_PROG, causing USE_XMLTO to be always set, finally resulting in
a build failure in case the xmlto program is not actually in the PATH.
As possible fix could have been to set "no" as a value in AC_CHECK_PROG
when program is not found.
However using two separate variables is more explicit, so fix the issue
this way.
Signed-off-by: Antonio Ospite <ao2@ao2.it>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | configure.ac | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/configure.ac b/configure.ac index 2221617..c9629bb 100644 --- a/configure.ac +++ b/configure.ac @@ -166,14 +166,14 @@ AC_ARG_ENABLE(alsaloop, esac],[alsaloop=true]) AM_CONDITIONAL(ALSALOOP, test x$alsaloop = xtrue) -xmlto="" +xmlto_available="" AC_ARG_ENABLE(xmlto, AS_HELP_STRING([--disable-xmlto], [Disable man page creation via xmlto]), xmlto="$enableval", xmlto="yes") if test "$xmlto" = "yes"; then - AC_CHECK_PROG([xmlto], [xmlto], [yes]) + AC_CHECK_PROG([xmlto_available], [xmlto], [yes]) fi -AM_CONDITIONAL(USE_XMLTO, test x"$xmlto" = xyes) +AM_CONDITIONAL(USE_XMLTO, test x"$xmlto_available" = xyes) AC_ARG_WITH( [udev-rules-dir], |