Imported from /home/lorry/working-area/delta_VirtualBox/VirtualBox-4.3.10.tar.bz2.HEADVirtualBox-4.3.10master

1 files changed, 7 insertions, 3 deletions

diff --git a/src/VBox/Runtime/common/net/netaddrstr.cpp b/src/VBox/Runtime/common/net/netaddrstr.cpp
index 4cc88a39..ba4df40f 100644
--- a/src/VBox/Runtime/common/net/netaddrstr.cpp
+++ b/src/VBox/Runtime/common/net/netaddrstr.cpp
@@ -1,6 +1,10 @@
 /* $Id: netaddrstr.cpp $ */
 /** @file
  * IPRT - Network Address String Handling.
+ *
+ * @remarks Don't add new functionality to this file, it goes into netaddrstr2.cpp
+ *          or some other suitable file (legal reasons + code not up to oracle
+ *          quality standards and requires rewrite from scratch).
  */
 
 /*
@@ -202,7 +206,8 @@
  * This function should NOT be used directly. If you do, note
  * that no security checks are done at the moment. This can change.
  *
- * @returns iprt sstatus code.
+ * @returns iprt sstatus code, yeah, right... This function most certainly DOES
+ *          NOT RETURN ANY IPRT STATUS CODES.  It's also a unreadable mess.
  * @param pszAddress       The strin that holds the IPv6 address
  * @param addressLength    The length of pszAddress
  * @param pszAddressOut    Returns a plain, full blown IPv6 address
@@ -1147,7 +1152,7 @@ static int rtNetIpv6CheckAddrStr(const char *psz, char *pszResultAddress, size_t
 {
     int rc;
     int rc2;
-    int returnValue;
+    int returnValue = VERR_NOT_SUPPORTED; /* gcc want's this initialized, I understand its confusion. */
 
     char *p = NULL, *pl = NULL;
 
@@ -1283,4 +1288,3 @@ RTDECL(bool) RTNetIsIPv4AddrStr(const char *pszAddress)
     return true;
 }
 RT_EXPORT_SYMBOL(RTNetIsIPv4AddrStr);
-