| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1247
|
| |
|
|
|
|
|
| |
They are flagged by lgtm.com. Avoid the warning by dropping unused
includes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First of all, the "os.setuid()" call is never reached. lgtm.com warns about
that, and warnings are annoying because they require investigation.
This code is only in the example, so that the user would understand that
they should edit the source and set the desired UID. But you can only
call setuid() if you have CAP_SETUID, so commonly this anyway doesn't
work -- unless you are root already, and then you actually don't need
it either.
Let's drop this code from the example.
Maybe this example really should be dropped. Does the "dbus" python
module even still work? Doesn't for me...
|
|
|
|
|
|
|
|
|
|
|
|
| |
input() in Python2 evaluated the string and was thus unsafe. On
Python2, the right choice is raw_input. In Python3, input does
what raw_input did.
Work around this.
The main "problem" is that lgtm.com flags this as error. The fix
in the example is not important, but getting a low number of warnings
is.
|
| |
|
| |
|
|
|
|
| |
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/630
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These SPDX license identifiers are deprecated ([1]). Update them.
[1] https://spdx.org/licenses/
sed \
-e '1 s%^/\* SPDX-License-Identifier: \(GPL-2.0\|LGPL-2.1\)+ \*/$%/* SPDX-License-Identifier: \1-or-later */%' \
-e '1,2 s%^\(--\|#\|//\) SPDX-License-Identifier: \(GPL-2.0\|LGPL-2.1\)+$%\1 SPDX-License-Identifier: \2-or-later%' \
-i \
$(git grep -l SPDX-License-Identifier -- \
':(exclude)shared/c-*/' \
':(exclude)shared/n-*/' \
':(exclude)shared/systemd/src' \
':(exclude)src/systemd/src')
|
|
|
|
| |
Signed-off-by: Frederic Martinsons <frederic.martinsons@sigfox.com>
|
|
|
|
|
|
|
| |
There were python 2 methods that are not used anymore so now
it's in python 3. Added helper fuctions so that the code is more clear
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/540
|
|
|
|
|
|
| |
Part of !537.
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/537
|
|
|
|
|
| |
lgtm.com says "The value assigned to local variable all_connections is never used".
Just drop the entire statement. It's not right there.
|
|
|
|
| |
lgmt.com says "Testing for None should use the is operator".
|
| |
|
|
|
|
| |
https://github.com/NetworkManager/NetworkManager/pull/361
|
|
|
|
|
| |
$ find * -type f |xargs perl contrib/scripts/spdx.pl
$ git rm contrib/scripts/spdx.pl
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We no longer add these. If you use Emacs, configure it yourself.
Also, due to our "smart-tab" usage the editor anyway does a subpar
job handling our tabs. However, on the upside every user can choose
whatever tab-width he/she prefers. If "smart-tabs" are used properly
(like we do), every tab-width will work.
No manual changes, just ran commands:
F=($(git grep -l -e '-\*-'))
sed '1 { /\/\* *-\*- *[mM]ode.*\*\/$/d }' -i "${F[@]}"
sed '1,4 { /^\(#\|--\|dnl\) *-\*- [mM]ode/d }' -i "${F[@]}"
Check remaining lines with:
git grep -e '-\*-'
The ultimate purpose of this is to cleanup our files and eventually use
SPDX license identifiers. For that, first get rid of the boilerplate lines.
|
|
|
|
|
|
|
|
| |
Correct the spelling across the *entire* tree, including translations,
comments, etc. It's easier that way.
Even the places where it's not exposed to the user, such as tests, so
that we learn how is it spelled correctly.
|
|
|
|
|
|
| |
Found via `codespell -q 3 --skip="*.po"`
https://github.com/NetworkManager/NetworkManager/pull/203
|
| |
|
|
|
|
|
|
| |
We commonly only allow tabs at the beginning of a line, not
afterwards. The reason for this style is so that the code
looks formated right with tabstop=4 and tabstop=8.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=791121
|
| |
|
|
|
|
|
| |
Add a timeout parameter and allow passing multiple interfaces to make
the script more useful for testing purposes.
|
| |
|
|
|
|
|
|
| |
May use a lot of improvement (actually documenting the names and
objects that use the interfaces in question), but at least this looks a
lot better on developer.gnome.org.
|
| |
|
|
|
|
| |
Based-on-patch-by: Jiří Klimeš <jklimes@redhat.com>
|
|
|
|
| |
Based-on-patch-by: Jiří Klimeš <jklimes@redhat.com>
|
|
|
|
| |
so that it can be run multiple times.
|
|
|
|
| |
and rename add-system-wifi-connection.py to add-wifi-eap-connection.py
|
| |
|
| |
|
|
|
|
| |
Fixes: 1af8e2f132f64a9f3c012a57f4b67422ccf62ad5
|
| |
|
|
|
|
|
|
|
| |
Current Python NM example has a very crude connection state output
and the global NM connectivity is not used in them either.
https://bugzilla.gnome.org/show_bug.cgi?id=746045
|
|
|
|
|
|
| |
https://mail.gnome.org/archives/networkmanager-list/2015-March/msg00024.html
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Update the raw D-Bus python examples to use newer APIs where
appropriate (and split the add-connection example into 1.0-only and
0.9-compatible versions). Update the gi-based python examples for the
various API changes since they were last updated.
Also add a comment to the ruby add-connection example pointing out
that it's still using the old settings APIs.
|
|
|
|
|
|
| |
'has_key' on Dictionaries is removed from Python3 in favor of 'in'.
Signed-off-by: Thomas Haller <thaller@redhat.com>
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Various GNOME services moved around so links need updating.
|
| |
|
|
Move examples using dbus-python ('dbus' module) and GObject introspection into
their own directories.
|