diff options
author | Thomas Haller <thaller@redhat.com> | 2018-09-20 10:15:48 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2018-09-27 17:36:42 +0200 |
commit | 7729555a595871049caab7b5ea811ea04c4d3f8d (patch) | |
tree | 7e22e2b75115038af851fec0bdbf67e373b610e3 /src/nm-types.h | |
parent | 6b5790a05e28d7d896968e43645e86ade2e967f6 (diff) | |
download | NetworkManager-7729555a595871049caab7b5ea811ea04c4d3f8d.tar.gz |
acd: make NMAcdManager no GObject
NMAcdManager is a rather simple instance.
It does not need (thread-safe) ref-counting, in fact, having
it ref-counted makes it slighly ugly that we connect a signal,
but never bother to disconnect it (while the ref-counted instance
could outlife the signal subscriber).
We also don't need GObject signals. They have more overhead
and are less type-safe than a regular function pointers. Signals
would make sense, if there could be multiple independent listeners,
but that just doesn't make sense.
Implementing it as a plain struct is less lines of code, and less
runtime over head.
Also drop the possiblitiy to reset the NMAcdManager instance.
It wasn't needed and I think it was buggy because it wouldn't
reset the n-acd instance.
https://github.com/NetworkManager/NetworkManager/pull/213
Diffstat (limited to 'src/nm-types.h')
-rw-r--r-- | src/nm-types.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/nm-types.h b/src/nm-types.h index a0a7f6202e..676ca64169 100644 --- a/src/nm-types.h +++ b/src/nm-types.h @@ -37,7 +37,6 @@ typedef struct _NMAuthSubject NMAuthSubject; typedef struct _NMDBusManager NMDBusManager; typedef struct _NMConfig NMConfig; typedef struct _NMConfigData NMConfigData; -typedef struct _NMAcdManager NMAcdManager; typedef struct _NMConnectivity NMConnectivity; typedef struct _NMDevice NMDevice; typedef struct _NMDhcp4Config NMDhcp4Config; |