diff options
| author | Thomas Haller <thaller@redhat.com> | 2018-04-09 12:36:06 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2018-04-13 09:09:46 +0200 |
| commit | 290d02536c237cd14f187611e72e5fc0b52c81a7 (patch) | |
| tree | fe8555c8e4e2275686e25ff2df87babb5b8e5a9d /src/nm-auth-manager.c | |
| parent | 50b74731f668067d445a28d7e545a169bf9d25c8 (diff) | |
| download | NetworkManager-290d02536c237cd14f187611e72e5fc0b52c81a7.tar.gz | |
auth-chain: avoid another idle-call when auth-request completes
NMAuthChain schedules (possibly) multiple authentication requests.
When they all complete, it will once invoke the result-callback.
There is no need to schedule this result-callback on another idle-handler,
because nm_auth_manager_polkit_authority_check_authorization() should guarantee
to invoke the callback never-synchronously and on a clean call-stack (to avoid
problems with re-entrancy). At that point, NMAuthChain does not need to
delay this further.
Diffstat (limited to 'src/nm-auth-manager.c')
| -rw-r--r-- | src/nm-auth-manager.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/nm-auth-manager.c b/src/nm-auth-manager.c index 003d997505..d1b8d91e1d 100644 --- a/src/nm-auth-manager.c +++ b/src/nm-auth-manager.c @@ -240,6 +240,9 @@ _call_check_authorization (CheckAuthData *data) data->dbus_parameters = NULL; } +/* + * @callback must never be invoked synchronously. + */ void nm_auth_manager_polkit_authority_check_authorization (NMAuthManager *self, NMAuthSubject *subject, |