diff options
| author | Thomas Haller <thaller@redhat.com> | 2019-08-02 09:24:01 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2019-08-02 11:10:51 +0200 |
| commit | 2ecc7e8cb5b4169378a68e085db2527c4ef82cdf (patch) | |
| tree | 7d1c6b56da3dde42e3e953a8aa867dadafef0d8d /src/initrd | |
| parent | c347e81a1d5b78d14e3dc60f266470f89c7437b4 (diff) | |
| download | NetworkManager-2ecc7e8cb5b4169378a68e085db2527c4ef82cdf.tar.gz | |
initrd: avoid coverity warning in parse_ip() about "Dereference before null check"
get_word() only moves the "argument" pointer forward. It never sets it
to %NULL. Also, above we already dereference argument, so Coverity thinks
that this NULL check indicates a bug.
Drop it to silence Coverity.
(cherry picked from commit 4596d7793cee22228e68d102fa199ed1736a2050)
Diffstat (limited to 'src/initrd')
| -rw-r--r-- | src/initrd/nmi-cmdline-reader.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/initrd/nmi-cmdline-reader.c b/src/initrd/nmi-cmdline-reader.c index ccdd1f2992..7a3af8d661 100644 --- a/src/initrd/nmi-cmdline-reader.c +++ b/src/initrd/nmi-cmdline-reader.c @@ -244,7 +244,7 @@ parse_ip (GHashTable *connections, const char *sysfs_dir, char *argument) dns[0] = tmp; dns[1] = get_word (&argument, ':'); dns_addr_family[1] = guess_ip_address_family (dns[1]); - if (argument && *argument) + if (*argument) _LOGW (LOGD_CORE, "Ignoring extra: '%s'.", argument); } else { mtu = tmp; |