diff options
| author | Beniamino Galvani <bgalvani@redhat.com> | 2017-09-14 09:26:51 +0200 |
|---|---|---|
| committer | Beniamino Galvani <bgalvani@redhat.com> | 2017-09-20 08:01:02 +0200 |
| commit | 41b0e8c5a5e7cc7cf4a1c0fcc3210f56bbfb7af4 (patch) | |
| tree | 4fb596754ad63a438c7b98d98036f9a93e413a81 /src/devices/nm-device-macsec.c | |
| parent | 74845f80ec8213a431a3112afe23b05661cddb79 (diff) | |
| download | NetworkManager-41b0e8c5a5e7cc7cf4a1c0fcc3210f56bbfb7af4.tar.gz | |
manager: downgrade error message for missing dependencies
At startup the manager tries to create virtual devices without a
specific order and spits warnings when a device can't be realized
because the parent device is not yet created. These failures are not
something the user should worry about because the creation will be
retried when the parent appears.
A better approach is to return an error code from the device's
create_and_realize() telling that it failed because the parent doesn't
exist. In this way, the manager knows that the device isn't ready and
can avoid printing warning messages.
Diffstat (limited to 'src/devices/nm-device-macsec.c')
| -rw-r--r-- | src/devices/nm-device-macsec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/devices/nm-device-macsec.c b/src/devices/nm-device-macsec.c index 3a43dd5c69..a117b8e216 100644 --- a/src/devices/nm-device-macsec.c +++ b/src/devices/nm-device-macsec.c @@ -692,7 +692,7 @@ create_and_realize (NMDevice *device, g_assert (s_macsec); if (!parent) { - g_set_error (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED, + g_set_error (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_MISSING_DEPENDENCIES, "MACsec devices can not be created without a parent interface"); return FALSE; } |