summaryrefslogtreecommitdiff
path: root/src/core
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2022-08-26 19:28:09 +0200
committerThomas Haller <thaller@redhat.com>2022-08-26 19:28:11 +0200
commit7a0c2f8be9f885fca6c84c43364fd1512c896280 (patch)
treed55603d79325c5a0ca83ab479fe2d2d2574fe0da /src/core
parent5d4802f7d869e2a91192dc75bf33cff892a3facf (diff)
parent1ece234b2437faef419981ada05b82ab6ac59532 (diff)
downloadNetworkManager-1.41.1-dev.tar.gz
release: bump version to 1.41.1 (development)1.41.1-dev
Diffstat (limited to 'src/core')
-rw-r--r--src/core/NetworkManagerUtils.c60
-rw-r--r--src/core/devices/nm-device-bond.c6
-rw-r--r--src/core/devices/nm-device-ip-tunnel.c10
-rw-r--r--src/core/devices/nm-device-utils.c42
-rw-r--r--src/core/devices/nm-device-vxlan.c28
-rw-r--r--src/core/devices/nm-device-wireguard.c17
-rw-r--r--src/core/devices/nm-device.c12
-rw-r--r--src/core/devices/nm-lldp-listener.c2
-rw-r--r--src/core/devices/wifi/nm-device-iwd.c69
-rw-r--r--src/core/devices/wifi/nm-device-wifi-p2p.c1
-rw-r--r--src/core/devices/wifi/nm-iwd-manager.c82
-rw-r--r--src/core/devices/wifi/nm-iwd-manager.h2
-rw-r--r--src/core/devices/wifi/nm-wifi-utils.c6
-rw-r--r--src/core/devices/wwan/nm-modem-broadband.c7
-rw-r--r--src/core/devices/wwan/nm-modem-ofono.c13
-rw-r--r--src/core/dhcp/nm-dhcp-client.c28
-rw-r--r--src/core/dhcp/nm-dhcp-nettools.c56
-rw-r--r--src/core/dhcp/nm-dhcp-options.c4
-rw-r--r--src/core/dhcp/nm-dhcp-systemd.c8
-rw-r--r--src/core/dhcp/nm-dhcp-utils.c24
-rw-r--r--src/core/dns/nm-dns-dnsmasq.c21
-rw-r--r--src/core/dns/nm-dns-dnsmasq.h2
-rw-r--r--src/core/dns/nm-dns-manager.c24
-rw-r--r--src/core/dns/nm-dns-systemd-resolved.c4
-rw-r--r--src/core/dnsmasq/nm-dnsmasq-manager.c4
-rw-r--r--src/core/dnsmasq/nm-dnsmasq-utils.c6
-rw-r--r--src/core/ndisc/nm-lndp-ndisc.c8
-rw-r--r--src/core/ndisc/nm-ndisc.c18
-rw-r--r--src/core/nm-config-data.c6
-rw-r--r--src/core/nm-connectivity.c8
-rw-r--r--src/core/nm-core-utils.c2
-rw-r--r--src/core/nm-core-utils.h2
-rw-r--r--src/core/nm-firewall-utils.c4
-rw-r--r--src/core/nm-ip-config.c10
-rw-r--r--src/core/nm-l3-config-data.c46
-rw-r--r--src/core/nm-l3-ipv4ll.c46
-rw-r--r--src/core/nm-l3-ipv6ll.c13
-rw-r--r--src/core/nm-l3cfg.c40
-rw-r--r--src/core/nm-netns.c16
-rw-r--r--src/core/nm-pacrunner-manager.c6
-rw-r--r--src/core/nm-policy.c14
-rw-r--r--src/core/platform/nm-fake-platform.c14
-rw-r--r--src/core/platform/tests/test-common.c95
-rw-r--r--src/core/platform/tests/test-link.c2
-rw-r--r--src/core/platform/tests/test-route.c8
-rw-r--r--src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c44
-rw-r--r--src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c8
-rw-r--r--src/core/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c2
-rw-r--r--src/core/settings/plugins/ifupdown/nms-ifupdown-parser.c6
-rw-r--r--src/core/supplicant/nm-supplicant-interface.c2
-rw-r--r--src/core/tests/test-core.c27
-rw-r--r--src/core/tests/test-l3cfg.c27
-rw-r--r--src/core/vpn/nm-vpn-connection.c11
53 files changed, 561 insertions, 462 deletions
diff --git a/src/core/NetworkManagerUtils.c b/src/core/NetworkManagerUtils.c
index 8b0b484583..32c1fd17b6 100644
--- a/src/core/NetworkManagerUtils.c
+++ b/src/core/NetworkManagerUtils.c
@@ -419,8 +419,8 @@ route_compare(NMIPRoute *route1, NMIPRoute *route2, gint64 default_metric)
nm_assert_not_reached();
if (!inet_pton(family, nm_ip_route_get_dest(route2), &a2))
nm_assert_not_reached();
- nm_utils_ipx_address_clear_host_address(family, &a1, NULL, plen);
- nm_utils_ipx_address_clear_host_address(family, &a2, NULL, plen);
+ nm_ip_addr_clear_host_address(family, &a1, NULL, plen);
+ nm_ip_addr_clear_host_address(family, &a2, NULL, plen);
NM_CMP_DIRECT_MEMCMP(&a1, &a2, nm_utils_addr_family_to_size(family));
return 0;
@@ -1417,11 +1417,11 @@ nm_utils_ip_route_attribute_to_platform(int addr_family,
&& g_variant_is_of_type(variant, G_VARIANT_TYPE_STRING)) {
int prefix;
- if (nm_utils_parse_inaddr_prefix_bin(addr_family,
- g_variant_get_string(variant, NULL),
- NULL,
- &addr,
- &prefix)) {
+ if (nm_inet_parse_with_prefix_bin(addr_family,
+ g_variant_get_string(variant, NULL),
+ NULL,
+ &addr,
+ &prefix)) {
if (prefix < 0)
prefix = 128;
r6->src = addr.addr6;
@@ -1443,7 +1443,7 @@ nm_utils_ip_addresses_to_dbus(int addr_family,
const int IS_IPv4 = NM_IS_IPv4(addr_family);
GVariantBuilder builder_data;
GVariantBuilder builder_legacy;
- char addr_str[NM_UTILS_INET_ADDRSTRLEN];
+ char addr_str[NM_INET_ADDRSTRLEN];
NMDedupMultiIter iter;
const NMPObject *obj;
guint i;
@@ -1478,8 +1478,7 @@ nm_utils_ip_addresses_to_dbus(int addr_family,
&addr_builder,
"{sv}",
"address",
- g_variant_new_string(
- nm_utils_inet_ntop(addr_family, address->ax.address_ptr, addr_str)));
+ g_variant_new_string(nm_inet_ntop(addr_family, address->ax.address_ptr, addr_str)));
g_variant_builder_add(&addr_builder,
"{sv}",
@@ -1496,11 +1495,10 @@ nm_utils_ip_addresses_to_dbus(int addr_family,
p = &address->a6.peer_address;
}
if (p) {
- g_variant_builder_add(
- &addr_builder,
- "{sv}",
- "peer",
- g_variant_new_string(nm_utils_inet_ntop(addr_family, p, addr_str)));
+ g_variant_builder_add(&addr_builder,
+ "{sv}",
+ "peer",
+ g_variant_new_string(nm_inet_ntop(addr_family, p, addr_str)));
}
if (IS_IPv4) {
@@ -1558,7 +1556,7 @@ nm_utils_ip_routes_to_dbus(int addr_family,
const NMPObject *obj;
GVariantBuilder builder_data;
GVariantBuilder builder_legacy;
- char addr_str[NM_UTILS_INET_ADDRSTRLEN];
+ char addr_str[NM_INET_ADDRSTRLEN];
nm_assert_addr_family(addr_family);
@@ -1579,14 +1577,12 @@ nm_utils_ip_routes_to_dbus(int addr_family,
nm_assert(r);
nm_assert(r->rx.plen <= 8u * nm_utils_addr_family_to_size(addr_family));
nm_assert(!IS_IPv4
- || r->r4.network
- == nm_utils_ip4_address_clear_host_address(r->r4.network, r->r4.plen));
- nm_assert(
- IS_IPv4
- || (memcmp(&r->r6.network,
- nm_utils_ip6_address_clear_host_address(&n, &r->r6.network, r->r6.plen),
- sizeof(n))
- == 0));
+ || r->r4.network == nm_ip4_addr_clear_host_address(r->r4.network, r->r4.plen));
+ nm_assert(IS_IPv4
+ || (memcmp(&r->r6.network,
+ nm_ip6_addr_clear_host_address(&n, &r->r6.network, r->r6.plen),
+ sizeof(n))
+ == 0));
if (r->rx.type_coerced != nm_platform_route_type_coerce(RTN_UNICAST))
continue;
@@ -1601,7 +1597,7 @@ nm_utils_ip_routes_to_dbus(int addr_family,
&route_builder,
"{sv}",
"dest",
- g_variant_new_string(nm_utils_inet_ntop(addr_family, r->rx.network_ptr, addr_str)));
+ g_variant_new_string(nm_inet_ntop(addr_family, r->rx.network_ptr, addr_str)));
g_variant_builder_add(&route_builder,
"{sv}",
@@ -1614,7 +1610,7 @@ nm_utils_ip_routes_to_dbus(int addr_family,
&route_builder,
"{sv}",
"next-hop",
- g_variant_new_string(nm_utils_inet_ntop(addr_family, gateway, addr_str)));
+ g_variant_new_string(nm_inet_ntop(addr_family, gateway, addr_str)));
}
g_variant_builder_add(&route_builder,
@@ -1679,7 +1675,7 @@ nm_utils_platform_capture_ip_setting(NMPlatform *platform,
NMDedupMultiIter iter;
const NMPObject *obj;
const char *method = NULL;
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
const NMPlatformIPXRoute *best_default_route = NULL;
s_ip =
@@ -1781,13 +1777,13 @@ nm_utils_platform_capture_ip_setting(NMPlatform *platform,
}
if (best_default_route && nm_setting_ip_config_get_num_addresses(s_ip) > 0) {
- g_object_set(s_ip,
- NM_SETTING_IP_CONFIG_GATEWAY,
- nm_utils_inet_ntop(
- addr_family,
+ g_object_set(
+ s_ip,
+ NM_SETTING_IP_CONFIG_GATEWAY,
+ nm_inet_ntop(addr_family,
nm_platform_ip_route_get_gateway(addr_family, &best_default_route->rx),
sbuf),
- NULL);
+ NULL);
}
return NM_SETTING(g_steal_pointer(&s_ip));
diff --git a/src/core/devices/nm-device-bond.c b/src/core/devices/nm-device-bond.c
index 44bb316dc4..558f8f7598 100644
--- a/src/core/devices/nm-device-bond.c
+++ b/src/core/devices/nm-device-bond.c
@@ -274,10 +274,10 @@ set_arp_targets(NMDevice *device, const char *cur_arp_ip_target, const char *new
in_addr_t a4;
s = new_strv[i];
- if (nm_utils_parse_inaddr_bin(AF_INET, s, NULL, &a4)) {
+ if (nm_inet_parse_bin(AF_INET, s, NULL, &a4)) {
char sbuf[INET_ADDRSTRLEN];
- _nm_utils_inet4_ntop(a4, sbuf);
+ nm_inet4_ntop(a4, sbuf);
if (!nm_streq(s, sbuf)) {
if (!free_list)
free_list = g_ptr_array_new_with_free_func(g_free);
@@ -368,7 +368,7 @@ _bond_arp_ip_target_to_platform(const char *value, in_addr_t out[static NM_BOND_
for (i = 0; ip[i]; i++) {
if (added > NM_BOND_MAX_ARP_TARGETS - 1)
break;
- if (!nm_utils_parse_inaddr_bin(AF_INET, ip[i], NULL, &in_a))
+ if (!nm_inet_parse_bin(AF_INET, ip[i], NULL, &in_a))
nm_assert_not_reached(); /* verify() already validated the IP addresses */
out[added++] = in_a;
diff --git a/src/core/devices/nm-device-ip-tunnel.c b/src/core/devices/nm-device-ip-tunnel.c
index 02680dd7a5..7c411982d8 100644
--- a/src/core/devices/nm-device-ip-tunnel.c
+++ b/src/core/devices/nm-device-ip-tunnel.c
@@ -107,12 +107,12 @@ address_equal_pp(int addr_family, const char *a, const char *b)
nm_assert_addr_family(addr_family);
if (a) {
- if (!nm_utils_parse_inaddr_bin(addr_family, a, NULL, &addr_a_val))
+ if (!nm_inet_parse_bin(addr_family, a, NULL, &addr_a_val))
nm_assert_not_reached();
addr_a = &addr_a_val;
}
if (b) {
- if (!nm_utils_parse_inaddr_bin(addr_family, b, NULL, &addr_b_val))
+ if (!nm_inet_parse_bin(addr_family, b, NULL, &addr_b_val))
nm_assert_not_reached();
addr_b = &addr_b_val;
}
@@ -125,7 +125,7 @@ address_set(int addr_family, char **p_addr, const NMIPAddr *addr_new)
{
nm_assert_addr_family(addr_family);
nm_assert(p_addr);
- nm_assert(!*p_addr || nm_utils_ipaddr_is_normalized(addr_family, *p_addr));
+ nm_assert(!*p_addr || nm_inet_is_normalized(addr_family, *p_addr));
if (!addr_new || nm_ip_addr_is_null(addr_family, addr_new)) {
if (nm_clear_g_free(p_addr))
@@ -136,7 +136,7 @@ address_set(int addr_family, char **p_addr, const NMIPAddr *addr_new)
if (*p_addr) {
NMIPAddr addr_val;
- if (!nm_utils_parse_inaddr_bin(addr_family, *p_addr, NULL, &addr_val))
+ if (!nm_inet_parse_bin(addr_family, *p_addr, NULL, &addr_val))
nm_assert_not_reached();
if (nm_ip_addr_equal(addr_family, &addr_val, addr_new))
@@ -145,7 +145,7 @@ address_set(int addr_family, char **p_addr, const NMIPAddr *addr_new)
g_free(*p_addr);
}
- *p_addr = nm_utils_inet_ntop_dup(addr_family, addr_new);
+ *p_addr = nm_inet_ntop_dup(addr_family, addr_new);
return TRUE;
}
diff --git a/src/core/devices/nm-device-utils.c b/src/core/devices/nm-device-utils.c
index 170922eba0..2bf24ae6da 100644
--- a/src/core/devices/nm-device-utils.c
+++ b/src/core/devices/nm-device-utils.c
@@ -171,25 +171,25 @@ typedef struct {
#define _NMLOG_PREFIX_NAME "resolve-addr"
#define _NMLOG_DOMAIN LOGD_CORE
-#define _NMLOG2(level, info, ...) \
- G_STMT_START \
- { \
- if (nm_logging_enabled((level), (_NMLOG_DOMAIN))) { \
- ResolveAddrInfo *_info = (info); \
- char _addr_str[NM_UTILS_INET_ADDRSTRLEN]; \
- \
- _nm_log((level), \
- (_NMLOG_DOMAIN), \
- 0, \
- NULL, \
- NULL, \
- _NMLOG_PREFIX_NAME "[" NM_HASH_OBFUSCATE_PTR_FMT \
- ",%s]: " _NM_UTILS_MACRO_FIRST(__VA_ARGS__), \
- NM_HASH_OBFUSCATE_PTR(_info), \
- nm_utils_inet_ntop(_info->addr_family, &_info->address, _addr_str) \
- _NM_UTILS_MACRO_REST(__VA_ARGS__)); \
- } \
- } \
+#define _NMLOG2(level, info, ...) \
+ G_STMT_START \
+ { \
+ if (nm_logging_enabled((level), (_NMLOG_DOMAIN))) { \
+ ResolveAddrInfo *_info = (info); \
+ char _addr_str[NM_INET_ADDRSTRLEN]; \
+ \
+ _nm_log((level), \
+ (_NMLOG_DOMAIN), \
+ 0, \
+ NULL, \
+ NULL, \
+ _NMLOG_PREFIX_NAME "[" NM_HASH_OBFUSCATE_PTR_FMT \
+ ",%s]: " _NM_UTILS_MACRO_FIRST(__VA_ARGS__), \
+ NM_HASH_OBFUSCATE_PTR(_info), \
+ nm_inet_ntop(_info->addr_family, &_info->address, _addr_str) \
+ _NM_UTILS_MACRO_REST(__VA_ARGS__)); \
+ } \
+ } \
G_STMT_END
static void
@@ -234,9 +234,9 @@ resolve_addr_helper_cb(GObject *source, GAsyncResult *result, gpointer user_data
static void
resolve_addr_spawn_helper(ResolveAddrInfo *info)
{
- char addr_str[NM_UTILS_INET_ADDRSTRLEN];
+ char addr_str[NM_INET_ADDRSTRLEN];
- nm_utils_inet_ntop(info->addr_family, &info->address, addr_str);
+ nm_inet_ntop(info->addr_family, &info->address, addr_str);
_LOG2D(info, "start lookup via nm-daemon-helper");
nm_utils_spawn_helper(NM_MAKE_STRV("resolve-address", addr_str),
g_task_get_cancellable(info->task),
diff --git a/src/core/devices/nm-device-vxlan.c b/src/core/devices/nm-device-vxlan.c
index bf7c94c006..d2618a2970 100644
--- a/src/core/devices/nm-device-vxlan.c
+++ b/src/core/devices/nm-device-vxlan.c
@@ -174,15 +174,15 @@ create_and_realize(NMDevice *device,
str = nm_setting_vxlan_get_local(s_vxlan);
if (str) {
- if (!nm_utils_parse_inaddr_bin(AF_INET, str, NULL, &props.local)
- && !nm_utils_parse_inaddr_bin(AF_INET6, str, NULL, &props.local6))
+ if (!nm_inet_parse_bin(AF_INET, str, NULL, &props.local)
+ && !nm_inet_parse_bin(AF_INET6, str, NULL, &props.local6))
return FALSE;
}
str = nm_setting_vxlan_get_remote(s_vxlan);
if (str) {
- if (!nm_utils_parse_inaddr_bin(AF_INET, str, NULL, &props.group)
- && !nm_utils_parse_inaddr_bin(AF_INET6, str, NULL, &props.group6))
+ if (!nm_inet_parse_bin(AF_INET, str, NULL, &props.group)
+ && !nm_inet_parse_bin(AF_INET6, str, NULL, &props.group6))
return FALSE;
}
@@ -223,7 +223,7 @@ address_matches(const char *candidate, in_addr_t addr4, struct in6_addr *addr6)
if (!candidate)
return addr4 == 0u && IN6_IS_ADDR_UNSPECIFIED(addr6);
- if (!nm_utils_parse_inaddr_bin(AF_UNSPEC, candidate, &addr_family, &candidate_addr))
+ if (!nm_inet_parse_bin(AF_UNSPEC, candidate, &addr_family, &candidate_addr))
return FALSE;
if (!nm_ip_addr_equal(addr_family,
@@ -401,7 +401,7 @@ update_connection(NMDevice *device, NMConnection *connection)
{
NMDeviceVxlanPrivate *priv = NM_DEVICE_VXLAN_GET_PRIVATE(device);
NMSettingVxlan *s_vxlan = _nm_connection_ensure_setting(connection, NM_TYPE_SETTING_VXLAN);
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
if (priv->props.id != nm_setting_vxlan_get_id(s_vxlan))
g_object_set(G_OBJECT(s_vxlan), NM_SETTING_VXLAN_ID, priv->props.id, NULL);
@@ -417,12 +417,12 @@ update_connection(NMDevice *device, NMConnection *connection)
if (priv->props.group) {
g_object_set(s_vxlan,
NM_SETTING_VXLAN_REMOTE,
- _nm_utils_inet4_ntop(priv->props.group, sbuf),
+ nm_inet4_ntop(priv->props.group, sbuf),
NULL);
} else {
g_object_set(s_vxlan,
NM_SETTING_VXLAN_REMOTE,
- _nm_utils_inet6_ntop(&priv->props.group6, sbuf),
+ nm_inet6_ntop(&priv->props.group6, sbuf),
NULL);
}
}
@@ -433,12 +433,12 @@ update_connection(NMDevice *device, NMConnection *connection)
if (priv->props.local) {
g_object_set(s_vxlan,
NM_SETTING_VXLAN_LOCAL,
- _nm_utils_inet4_ntop(priv->props.local, sbuf),
+ nm_inet4_ntop(priv->props.local, sbuf),
NULL);
} else if (memcmp(&priv->props.local6, &in6addr_any, sizeof(in6addr_any))) {
g_object_set(s_vxlan,
NM_SETTING_VXLAN_LOCAL,
- _nm_utils_inet6_ntop(&priv->props.local6, sbuf),
+ nm_inet6_ntop(&priv->props.local6, sbuf),
NULL);
}
}
@@ -510,15 +510,15 @@ get_property(GObject *object, guint prop_id, GValue *value, GParamSpec *pspec)
break;
case PROP_GROUP:
if (priv->props.group)
- g_value_take_string(value, nm_utils_inet4_ntop_dup(priv->props.group));
+ g_value_take_string(value, nm_inet4_ntop_dup(priv->props.group));
else if (!IN6_IS_ADDR_UNSPECIFIED(&priv->props.group6))
- g_value_take_string(value, nm_utils_inet6_ntop_dup(&priv->props.group6));
+ g_value_take_string(value, nm_inet6_ntop_dup(&priv->props.group6));
break;
case PROP_LOCAL:
if (priv->props.local)
- g_value_take_string(value, nm_utils_inet4_ntop_dup(priv->props.local));
+ g_value_take_string(value, nm_inet4_ntop_dup(priv->props.local));
else if (!IN6_IS_ADDR_UNSPECIFIED(&priv->props.local6))
- g_value_take_string(value, nm_utils_inet6_ntop_dup(&priv->props.local6));
+ g_value_take_string(value, nm_inet6_ntop_dup(&priv->props.local6));
break;
case PROP_TOS:
g_value_set_uchar(value, priv->props.tos);
diff --git a/src/core/devices/nm-device-wireguard.c b/src/core/devices/nm-device-wireguard.c
index 179c2a22a5..62be29f106 100644
--- a/src/core/devices/nm-device-wireguard.c
+++ b/src/core/devices/nm-device-wireguard.c
@@ -219,7 +219,7 @@ _auto_default_route_get_enabled(NMSettingWireGuard *s_wg,
aip = nm_wireguard_peer_get_allowed_ip(peer, j, &valid);
if (!valid)
continue;
- if (!nm_utils_parse_inaddr_prefix_bin(AF_UNSPEC, aip, &addr_family, NULL, &prefix))
+ if (!nm_inet_parse_with_prefix_bin(AF_UNSPEC, aip, &addr_family, NULL, &prefix))
continue;
if (prefix != 0)
continue;
@@ -1152,11 +1152,11 @@ _peers_get_platform_list(NMDeviceWireGuardPrivate *priv,
aip = nm_wireguard_peer_get_allowed_ip(peer_data->peer, i_aip, &valid);
if (!valid
- || !nm_utils_parse_inaddr_prefix_bin(AF_UNSPEC,
- aip,
- &addr_family,
- &addrbin,
- &prefix)) {
+ || !nm_inet_parse_with_prefix_bin(AF_UNSPEC,
+ aip,
+ &addr_family,
+ &addrbin,
+ &prefix)) {
/* the address is really not expected to be invalid, because then
* the connection would not verify. Anyway, silently skip it. */
continue;
@@ -1701,8 +1701,7 @@ _get_dev2_ip_config(NMDeviceWireGuard *self, int addr_family)
aip = nm_wireguard_peer_get_allowed_ip(peer, j, &valid);
- if (!valid
- || !nm_utils_parse_inaddr_prefix_bin(addr_family, aip, NULL, &addrbin, &prefix))
+ if (!valid || !nm_inet_parse_with_prefix_bin(addr_family, aip, NULL, &addrbin, &prefix))
continue;
if (prefix < 0)
@@ -1722,7 +1721,7 @@ _get_dev2_ip_config(NMDeviceWireGuard *self, int addr_family)
NM_L3_CONFIG_DAT_FLAGS_IGNORE_MERGE_NO_DEFAULT_ROUTES);
}
- nm_utils_ipx_address_clear_host_address(addr_family, &addrbin, NULL, prefix);
+ nm_ip_addr_clear_host_address(addr_family, &addrbin, NULL, prefix);
rtable_coerced = route_table_coerced;
diff --git a/src/core/devices/nm-device.c b/src/core/devices/nm-device.c
index d63b902b16..1df99a82ee 100644
--- a/src/core/devices/nm-device.c
+++ b/src/core/devices/nm-device.c
@@ -8575,7 +8575,7 @@ nm_device_generate_connection(NMDevice *self,
pllink = nm_platform_link_get(nm_device_get_platform(self), priv->ifindex);
if (pllink && pllink->inet6_token.id) {
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
g_object_set(s_ip6,
NM_SETTING_IP6_CONFIG_ADDR_GEN_MODE,
@@ -10833,7 +10833,7 @@ _dev_ipll6_set_llstate(NMDevice *self, NML3IPv6LLState llstate, const struct in6
}
if (changed) {
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
_LOGT_ipll(AF_INET6,
"set state %s (was %s, llstate=%s, lladdr=%s)",
@@ -10842,7 +10842,7 @@ _dev_ipll6_set_llstate(NMDevice *self, NML3IPv6LLState llstate, const struct in6
nm_l3_ipv6ll_state_to_string(priv->ipll_data_6.v6.llstate),
nm_ip_addr_is_null(AF_INET6, &priv->ipll_data_6.v6.lladdr)
? "(none)"
- : _nm_utils_inet6_ntop(&priv->ipll_data_6.v6.lladdr, sbuf));
+ : nm_inet6_ntop(&priv->ipll_data_6.v6.lladdr, sbuf));
}
if (changed)
@@ -13861,7 +13861,7 @@ nm_device_start_ip_check(NMDevice *self)
NMSettingConnection *s_con;
guint timeout = 0;
const char *ping_binary = NULL;
- char buf[NM_UTILS_INET_ADDRSTRLEN];
+ char buf[NM_INET_ADDRSTRLEN];
NMLogDomain log_domain = LOGD_IP4;
/* Shouldn't be any active ping here, since IP_CHECK happens after the
@@ -13892,14 +13892,14 @@ nm_device_start_ip_check(NMDevice *self)
} else if (priv->ip_data_4.state == NM_DEVICE_IP_STATE_READY) {
gw = nm_l3_config_data_get_best_default_route(l3cd, AF_INET);
if (gw) {
- _nm_utils_inet4_ntop(NMP_OBJECT_CAST_IP4_ROUTE(gw)->gateway, buf);
+ nm_inet4_ntop(NMP_OBJECT_CAST_IP4_ROUTE(gw)->gateway, buf);
ping_binary = nm_utils_find_helper("ping", "/usr/bin/ping", NULL);
log_domain = LOGD_IP4;
}
} else if (priv->ip_data_6.state == NM_DEVICE_IP_STATE_READY) {
gw = nm_l3_config_data_get_best_default_route(l3cd, AF_INET6);
if (gw) {
- _nm_utils_inet6_ntop(&NMP_OBJECT_CAST_IP6_ROUTE(gw)->gateway, buf);
+ nm_inet6_ntop(&NMP_OBJECT_CAST_IP6_ROUTE(gw)->gateway, buf);
ping_binary = nm_utils_find_helper("ping6", "/usr/bin/ping6", NULL);
log_domain = LOGD_IP6;
}
diff --git a/src/core/devices/nm-lldp-listener.c b/src/core/devices/nm-lldp-listener.c
index 137bf8fbfe..2b077633e4 100644
--- a/src/core/devices/nm-lldp-listener.c
+++ b/src/core/devices/nm-lldp-listener.c
@@ -360,7 +360,7 @@ format_network_address(const guint8 *data, gsize sz)
} else
return NULL;
- return nm_utils_inet_ntop_dup(family, &a);
+ return nm_inet_ntop_dup(family, &a);
}
static const char *
diff --git a/src/core/devices/wifi/nm-device-iwd.c b/src/core/devices/wifi/nm-device-iwd.c
index ab37cbec91..c10afdecdf 100644
--- a/src/core/devices/wifi/nm-device-iwd.c
+++ b/src/core/devices/wifi/nm-device-iwd.c
@@ -70,6 +70,7 @@ typedef struct {
bool secrets_failed : 1;
bool networks_requested : 1;
bool networks_changed : 1;
+ bool assuming : 1;
gint64 last_scan;
uint32_t ap_id;
guint32 rate;
@@ -77,6 +78,7 @@ typedef struct {
GDBusMethodInvocation *pending_agent_request;
NMActiveConnection *assumed_ac;
guint assumed_ac_timeout;
+ NMIwdManager *manager;
} NMDeviceIwdPrivate;
struct _NMDeviceIwd {
@@ -289,6 +291,7 @@ insert_ap_from_network(NMDeviceIwd *self,
gint64 last_seen_msec,
int16_t signal)
{
+ NMDeviceIwdPrivate *priv = NM_DEVICE_IWD_GET_PRIVATE(self);
gs_unref_object GDBusProxy *network_proxy = NULL;
nm_auto_ref_string NMRefString *bss_path = nm_ref_string_new(path);
NMWifiAP *ap;
@@ -299,7 +302,7 @@ insert_ap_from_network(NMDeviceIwd *self,
}
network_proxy =
- nm_iwd_manager_get_dbus_interface(nm_iwd_manager_get(), path, NM_IWD_NETWORK_INTERFACE);
+ nm_iwd_manager_get_dbus_interface(priv->manager, path, NM_IWD_NETWORK_INTERFACE);
ap = ap_from_network(self, network_proxy, bss_path, last_seen_msec, signal);
if (!ap)
@@ -581,6 +584,10 @@ deactivate(NMDevice *device)
if (!priv->dbus_obj)
return;
+ /* Don't cause IWD to break the connection being assumed */
+ if (priv->assuming)
+ return;
+
if (priv->dbus_station_proxy) {
gs_unref_variant GVariant *value =
g_dbus_proxy_get_cached_property(priv->dbus_station_proxy, "State");
@@ -673,7 +680,7 @@ deactivate_async(NMDevice *device,
}
static gboolean
-is_connection_known_network(NMConnection *connection)
+is_connection_known_network(NMIwdManager *manager, NMConnection *connection)
{
NMIwdNetworkSecurity security;
gs_free char *ssid = NULL;
@@ -681,17 +688,17 @@ is_connection_known_network(NMConnection *connection)
if (!nm_wifi_connection_get_iwd_ssid_and_security(connection, &ssid, &security))
return FALSE;
- return nm_iwd_manager_is_known_network(nm_iwd_manager_get(), ssid, security);
+ return nm_iwd_manager_is_known_network(manager, ssid, security);
}
static gboolean
-is_ap_known_network(NMWifiAP *ap)
+is_ap_known_network(NMIwdManager *manager, NMWifiAP *ap)
{
gs_unref_object GDBusProxy *network_proxy = NULL;
gs_unref_variant GVariant *known_network = NULL;
network_proxy =
- nm_iwd_manager_get_dbus_interface(nm_iwd_manager_get(),
+ nm_iwd_manager_get_dbus_interface(manager,
nm_ref_string_get_str(nm_wifi_ap_get_supplicant_path(ap)),
NM_IWD_NETWORK_INTERFACE);
if (!network_proxy)
@@ -794,7 +801,8 @@ check_connection_compatible(NMDevice *device, NMConnection *connection, GError *
* thus are Known Networks.
*/
if (security == NM_IWD_NETWORK_SECURITY_8021X) {
- if (!is_connection_known_network(connection)) {
+ if (!is_connection_known_network(priv->manager, connection)
+ && !nm_iwd_manager_is_recently_mirrored(priv->manager, ssid)) {
nm_utils_error_set_literal(error,
NM_UTILS_ERROR_CONNECTION_AVAILABLE_INCOMPATIBLE,
"802.1x connections must have IWD provisioning files");
@@ -927,7 +935,9 @@ check_connection_available(NMDevice *device,
*/
if (nm_wifi_connection_get_iwd_ssid_and_security(connection, NULL, &security)
&& security == NM_IWD_NETWORK_SECURITY_8021X) {
- if (!is_ap_known_network(ap)) {
+ if (!is_ap_known_network(priv->manager, ap)
+ && !nm_iwd_manager_is_recently_mirrored(priv->manager,
+ nm_setting_wireless_get_ssid(s_wifi))) {
nm_utils_error_set_literal(
error,
NM_UTILS_ERROR_CONNECTION_AVAILABLE_TEMPORARY,
@@ -2044,7 +2054,7 @@ assume_connection(NMDeviceIwd *self, NMWifiAP *ap)
* becomes "managed" only when ACTIVATED but for IWD it's really
* managed when IP_CONFIG starts.
*/
- sett_conn = nm_iwd_manager_get_ap_mirror_connection(nm_iwd_manager_get(), ap);
+ sett_conn = nm_iwd_manager_get_ap_mirror_connection(priv->manager, ap);
if (!sett_conn)
goto error;
@@ -2217,7 +2227,8 @@ act_stage1_prepare(NMDevice *device, NMDeviceStateReason *out_failure_reason)
* for a first-time connection to a hidden network. If a hidden network is
* a Known Network it should still have been in the AP list.
*/
- if (!nm_setting_wireless_get_hidden(s_wireless) || is_connection_known_network(connection))
+ if (!nm_setting_wireless_get_hidden(s_wireless)
+ || is_connection_known_network(priv->manager, connection))
return NM_ACT_STAGE_RETURN_FAILURE;
add_new:
@@ -2270,6 +2281,18 @@ act_stage2_config(NMDevice *device, NMDeviceStateReason *out_failure_reason)
goto out_fail;
}
+ /* With priv->iwd_autoconnect we have to let IWD handle retries for
+ * infrastructure networks. IWD will not necessarily retry the same
+ * network after a failure but it will likely go into an autoconnect
+ * mode and we don't want to try to override the logic. We don't need
+ * to reset the retry count so we set no timeout.
+ */
+ if (priv->iwd_autoconnect) {
+ NMSettingsConnection *sett_conn = nm_act_request_get_settings_connection(req);
+
+ nm_settings_connection_autoconnect_retries_set(sett_conn, 0);
+ }
+
/* With priv->iwd_autoconnect, if we're assuming a connection because
* of a state change to "connecting", signal stage 2 is still running.
* If "connected" or "roaming", we can go right to the IP_CONFIG state
@@ -2310,7 +2333,9 @@ act_stage2_config(NMDevice *device, NMDeviceStateReason *out_failure_reason)
* fail, for other combinations we will let the Connect call fail
* or ask us for any missing secrets through the Agent.
*/
- if (nm_connection_get_setting_802_1x(connection) && !is_ap_known_network(ap)) {
+ if (nm_connection_get_setting_802_1x(connection) && !is_ap_known_network(priv->manager, ap)
+ && !nm_iwd_manager_is_recently_mirrored(priv->manager,
+ nm_setting_wireless_get_ssid(s_wireless))) {
_LOGI(LOGD_DEVICE | LOGD_WIFI,
"Activation: (wifi) access point '%s' has 802.1x security but is not configured "
"in IWD.",
@@ -2351,7 +2376,7 @@ act_stage2_config(NMDevice *device, NMDeviceStateReason *out_failure_reason)
}
network_proxy = nm_iwd_manager_get_dbus_interface(
- nm_iwd_manager_get(),
+ priv->manager,
nm_ref_string_get_str(nm_wifi_ap_get_supplicant_path(ap)),
NM_IWD_NETWORK_INTERFACE);
if (!network_proxy) {
@@ -2719,12 +2744,20 @@ state_changed(NMDeviceIwd *self, const char *new_state)
"IWD is connecting to the wrong AP, %s activation",
switch_ap ? "replacing" : "aborting");
cleanup_association_attempt(self, !switch_ap);
+
+ if (!switch_ap) {
+ nm_device_state_changed(device,
+ NM_DEVICE_STATE_FAILED,
+ NM_DEVICE_STATE_REASON_SUPPLICANT_DISCONNECT);
+ return;
+ }
+
+ priv->assuming = TRUE; /* Don't send Station.Disconnect() */
nm_device_state_changed(device,
- NM_DEVICE_STATE_FAILED,
+ NM_DEVICE_STATE_DISCONNECTED,
NM_DEVICE_STATE_REASON_SUPPLICANT_DISCONNECT);
-
- if (switch_ap)
- assume_connection(self, ap);
+ priv->assuming = FALSE;
+ assume_connection(self, ap);
return;
}
@@ -3101,7 +3134,7 @@ nm_device_iwd_set_dbus_object(NMDeviceIwd *self, GDBusObject *object)
goto error;
}
- adapter_proxy = nm_iwd_manager_get_dbus_interface(nm_iwd_manager_get(),
+ adapter_proxy = nm_iwd_manager_get_dbus_interface(priv->manager,
g_variant_get_string(value, NULL),
NM_IWD_WIPHY_INTERFACE);
if (!adapter_proxy) {
@@ -3411,7 +3444,7 @@ nm_device_iwd_init(NMDeviceIwd *self)
g_signal_connect(self, "notify::" NM_DEVICE_AUTOCONNECT, G_CALLBACK(autoconnect_changed), self);
/* Make sure the manager is running */
- (void) nm_iwd_manager_get();
+ priv->manager = g_object_ref(nm_iwd_manager_get());
}
NMDevice *
@@ -3443,6 +3476,8 @@ dispose(GObject *object)
G_OBJECT_CLASS(nm_device_iwd_parent_class)->dispose(object);
nm_assert(c_list_is_empty(&priv->aps_lst_head));
+
+ g_clear_object(&priv->manager);
}
static void
diff --git a/src/core/devices/wifi/nm-device-wifi-p2p.c b/src/core/devices/wifi/nm-device-wifi-p2p.c
index 4576af95cb..6c0a4d5e8d 100644
--- a/src/core/devices/wifi/nm-device-wifi-p2p.c
+++ b/src/core/devices/wifi/nm-device-wifi-p2p.c
@@ -22,7 +22,6 @@
#include "nm-act-request.h"
#include "nm-l3-config-data.h"
#include "nm-manager.h"
-#include "nm-manager.h"
#include "nm-setting-wifi-p2p.h"
#include "nm-utils.h"
#include "nm-wifi-p2p-peer.h"
diff --git a/src/core/devices/wifi/nm-iwd-manager.c b/src/core/devices/wifi/nm-iwd-manager.c
index 2e0d51e5d8..ec111329a2 100644
--- a/src/core/devices/wifi/nm-iwd-manager.c
+++ b/src/core/devices/wifi/nm-iwd-manager.c
@@ -47,6 +47,11 @@ typedef struct {
} KnownNetworkData;
typedef struct {
+ GBytes *ssid;
+ gint64 timestamp;
+} RecentlyMirroredData;
+
+typedef struct {
NMManager *manager;
NMSettings *settings;
GCancellable *cancellable;
@@ -62,6 +67,7 @@ typedef struct {
GHashTable *p2p_devices;
NMIwdWfdInfo wfd_info;
guint wfd_use_count;
+ GSList *recently_mirrored;
} NMIwdManagerPrivate;
struct _NMIwdManager {
@@ -353,6 +359,70 @@ register_agent(NMIwdManager *self)
/*****************************************************************************/
+static void
+recently_mirrored_data_free(void *data)
+{
+ RecentlyMirroredData *rmd = data;
+
+ g_bytes_unref(rmd->ssid);
+ g_free(rmd);
+}
+
+/* When we mirror an 802.1x connection to an IWD config file, and there's an
+ * AP in range with matching SSID, that connection should become available
+ * for activation. In IWD terms when an 802.1x network becomes a Known
+ * Network, it can be connected to using the .Connect D-Bus method.
+ *
+ * However there's a delay between writing the IWD config file and receiving
+ * the InterfaceAdded event for the Known Network so we don't immediately
+ * find out that the network can now be used. If an NM client creates a
+ * new connection for an 802.1x AP and tries to activate it immediately,
+ * NMDeviceIWD will not allow it to because it doesn't know the network is
+ * known yet. To work around this, we save the SSIDs of 802.1x connections
+ * we recently mirrored to IWD config files, for 2 seconds, and we treat
+ * them as Known Networks in that period since in theory activations should
+ * succeed.
+ */
+bool
+nm_iwd_manager_is_recently_mirrored(NMIwdManager *self, const GBytes *ssid)
+{
+ NMIwdManagerPrivate *priv = NM_IWD_MANAGER_GET_PRIVATE(self);
+ gint64 now = nm_utils_get_monotonic_timestamp_nsec();
+ GSList *iter;
+ RecentlyMirroredData *rmd;
+
+ /* Drop entries older than 2 seconds */
+ while (priv->recently_mirrored) {
+ rmd = priv->recently_mirrored->data;
+ if (now < rmd->timestamp + 2000000000)
+ break;
+
+ priv->recently_mirrored = g_slist_remove(priv->recently_mirrored, rmd);
+ recently_mirrored_data_free(rmd);
+ }
+
+ for (iter = priv->recently_mirrored; iter; iter = iter->next) {
+ rmd = iter->data;
+ if (g_bytes_equal(ssid, rmd->ssid))
+ return TRUE;
+ }
+
+ return FALSE;
+}
+
+static void
+save_mirrored(NMIwdManager *self, GBytes *ssid)
+{
+ NMIwdManagerPrivate *priv = NM_IWD_MANAGER_GET_PRIVATE(self);
+ RecentlyMirroredData *rmd = g_malloc(sizeof(RecentlyMirroredData));
+
+ rmd->ssid = g_bytes_ref(ssid);
+ rmd->timestamp = nm_utils_get_monotonic_timestamp_nsec();
+ priv->recently_mirrored = g_slist_append(priv->recently_mirrored, rmd);
+}
+
+/*****************************************************************************/
+
static KnownNetworkId *
known_network_id_new(const char *name, NMIwdNetworkSecurity security)
{
@@ -721,6 +791,9 @@ sett_conn_changed(NMSettingsConnection *sett_conn,
"iwd: changed Wi-Fi connection %s mirrored as IWD profile %s",
nm_settings_connection_get_id(sett_conn),
full_path);
+
+ if (security == NM_IWD_NETWORK_SECURITY_8021X)
+ save_mirrored(nm_iwd_manager_get(), ssid);
}
/* Look up an existing NMSettingsConnection for a network that has been
@@ -1283,6 +1356,7 @@ connection_added(NMSettings *settings, NMSettingsConnection *sett_conn, gpointer
gs_free_error GError *error = NULL;
nm_auto_unref_keyfile GKeyFile *iwd_config = NULL;
NMSettingsConnectionIntFlags flags;
+ NMIwdNetworkSecurity security;
if (!nm_streq(nm_settings_connection_get_connection_type(sett_conn), "802-11-wireless"))
return;
@@ -1338,6 +1412,12 @@ connection_added(NMSettings *settings, NMSettingsConnection *sett_conn, gpointer
_LOGD("New Wi-Fi connection %s mirrored as IWD profile %s",
nm_settings_connection_get_id(sett_conn),
full_path);
+
+ if (nm_wifi_connection_get_iwd_ssid_and_security(conn, NULL, &security)
+ && security == NM_IWD_NETWORK_SECURITY_8021X) {
+ NMSettingWireless *s_wifi = nm_connection_get_setting_wireless(conn);
+ save_mirrored(nm_iwd_manager_get(), nm_setting_wireless_get_ssid(s_wifi));
+ }
}
static gboolean
@@ -1952,6 +2032,8 @@ dispose(GObject *object)
g_hash_table_unref(nm_steal_pointer(&priv->p2p_devices));
+ g_slist_free_full(nm_steal_pointer(&priv->recently_mirrored), recently_mirrored_data_free);
+
G_OBJECT_CLASS(nm_iwd_manager_parent_class)->dispose(object);
}
diff --git a/src/core/devices/wifi/nm-iwd-manager.h b/src/core/devices/wifi/nm-iwd-manager.h
index 02cd6bba50..80a2753462 100644
--- a/src/core/devices/wifi/nm-iwd-manager.h
+++ b/src/core/devices/wifi/nm-iwd-manager.h
@@ -63,4 +63,6 @@ gboolean nm_iwd_manager_check_wfd_info_compatible(NMIwdManager *self, const NMIw
gboolean nm_iwd_manager_register_wfd(NMIwdManager *self, const NMIwdWfdInfo *wfd_info);
void nm_iwd_manager_unregister_wfd(NMIwdManager *self);
+bool nm_iwd_manager_is_recently_mirrored(NMIwdManager *self, const GBytes *ssid);
+
#endif /* __NETWORKMANAGER_IWD_MANAGER_H__ */
diff --git a/src/core/devices/wifi/nm-wifi-utils.c b/src/core/devices/wifi/nm-wifi-utils.c
index 1a8204b082..185f8c3da4 100644
--- a/src/core/devices/wifi/nm-wifi-utils.c
+++ b/src/core/devices/wifi/nm-wifi-utils.c
@@ -1591,12 +1591,12 @@ ip4_config_to_iwd_config(GKeyFile *file, NMSettingIPConfig *s_ip, GError **error
if (num) {
NMIPAddress *addr = nm_setting_ip_config_get_address(s_ip, 0);
guint prefix = nm_ip_address_get_prefix(addr);
- in_addr_t netmask = _nm_utils_ip4_prefix_to_netmask(prefix);
+ in_addr_t netmask = nm_ip4_addr_netmask_from_prefix(prefix);
char buf[INET_ADDRSTRLEN];
nm_ip_address_get_address_binary(addr, &ip);
g_key_file_set_string(file, "IPv4", "Address", nm_ip_address_get_address(addr));
- g_key_file_set_string(file, "IPv4", "Netmask", _nm_utils_inet4_ntop(netmask, buf));
+ g_key_file_set_string(file, "IPv4", "Netmask", nm_inet4_ntop(netmask, buf));
} else {
inet_pton(AF_INET, "10.42.0.100", &ip);
g_key_file_set_string(file, "IPv4", "Address", "10.42.0.100");
@@ -1614,7 +1614,7 @@ ip4_config_to_iwd_config(GKeyFile *file, NMSettingIPConfig *s_ip, GError **error
val = (ntohl(ip.s_addr) & 0xfffffff0) + 1;
if (val == ntohl(ip.s_addr))
val += 1;
- g_key_file_set_string(file, "IPv4", "Gateway", _nm_utils_inet4_ntop(htonl(val), buf));
+ g_key_file_set_string(file, "IPv4", "Gateway", nm_inet4_ntop(htonl(val), buf));
}
return TRUE;
diff --git a/src/core/devices/wwan/nm-modem-broadband.c b/src/core/devices/wwan/nm-modem-broadband.c
index 997fe72729..a4078be842 100644
--- a/src/core/devices/wwan/nm-modem-broadband.c
+++ b/src/core/devices/wwan/nm-modem-broadband.c
@@ -993,7 +993,7 @@ stage3_ip_config_start(NMModem *modem, int addr_family, NMModemIPMethod ip_metho
/* Fully fail if invalid IP address retrieved */
address_string = mm_bearer_ip_config_get_address(self->_priv.ipv4_config);
if (!address_string
- || !nm_utils_parse_inaddr_bin(AF_INET, address_string, NULL, &address_network)) {
+ || !nm_inet_parse_bin(AF_INET, address_string, NULL, &address_network)) {
g_set_error(&error,
NM_DEVICE_ERROR,
NM_DEVICE_ERROR_INVALID_CONNECTION,
@@ -1005,7 +1005,7 @@ stage3_ip_config_start(NMModem *modem, int addr_family, NMModemIPMethod ip_metho
/* Missing gateway not a hard failure */
gw_string = mm_bearer_ip_config_get_gateway(self->_priv.ipv4_config);
- if (gw_string && !nm_utils_parse_inaddr_bin(AF_INET, gw_string, NULL, &gw)) {
+ if (gw_string && !nm_inet_parse_bin(AF_INET, gw_string, NULL, &gw)) {
g_set_error(&error,
NM_DEVICE_ERROR,
NM_DEVICE_ERROR_INVALID_CONNECTION,
@@ -1057,8 +1057,7 @@ stage3_ip_config_start(NMModem *modem, int addr_family, NMModemIPMethod ip_metho
dns = mm_bearer_ip_config_get_dns(self->_priv.ipv4_config);
for (i = 0; dns && dns[i]; i++) {
- if (nm_utils_parse_inaddr_bin(AF_INET, dns[i], NULL, &address_network)
- && address_network > 0) {
+ if (nm_inet_parse_bin(AF_INET, dns[i], NULL, &address_network) && address_network > 0) {
nm_l3_config_data_add_nameserver(l3cd, AF_INET, &address_network);
_LOGI(" DNS %s", dns[i]);
}
diff --git a/src/core/devices/wwan/nm-modem-ofono.c b/src/core/devices/wwan/nm-modem-ofono.c
index c003880e6c..4a5ed6613f 100644
--- a/src/core/devices/wwan/nm-modem-ofono.c
+++ b/src/core/devices/wwan/nm-modem-ofono.c
@@ -786,7 +786,7 @@ handle_settings(GVariant *v_dict, gpointer user_data)
_LOGW("Settings 'Address' missing");
goto out;
}
- if (!s || !nm_utils_parse_inaddr_bin(AF_INET, s, NULL, &address_network)) {
+ if (!s || !nm_inet_parse_bin(AF_INET, s, NULL, &address_network)) {
_LOGW("can't convert 'Address' %s to addr", s ?: "");
goto out;
}
@@ -801,11 +801,11 @@ handle_settings(GVariant *v_dict, gpointer user_data)
_LOGW("Settings 'Netmask' missing");
goto out;
}
- if (!s || !nm_utils_parse_inaddr_bin(AF_INET, s, NULL, &address_network)) {
+ if (!s || !nm_inet_parse_bin(AF_INET, s, NULL, &address_network)) {
_LOGW("invalid 'Netmask': %s", s ?: "");
goto out;
}
- address.plen = _nm_utils_ip4_netmask_to_prefix(address_network);
+ address.plen = nm_ip4_addr_netmask_to_prefix(address_network);
_LOGI("Address: %s", nm_platform_ip4_address_to_string(&address, sbuf, sizeof(sbuf)));
nm_l3_config_data_add_address_4(priv->l3cd_4, &address);
@@ -814,7 +814,7 @@ handle_settings(GVariant *v_dict, gpointer user_data)
_LOGW("Settings 'Gateway' missing");
goto out;
}
- if (!nm_utils_parse_inaddr_bin(AF_INET, s, NULL, &gateway_network)) {
+ if (!nm_inet_parse_bin(AF_INET, s, NULL, &gateway_network)) {
_LOGW("invalid 'Gateway': %s", s);
goto out;
}
@@ -840,8 +840,7 @@ handle_settings(GVariant *v_dict, gpointer user_data)
gboolean any_good = FALSE;
for (; array[0]; array++) {
- if (!nm_utils_parse_inaddr_bin(AF_INET, *array, NULL, &address_network)
- || !address_network) {
+ if (!nm_inet_parse_bin(AF_INET, *array, NULL, &address_network) || !address_network) {
_LOGW("invalid NameServer: %s", *array);
continue;
}
@@ -857,7 +856,7 @@ handle_settings(GVariant *v_dict, gpointer user_data)
if (g_variant_lookup(v_dict, "MessageProxy", "&s", &s)) {
_LOGI("MessageProxy: %s", s);
- if (s && nm_utils_parse_inaddr_bin(AF_INET, s, NULL, &address_network)) {
+ if (s && nm_inet_parse_bin(AF_INET, s, NULL, &address_network)) {
const NMPlatformIP4Route mms_route = {
.network = address_network,
.plen = 32,
diff --git a/src/core/dhcp/nm-dhcp-client.c b/src/core/dhcp/nm-dhcp-client.c
index 77cfeecf81..34873ac2e3 100644
--- a/src/core/dhcp/nm-dhcp-client.c
+++ b/src/core/dhcp/nm-dhcp-client.c
@@ -469,10 +469,10 @@ _acd_reglist_data_remove(NMDhcpClient *self, guint idx, gboolean do_log)
reglist_data = _acd_reglist_data_get(priv, idx);
if (do_log) {
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
_LOGD("acd: drop check for address %s (l3cd " NM_HASH_OBFUSCATE_PTR_FMT ")",
- _nm_utils_inet4_ntop(reglist_data->addr, sbuf_addr),
+ nm_inet4_ntop(reglist_data->addr, sbuf_addr),
NM_HASH_OBFUSCATE_PTR(reglist_data->l3cd));
}
@@ -551,7 +551,7 @@ static void
_acd_check_lease(NMDhcpClient *self, NMOptionBool *out_acd_state)
{
NMDhcpClientPrivate *priv = NM_DHCP_CLIENT_GET_PRIVATE(self);
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
in_addr_t addr;
gboolean addr_changed = FALSE;
guint idx;
@@ -590,7 +590,7 @@ _acd_check_lease(NMDhcpClient *self, NMOptionBool *out_acd_state)
_LOGD("acd: %s check for address %s (timeout %u msec, l3cd " NM_HASH_OBFUSCATE_PTR_FMT ")",
addr_changed ? "add" : "update",
- _nm_utils_inet4_ntop(addr, sbuf_addr),
+ nm_inet4_ntop(addr, sbuf_addr),
priv->config.v4.acd_timeout_msec,
NM_HASH_OBFUSCATE_PTR(priv->l3cd_next));
@@ -677,7 +677,7 @@ gboolean
_nm_dhcp_client_accept_offer(NMDhcpClient *self, gconstpointer p_yiaddr)
{
NMDhcpClientPrivate *priv = NM_DHCP_CLIENT_GET_PRIVATE(self);
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
NMIPAddr yiaddr;
const NML3AcdAddrInfo *acd_info;
@@ -710,7 +710,7 @@ _nm_dhcp_client_accept_offer(NMDhcpClient *self, gconstpointer p_yiaddr)
return TRUE;
_LOGD("offered lease rejected: address %s failed ACD check",
- _nm_utils_inet4_ntop(yiaddr.addr4, sbuf_addr));
+ nm_inet4_ntop(yiaddr.addr4, sbuf_addr));
return FALSE;
}
@@ -1078,7 +1078,7 @@ static void
l3_cfg_notify_cb(NML3Cfg *l3cfg, const NML3ConfigNotifyData *notify_data, NMDhcpClient *self)
{
NMDhcpClientPrivate *priv = NM_DHCP_CLIENT_GET_PRIVATE(self);
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
nm_assert(l3cfg == priv->config.l3cfg);
@@ -1240,7 +1240,7 @@ wait_dhcp_commit_done:
if (acd_state != NM_OPTION_BOOL_DEFAULT) {
_LOGD("acd: acd %s for %s",
acd_state ? "ready" : "conflict",
- _nm_utils_inet4_ntop(priv->v4.acd.addr, sbuf_addr));
+ nm_inet4_ntop(priv->v4.acd.addr, sbuf_addr));
nm_l3cfg_commit_type_clear(priv->config.l3cfg, &priv->v4.acd.l3cfg_commit_handle);
priv->v4.acd.state = acd_state;
priv->v4.acd.done_source = nm_g_idle_add_source(_acd_complete_on_idle_cb, self);
@@ -1660,14 +1660,14 @@ nm_dhcp_client_server_id_is_rejected(NMDhcpClient *self, gconstpointer addr)
in_addr_t mask;
int r_prefix;
- if (!nm_utils_parse_inaddr_prefix_bin(AF_INET,
- priv->config.reject_servers[i],
- NULL,
- &r_addr,
- &r_prefix))
+ if (!nm_inet_parse_with_prefix_bin(AF_INET,
+ priv->config.reject_servers[i],
+ NULL,
+ &r_addr,
+ &r_prefix))
nm_assert_not_reached();
- mask = _nm_utils_ip4_prefix_to_netmask(r_prefix < 0 ? 32 : r_prefix);
+ mask = nm_ip4_addr_netmask_from_prefix(r_prefix < 0 ? 32 : r_prefix);
if ((addr4 & mask) == (r_addr & mask))
return TRUE;
}
diff --git a/src/core/dhcp/nm-dhcp-nettools.c b/src/core/dhcp/nm-dhcp-nettools.c
index 05b7b52e95..f4f783a395 100644
--- a/src/core/dhcp/nm-dhcp-nettools.c
+++ b/src/core/dhcp/nm-dhcp-nettools.c
@@ -143,12 +143,12 @@ lease_option_consume_route(const uint8_t **datap,
if (!nm_dhcp_lease_data_consume_in_addr(&data, &n_data, &dest))
return FALSE;
- plen = _nm_utils_ip4_get_default_prefix0(dest);
+ plen = nm_ip4_addr_get_default_prefix0(dest);
if (plen == 0)
return FALSE;
}
- dest = nm_utils_ip4_address_clear_host_address(dest, plen);
+ dest = nm_ip4_addr_clear_host_address(dest, plen);
if (!nm_dhcp_lease_data_consume_in_addr(&data, &n_data, &gateway))
return FALSE;
@@ -239,16 +239,16 @@ lease_parse_address(NMDhcpNettools *self /* for logging context only */,
r = _client_lease_query(lease, NM_DHCP_OPTION_DHCP4_SUBNET_MASK, &l_data, &l_data_len);
if (r == N_DHCP4_E_UNSET) {
- char str1[NM_UTILS_INET_ADDRSTRLEN];
- char str2[NM_UTILS_INET_ADDRSTRLEN];
+ char str1[NM_INET_ADDRSTRLEN];
+ char str2[NM_INET_ADDRSTRLEN];
/* Some DHCP servers may not set the subnet-mask (issue#1037).
* Do the same as the dhclient plugin and use a default. */
- a_plen = _nm_utils_ip4_get_default_prefix(a_address.s_addr);
- a_netmask = _nm_utils_ip4_prefix_to_netmask(a_plen);
+ a_plen = nm_ip4_addr_get_default_prefix(a_address.s_addr);
+ a_netmask = nm_ip4_addr_netmask_from_prefix(a_plen);
_LOGT("missing subnet mask (option 1). Guess %s based on IP address %s",
- _nm_utils_inet4_ntop(a_netmask, str1),
- _nm_utils_inet4_ntop(a_address.s_addr, str2));
+ nm_inet4_ntop(a_netmask, str1),
+ nm_inet4_ntop(a_address.s_addr, str2));
} else {
if (r != 0
|| !nm_dhcp_lease_data_parse_in_addr(l_data,
@@ -261,8 +261,8 @@ lease_parse_address(NMDhcpNettools *self /* for logging context only */,
"could not get netmask from lease");
return FALSE;
}
- a_plen = _nm_utils_ip4_netmask_to_prefix(a_netmask);
- a_netmask = _nm_utils_ip4_prefix_to_netmask(a_plen);
+ a_plen = nm_ip4_addr_netmask_to_prefix(a_netmask);
+ a_netmask = nm_ip4_addr_netmask_from_prefix(a_plen);
}
nm_dhcp_option_add_option_in_addr(options,
@@ -335,22 +335,22 @@ lease_parse_address_list(NDhcp4ClientLease *lease,
nm_str_buf_reset(sbuf);
for (; l_data_len > 0; l_data_len -= 4, l_data += 4) {
- char addr_str[NM_UTILS_INET_ADDRSTRLEN];
+ char addr_str[NM_INET_ADDRSTRLEN];
const in_addr_t addr = unaligned_read_ne32(l_data);
nm_str_buf_append_required_delimiter(sbuf, ' ');
- nm_str_buf_append(sbuf, _nm_utils_inet4_ntop(addr, addr_str));
+ nm_str_buf_append(sbuf, nm_inet4_ntop(addr, addr_str));
switch (option) {
case NM_DHCP_OPTION_DHCP4_DOMAIN_NAME_SERVER:
- if (addr == 0 || nm_utils_ip4_address_is_loopback(addr)) {
+ if (addr == 0 || nm_ip4_addr_is_loopback(addr)) {
/* Skip localhost addresses, like also networkd does.
* See https://github.com/systemd/systemd/issues/4524. */
nm_dhcp_lease_log_invalid_option(iface,
AF_INET,
option,
"address %s is ignored",
- _nm_utils_inet4_ntop(addr, addr_str));
+ nm_inet4_ntop(addr, addr_str));
continue;
}
nm_l3_config_data_add_nameserver(l3cd, AF_INET, &addr);
@@ -378,8 +378,8 @@ lease_parse_routes(NDhcp4ClientLease *lease,
GHashTable *options,
NMStrBuf *sbuf)
{
- char dest_str[NM_UTILS_INET_ADDRSTRLEN];
- char gateway_str[NM_UTILS_INET_ADDRSTRLEN];
+ char dest_str[NM_INET_ADDRSTRLEN];
+ char gateway_str[NM_INET_ADDRSTRLEN];
in_addr_t dest;
in_addr_t gateway;
uint8_t plen;
@@ -412,8 +412,8 @@ lease_parse_routes(NDhcp4ClientLease *lease,
nm_str_buf_reset(sbuf);
while (lease_option_consume_route(&l_data, &l_data_len, TRUE, &dest, &plen, &gateway)) {
- _nm_utils_inet4_ntop(dest, dest_str);
- _nm_utils_inet4_ntop(gateway, gateway_str);
+ nm_inet4_ntop(dest, dest_str);
+ nm_inet4_ntop(gateway, gateway_str);
nm_str_buf_append_required_delimiter(sbuf, ' ');
nm_str_buf_append_printf(sbuf, "%s/%d %s", dest_str, (int) plen, gateway_str);
@@ -454,8 +454,8 @@ lease_parse_routes(NDhcp4ClientLease *lease,
nm_str_buf_reset(sbuf);
while (lease_option_consume_route(&l_data, &l_data_len, FALSE, &dest, &plen, &gateway)) {
- _nm_utils_inet4_ntop(dest, dest_str);
- _nm_utils_inet4_ntop(gateway, gateway_str);
+ nm_inet4_ntop(dest, dest_str);
+ nm_inet4_ntop(gateway, gateway_str);
nm_str_buf_append_required_delimiter(sbuf, ' ');
nm_str_buf_append_printf(sbuf, "%s/%d %s", dest_str, (int) plen, gateway_str);
@@ -501,7 +501,7 @@ lease_parse_routes(NDhcp4ClientLease *lease,
while (nm_dhcp_lease_data_consume_in_addr(&l_data, &l_data_len, &gateway)) {
nm_str_buf_append_required_delimiter(sbuf, ' ');
- nm_str_buf_append(sbuf, _nm_utils_inet4_ntop(gateway, gateway_str));
+ nm_str_buf_append(sbuf, nm_inet4_ntop(gateway, gateway_str));
if (gateway == 0) {
/* silently skip 0.0.0.0 */
@@ -868,7 +868,7 @@ lease_save(NMDhcpNettools *self, NDhcp4ClientLease *lease, const char *lease_fil
{
struct in_addr a_address;
nm_auto_str_buf NMStrBuf sbuf = NM_STR_BUF_INIT(NM_UTILS_GET_NEXT_REALLOC_SIZE_104, FALSE);
- char addr_str[NM_UTILS_INET_ADDRSTRLEN];
+ char addr_str[NM_INET_ADDRSTRLEN];
gs_free_error GError *error = NULL;
nm_assert(lease);
@@ -879,9 +879,7 @@ lease_save(NMDhcpNettools *self, NDhcp4ClientLease *lease, const char *lease_fil
return;
nm_str_buf_append(&sbuf, "# This is private data. Do not parse.\n");
- nm_str_buf_append_printf(&sbuf,
- "ADDRESS=%s\n",
- _nm_utils_inet4_ntop(a_address.s_addr, addr_str));
+ nm_str_buf_append_printf(&sbuf, "ADDRESS=%s\n", nm_inet4_ntop(a_address.s_addr, addr_str));
if (!g_file_set_contents(lease_file, nm_str_buf_get_str_unsafe(&sbuf), sbuf.len, &error))
_LOGW("error saving lease to %s: %s", lease_file, error->message);
@@ -966,7 +964,7 @@ dhcp4_event_handle(NMDhcpNettools *self, NDhcp4ClientEvent *event)
if (nm_dhcp_client_server_id_is_rejected(NM_DHCP_CLIENT(self), &server_id)) {
_LOGD("server-id %s is in the reject-list, ignoring",
- nm_utils_inet_ntop(AF_INET, &server_id, addr_str));
+ nm_inet_ntop(AF_INET, &server_id, addr_str));
return;
}
@@ -976,8 +974,8 @@ dhcp4_event_handle(NMDhcpNettools *self, NDhcp4ClientEvent *event)
}
_LOGT("selecting offered lease from %s for %s",
- _nm_utils_inet4_ntop(server_id.s_addr, addr_str),
- _nm_utils_inet4_ntop(yiaddr.s_addr, addr_str2));
+ nm_inet4_ntop(server_id.s_addr, addr_str),
+ nm_inet4_ntop(yiaddr.s_addr, addr_str2));
r = n_dhcp4_client_lease_select(event->offer.lease);
@@ -1336,7 +1334,7 @@ ip4_start(NMDhcpClient *client, GError **error)
NULL);
nm_parse_env_file(contents, "ADDRESS", &s_addr);
if (s_addr)
- nm_utils_parse_inaddr_bin(AF_INET, s_addr, NULL, &last_addr);
+ nm_inet_parse_bin(AF_INET, s_addr, NULL, &last_addr);
}
if (last_addr.s_addr) {
diff --git a/src/core/dhcp/nm-dhcp-options.c b/src/core/dhcp/nm-dhcp-options.c
index 96fef81a40..5c4a821298 100644
--- a/src/core/dhcp/nm-dhcp-options.c
+++ b/src/core/dhcp/nm-dhcp-options.c
@@ -438,9 +438,9 @@ nm_dhcp_option_add_option_in_addr(GHashTable *options,
guint option,
in_addr_t value)
{
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
- nm_dhcp_option_add_option(options, addr_family, option, _nm_utils_inet4_ntop(value, sbuf));
+ nm_dhcp_option_add_option(options, addr_family, option, nm_inet4_ntop(value, sbuf));
}
void
diff --git a/src/core/dhcp/nm-dhcp-systemd.c b/src/core/dhcp/nm-dhcp-systemd.c
index 49e21d97e5..d406339a09 100644
--- a/src/core/dhcp/nm-dhcp-systemd.c
+++ b/src/core/dhcp/nm-dhcp-systemd.c
@@ -74,7 +74,7 @@ lease_to_ip6_config(NMDhcpSystemd *self, sd_dhcp6_lease *lease, gint32 ts, GErro
gs_unref_hashtable GHashTable *options = NULL;
struct in6_addr tmp_addr;
const struct in6_addr *dns;
- char addr_str[NM_UTILS_INET_ADDRSTRLEN];
+ char addr_str[NM_INET_ADDRSTRLEN];
char **domains;
char **ntp_fqdns;
const struct in6_addr *ntp_addrs;
@@ -107,7 +107,7 @@ lease_to_ip6_config(NMDhcpSystemd *self, sd_dhcp6_lease *lease, gint32 ts, GErro
nm_l3_config_data_add_address_6(l3cd, &address);
- _nm_utils_inet6_ntop(&tmp_addr, addr_str);
+ nm_inet6_ntop(&tmp_addr, addr_str);
g_string_append(nm_gstring_add_space_delimiter(str), addr_str);
has_any_addresses = TRUE;
@@ -133,7 +133,7 @@ lease_to_ip6_config(NMDhcpSystemd *self, sd_dhcp6_lease *lease, gint32 ts, GErro
if (num > 0) {
nm_gstring_prepare(&str);
for (i = 0; i < num; i++) {
- _nm_utils_inet6_ntop(&dns[i], addr_str);
+ nm_inet6_ntop(&dns[i], addr_str);
g_string_append(nm_gstring_add_space_delimiter(str), addr_str);
nm_l3_config_data_add_nameserver(l3cd, AF_INET6, &dns[i]);
}
@@ -170,7 +170,7 @@ lease_to_ip6_config(NMDhcpSystemd *self, sd_dhcp6_lease *lease, gint32 ts, GErro
num = sd_dhcp6_lease_get_ntp_addrs(lease, &ntp_addrs);
if (num > 0) {
for (i = 0; i < num; i++) {
- _nm_utils_inet6_ntop(&ntp_addrs[i], addr_str);
+ nm_inet6_ntop(&ntp_addrs[i], addr_str);
g_string_append(nm_gstring_add_space_delimiter(str), addr_str);
}
}
diff --git a/src/core/dhcp/nm-dhcp-utils.c b/src/core/dhcp/nm-dhcp-utils.c
index 1bffb3c437..6a389dbef4 100644
--- a/src/core/dhcp/nm-dhcp-utils.c
+++ b/src/core/dhcp/nm-dhcp-utils.c
@@ -94,7 +94,7 @@ ip4_process_dhcpcd_rfc3442_routes(const char *iface,
l3cd,
&((const NMPlatformIP4Route){
.rt_source = NM_IP_CONFIG_SOURCE_DHCP,
- .network = nm_utils_ip4_address_clear_host_address(rt_addr, rt_cidr),
+ .network = nm_ip4_addr_clear_host_address(rt_addr, rt_cidr),
.plen = rt_cidr,
.gateway = rt_route,
.pref_src = address,
@@ -139,7 +139,7 @@ process_dhclient_rfc3442_route(const char *const **p_octets, NMPlatformIP4Route
str_addr = g_strjoin(".", addr[0], addr[1], addr[2], addr[3], NULL);
if (inet_pton(AF_INET, str_addr, &tmp_addr) <= 0)
return FALSE;
- v_network = nm_utils_ip4_address_clear_host_address(tmp_addr, v_plen);
+ v_network = nm_ip4_addr_clear_host_address(tmp_addr, v_plen);
}
next_hop = g_strjoin(".", o[0], o[1], o[2], o[3], NULL);
@@ -203,9 +203,9 @@ ip4_process_dhclient_rfc3442_routes(const char *iface,
_LOG2I(LOGD_DHCP4,
iface,
" classless static route %s/%d gw %s",
- _nm_utils_inet4_ntop(route.network, b1),
+ nm_inet4_ntop(route.network, b1),
route.plen,
- _nm_utils_inet4_ntop(route.gateway, b2));
+ nm_inet4_ntop(route.gateway, b2));
}
}
@@ -324,8 +324,8 @@ process_classful_routes(const char *iface,
* The Static Routes option (option 33) does not provide a subnet mask
* for each route - it is assumed that the subnet mask is implicit in
* whatever network number is specified in each route entry */
- route.plen = _nm_utils_ip4_get_default_prefix(rt_addr);
- if (rt_addr & ~_nm_utils_ip4_prefix_to_netmask(route.plen)) {
+ route.plen = nm_ip4_addr_get_default_prefix(rt_addr);
+ if (rt_addr & ~nm_ip4_addr_netmask_from_prefix(route.plen)) {
/* RFC 943: target not "this network"; using host routing */
route.plen = 32;
}
@@ -337,7 +337,7 @@ process_classful_routes(const char *iface,
route.metric_any = TRUE;
route.metric = 0;
- route.network = nm_utils_ip4_address_clear_host_address(route.network, route.plen);
+ route.network = nm_ip4_addr_clear_host_address(route.network, route.plen);
nm_l3_config_data_add_route_4(l3cd, &route);
@@ -400,7 +400,7 @@ nm_dhcp_utils_ip4_config_from_options(NMDedupMultiIndex *multi_idx,
gboolean gateway_has = FALSE;
guint32 gateway = 0;
guint8 plen = 0;
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
guint32 now;
g_return_val_if_fail(options != NULL, NULL);
@@ -414,7 +414,7 @@ nm_dhcp_utils_ip4_config_from_options(NMDedupMultiIndex *multi_idx,
};
str = g_hash_table_lookup(options, "ip_address");
- if (!str || !nm_utils_parse_inaddr_bin(AF_INET, str, NULL, &addr))
+ if (!str || !nm_inet_parse_bin(AF_INET, str, NULL, &addr))
return NULL;
if (addr == INADDR_ANY)
return NULL;
@@ -423,11 +423,11 @@ nm_dhcp_utils_ip4_config_from_options(NMDedupMultiIndex *multi_idx,
str = g_hash_table_lookup(options, "subnet_mask");
if (str && (inet_pton(AF_INET, str, &tmp_addr) > 0)) {
- plen = _nm_utils_ip4_netmask_to_prefix(tmp_addr);
+ plen = nm_ip4_addr_netmask_to_prefix(tmp_addr);
_LOG2I(LOGD_DHCP4, iface, " plen %d (%s)", plen, str);
} else {
/* Get default netmask for the IP according to appropriate class. */
- plen = _nm_utils_ip4_get_default_prefix(addr);
+ plen = nm_ip4_addr_get_default_prefix(addr);
_LOG2I(LOGD_DHCP4, iface, " plen %d (default)", plen);
}
@@ -440,7 +440,7 @@ nm_dhcp_utils_ip4_config_from_options(NMDedupMultiIndex *multi_idx,
process_classful_routes(iface, options, l3cd, address.address);
if (gateway) {
- _LOG2I(LOGD_DHCP4, iface, " gateway %s", _nm_utils_inet4_ntop(gateway, sbuf));
+ _LOG2I(LOGD_DHCP4, iface, " gateway %s", nm_inet4_ntop(gateway, sbuf));
gateway_has = TRUE;
} else {
/* If the gateway wasn't provided as a classless static route with a
diff --git a/src/core/dns/nm-dns-dnsmasq.c b/src/core/dns/nm-dns-dnsmasq.c
index 7d0f0490e0..495208b19e 100644
--- a/src/core/dns/nm-dns-dnsmasq.c
+++ b/src/core/dns/nm-dns-dnsmasq.c
@@ -191,7 +191,8 @@ _gl_pid_kill_external(void)
if (!g_file_get_contents(PIDFILE, &contents, NULL, &error)) {
if (g_error_matches(error, G_FILE_ERROR, G_FILE_ERROR_NOENT))
do_unlink = FALSE;
- _LOGD("spawn: failure to read pidfile %s: %s", PIDFILE, error->message);
+ else
+ _LOGD("spawn: failure to read pidfile %s: %s", PIDFILE, error->message);
g_clear_error(&error);
goto handle_kill;
}
@@ -667,6 +668,14 @@ _gl_pid_spawn(const char *dm_binary,
/*****************************************************************************/
+void
+nm_dnsmasq_kill_external(void)
+{
+ _gl_pid_kill_external();
+}
+
+/*****************************************************************************/
+
typedef struct {
GDBusConnection *dbus_connection;
@@ -792,13 +801,13 @@ add_dnsmasq_nameserver(NMDnsDnsmasq *self,
g_variant_builder_close(servers);
}
-#define IP_ADDR_TO_STRING_BUFLEN (NM_UTILS_INET_ADDRSTRLEN + 1 + IFNAMSIZ)
+#define IP_ADDR_TO_STRING_BUFLEN (NM_INET_ADDRSTRLEN + 1 + IFNAMSIZ)
static const char *
ip_addr_to_string(int addr_family, gconstpointer addr, const char *iface, char *out_buf)
{
int n_written;
- char buf2[NM_UTILS_INET_ADDRSTRLEN];
+ char buf2[NM_INET_ADDRSTRLEN];
const char *separator;
nm_assert_addr_family(addr_family);
@@ -806,13 +815,13 @@ ip_addr_to_string(int addr_family, gconstpointer addr, const char *iface, char *
nm_assert(out_buf);
if (addr_family == AF_INET) {
- nm_utils_inet_ntop(addr_family, addr, buf2);
+ nm_inet_ntop(addr_family, addr, buf2);
separator = "@";
} else {
if (IN6_IS_ADDR_V4MAPPED(addr))
- _nm_utils_inet4_ntop(((const struct in6_addr *) addr)->s6_addr32[3], buf2);
+ nm_inet4_ntop(((const struct in6_addr *) addr)->s6_addr32[3], buf2);
else
- _nm_utils_inet6_ntop(addr, buf2);
+ nm_inet6_ntop(addr, buf2);
/* Need to scope link-local addresses with %<zone-id>. Before dnsmasq 2.58,
* only '@' was supported as delimiter. Since 2.58, '@' and '%' are
* supported. Due to a bug, since 2.73 only '%' works properly as "server"
diff --git a/src/core/dns/nm-dns-dnsmasq.h b/src/core/dns/nm-dns-dnsmasq.h
index 575b0b263f..98761d3d9f 100644
--- a/src/core/dns/nm-dns-dnsmasq.h
+++ b/src/core/dns/nm-dns-dnsmasq.h
@@ -25,4 +25,6 @@ GType nm_dns_dnsmasq_get_type(void);
NMDnsPlugin *nm_dns_dnsmasq_new(void);
+void nm_dnsmasq_kill_external(void);
+
#endif /* __NETWORKMANAGER_DNS_DNSMASQ_H__ */
diff --git a/src/core/dns/nm-dns-manager.c b/src/core/dns/nm-dns-manager.c
index 1e54452aa4..7b44e090c6 100644
--- a/src/core/dns/nm-dns-manager.c
+++ b/src/core/dns/nm-dns-manager.c
@@ -552,7 +552,7 @@ add_dns_domains(GPtrArray *array,
static void
merge_one_l3cd(NMResolvConfData *rc, int addr_family, int ifindex, const NML3ConfigData *l3cd)
{
- char buf[NM_UTILS_INET_ADDRSTRLEN + 50];
+ char buf[NM_INET_ADDRSTRLEN + 50];
gboolean has_trust_ad;
guint num_nameservers;
guint num;
@@ -569,11 +569,11 @@ merge_one_l3cd(NMResolvConfData *rc, int addr_family, int ifindex, const NML3Con
addr = nm_ip_addr_from_packed_array(addr_family, nameservers, i);
if (addr_family == AF_INET)
- nm_utils_inet_ntop(addr_family, addr, buf);
+ nm_inet_ntop(addr_family, addr, buf);
else if (IN6_IS_ADDR_V4MAPPED(addr))
- _nm_utils_inet4_ntop(addr->addr6.s6_addr32[3], buf);
+ nm_inet4_ntop(addr->addr6.s6_addr32[3], buf);
else {
- _nm_utils_inet6_ntop(&addr->addr6, buf);
+ nm_inet6_ntop(&addr->addr6, buf);
if (IN6_IS_ADDR_LINKLOCAL(addr)) {
const char *ifname;
@@ -619,7 +619,7 @@ merge_one_l3cd(NMResolvConfData *rc, int addr_family, int ifindex, const NML3Con
nis_servers = nm_l3_config_data_get_nis_servers(l3cd, &num);
for (i = 0; i < num; i++)
- add_string_item(rc->nis_servers, _nm_utils_inet4_ntop(nis_servers[i], buf), TRUE);
+ add_string_item(rc->nis_servers, nm_inet4_ntop(nis_servers[i], buf), TRUE);
if ((nis_domain = nm_l3_config_data_get_nis_domain(l3cd))) {
/* FIXME: handle multiple domains */
@@ -1258,7 +1258,7 @@ merge_global_dns_config(NMResolvConfData *rc, NMGlobalDnsConfig *global_conf)
static const char *
get_nameserver_list(int addr_family, const NML3ConfigData *l3cd, NMStrBuf *tmp_strbuf)
{
- char buf[NM_UTILS_INET_ADDRSTRLEN];
+ char buf[NM_INET_ADDRSTRLEN];
guint num;
guint i;
gconstpointer nameservers;
@@ -1270,7 +1270,7 @@ get_nameserver_list(int addr_family, const NML3ConfigData *l3cd, NMStrBuf *tmp_s
const NMIPAddr *addr;
addr = nm_ip_addr_from_packed_array(addr_family, nameservers, i);
- nm_utils_inet_ntop(addr_family, addr->addr_ptr, buf);
+ nm_inet_ntop(addr_family, addr->addr_ptr, buf);
if (i > 0)
nm_str_buf_append_c(tmp_strbuf, ' ');
nm_str_buf_append(tmp_strbuf, buf);
@@ -2083,8 +2083,7 @@ nm_dns_manager_set_hostname(NMDnsManager *self, const char *hostname, gboolean s
/* Certain hostnames we don't want to include in resolv.conf 'searches' */
if (hostname && nm_utils_is_specific_hostname(hostname)
- && !g_str_has_suffix(hostname, ".in-addr.arpa")
- && !nm_utils_ipaddr_is_valid(AF_UNSPEC, hostname)) {
+ && !g_str_has_suffix(hostname, ".in-addr.arpa") && !nm_inet_is_valid(AF_UNSPEC, hostname)) {
domain = strchr(hostname, '.');
if (domain) {
domain++;
@@ -2506,6 +2505,9 @@ again:
self);
}
+ if (!NM_IS_DNS_DNSMASQ(priv->plugin))
+ nm_dnsmasq_kill_external();
+
_update_pending_maybe_changed(self);
g_object_thaw_notify(G_OBJECT(self));
@@ -2625,7 +2627,7 @@ _get_config_variant(NMDnsManager *self)
guint num_domains;
guint num_searches;
guint i;
- char buf[NM_UTILS_INET_ADDRSTRLEN];
+ char buf[NM_INET_ADDRSTRLEN];
const char *ifname;
gconstpointer nameservers;
@@ -2642,7 +2644,7 @@ _get_config_variant(NMDnsManager *self)
addr = nm_ip_addr_from_packed_array(ip_data->addr_family, nameservers, i);
g_variant_builder_add(&strv_builder,
"s",
- nm_utils_inet_ntop(ip_data->addr_family, addr, buf));
+ nm_inet_ntop(ip_data->addr_family, addr, buf));
}
g_variant_builder_add(&entry_builder,
"{sv}",
diff --git a/src/core/dns/nm-dns-systemd-resolved.c b/src/core/dns/nm-dns-systemd-resolved.c
index e0b94647f5..5a22fa25ca 100644
--- a/src/core/dns/nm-dns-systemd-resolved.c
+++ b/src/core/dns/nm-dns-systemd-resolved.c
@@ -1066,7 +1066,7 @@ nm_dns_systemd_resolved_resolve_address(NMDnsSystemdResolved
{
NMDnsSystemdResolvedPrivate *priv = NM_DNS_SYSTEMD_RESOLVED_GET_PRIVATE(self);
NMDnsSystemdResolvedResolveHandle *handle;
- char addr_str[NM_UTILS_INET_ADDRSTRLEN];
+ char addr_str[NM_INET_ADDRSTRLEN];
g_return_val_if_fail(NM_IS_DNS_SYSTEMD_RESOLVED(self), NULL);
nm_assert_addr_family(addr_family);
@@ -1092,7 +1092,7 @@ nm_dns_systemd_resolved_resolve_address(NMDnsSystemdResolved
_LOG2T(handle,
"resolve-address(ifindex=%d, %s, flags=%" G_GINT64_MODIFIER "x): new request",
handle->r_address.ifindex,
- nm_utils_inet_ntop(handle->r_address.addr_family, &handle->r_address.addr, addr_str),
+ nm_inet_ntop(handle->r_address.addr_family, &handle->r_address.addr, addr_str),
handle->r_address.flags);
_resolve_start(self, handle);
diff --git a/src/core/dnsmasq/nm-dnsmasq-manager.c b/src/core/dnsmasq/nm-dnsmasq-manager.c
index be463da3e8..2cdfb29643 100644
--- a/src/core/dnsmasq/nm-dnsmasq-manager.c
+++ b/src/core/dnsmasq/nm-dnsmasq-manager.c
@@ -147,7 +147,7 @@ create_dm_cmd_line(const char *iface,
*/
nm_strv_ptrarray_add_string_dup(cmd, "--strict-order");
- _nm_utils_inet4_ntop(listen_address->address, listen_address_s);
+ nm_inet4_ntop(listen_address->address, listen_address_s);
nm_strv_ptrarray_add_string_concat(cmd, "--listen-address=", listen_address_s);
@@ -169,7 +169,7 @@ create_dm_cmd_line(const char *iface,
g_string_append(s, "--dhcp-option=option:dns-server");
for (i = 0; i < n; i++) {
g_string_append_c(s, ',');
- g_string_append(s, _nm_utils_inet4_ntop(ipv4arr[i], sbuf_addr));
+ g_string_append(s, nm_inet4_ntop(ipv4arr[i], sbuf_addr));
}
nm_strv_ptrarray_take_gstring(cmd, &s);
}
diff --git a/src/core/dnsmasq/nm-dnsmasq-utils.c b/src/core/dnsmasq/nm-dnsmasq-utils.c
index 7f79987830..69424d74a6 100644
--- a/src/core/dnsmasq/nm-dnsmasq-utils.c
+++ b/src/core/dnsmasq/nm-dnsmasq-utils.c
@@ -50,7 +50,7 @@ nm_dnsmasq_utils_get_range(const NMPlatformIP4Address *addr,
prefix = 24;
}
- netmask = _nm_utils_ip4_prefix_to_netmask(prefix);
+ netmask = nm_ip4_addr_netmask_from_prefix(prefix);
/* treat addresses in host-order from here on. */
netmask = ntohl(netmask);
@@ -96,8 +96,8 @@ nm_dnsmasq_utils_get_range(const NMPlatformIP4Address *addr,
first = htonl(first);
last = htonl(last);
- _nm_utils_inet4_ntop(first, out_first);
- _nm_utils_inet4_ntop(last, out_last);
+ nm_inet4_ntop(first, out_first);
+ nm_inet4_ntop(last, out_last);
return TRUE;
}
diff --git a/src/core/ndisc/nm-lndp-ndisc.c b/src/core/ndisc/nm-lndp-ndisc.c
index 313756a61a..38eacd2a42 100644
--- a/src/core/ndisc/nm-lndp-ndisc.c
+++ b/src/core/ndisc/nm-lndp-ndisc.c
@@ -202,9 +202,7 @@ receive_ra(struct ndp *ndp, struct ndp_msg *msg, gpointer user_data)
r_plen = ndp_msg_opt_prefix_len(msg, offset);
if (r_plen == 0 || r_plen > 128)
continue;
- nm_utils_ip6_address_clear_host_address(&r_network,
- ndp_msg_opt_prefix(msg, offset),
- r_plen);
+ nm_ip6_addr_clear_host_address(&r_network, ndp_msg_opt_prefix(msg, offset), r_plen);
if (IN6_IS_ADDR_UNSPECIFIED(&r_network) || IN6_IS_ADDR_LINKLOCAL(&r_network))
continue;
@@ -244,9 +242,7 @@ receive_ra(struct ndp *ndp, struct ndp_msg *msg, gpointer user_data)
if (plen == 0 || plen > 128)
continue;
- nm_utils_ip6_address_clear_host_address(&network,
- ndp_msg_opt_route_prefix(msg, offset),
- plen);
+ nm_ip6_addr_clear_host_address(&network, ndp_msg_opt_route_prefix(msg, offset), plen);
{
const NMNDiscRoute route = {
diff --git a/src/core/ndisc/nm-ndisc.c b/src/core/ndisc/nm-ndisc.c
index 04b673e51d..ec5a83c622 100644
--- a/src/core/ndisc/nm-ndisc.c
+++ b/src/core/ndisc/nm-ndisc.c
@@ -1233,9 +1233,9 @@ nm_ndisc_dad_failed(NMNDisc *ndisc, const struct in6_addr *address, gboolean emi
NMNDiscAddress *item = &g_array_index(rdata->addresses, NMNDiscAddress, i);
if (IN6_ARE_ADDR_EQUAL(&item->address, address)) {
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
- _LOGD("DAD failed for discovered address %s", _nm_utils_inet6_ntop(address, sbuf));
+ _LOGD("DAD failed for discovered address %s", nm_inet6_ntop(address, sbuf));
changed = TRUE;
if (!complete_address(ndisc, item)) {
g_array_remove_index(rdata->addresses, i);
@@ -1278,7 +1278,7 @@ _config_changed_log(NMNDisc *ndisc, NMNDiscConfigMap changed)
NMNDiscDataInternal *rdata;
guint i;
char changedstr[CONFIG_MAP_MAX_STR];
- char addrstr[NM_UTILS_INET_ADDRSTRLEN];
+ char addrstr[NM_INET_ADDRSTRLEN];
char str_pref[35];
char str_exp[100];
gint64 now_msec;
@@ -1306,7 +1306,7 @@ _config_changed_log(NMNDisc *ndisc, NMNDiscConfigMap changed)
const NMNDiscGateway *gateway = &g_array_index(rdata->gateways, NMNDiscGateway, i);
_LOGD(" gateway %s pref %s exp %s",
- _nm_utils_inet6_ntop(&gateway->address, addrstr),
+ nm_inet6_ntop(&gateway->address, addrstr),
nm_icmpv6_router_pref_to_string(gateway->preference, str_pref, sizeof(str_pref)),
get_exp(str_exp, now_msec, gateway));
}
@@ -1314,17 +1314,17 @@ _config_changed_log(NMNDisc *ndisc, NMNDiscConfigMap changed)
const NMNDiscAddress *address = &g_array_index(rdata->addresses, NMNDiscAddress, i);
_LOGD(" address %s exp %s",
- _nm_utils_inet6_ntop(&address->address, addrstr),
+ nm_inet6_ntop(&address->address, addrstr),
get_exp(str_exp, now_msec, address));
}
for (i = 0; i < rdata->routes->len; i++) {
const NMNDiscRoute *route = &g_array_index(rdata->routes, NMNDiscRoute, i);
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
_LOGD(" route %s/%u via %s pref %s exp %s",
- _nm_utils_inet6_ntop(&route->network, addrstr),
+ nm_inet6_ntop(&route->network, addrstr),
(guint) route->plen,
- _nm_utils_inet6_ntop(&route->gateway, sbuf),
+ nm_inet6_ntop(&route->gateway, sbuf),
nm_icmpv6_router_pref_to_string(route->preference, str_pref, sizeof(str_pref)),
get_exp(str_exp, now_msec, route));
}
@@ -1333,7 +1333,7 @@ _config_changed_log(NMNDisc *ndisc, NMNDiscConfigMap changed)
&g_array_index(rdata->dns_servers, NMNDiscDNSServer, i);
_LOGD(" dns_server %s exp %s",
- _nm_utils_inet6_ntop(&dns_server->address, addrstr),
+ nm_inet6_ntop(&dns_server->address, addrstr),
get_exp(str_exp, now_msec, dns_server));
}
for (i = 0; i < rdata->dns_domains->len; i++) {
diff --git a/src/core/nm-config-data.c b/src/core/nm-config-data.c
index 0f512e3865..fd98797186 100644
--- a/src/core/nm-config-data.c
+++ b/src/core/nm-config-data.c
@@ -1168,8 +1168,7 @@ load_global_dns(GKeyFile *keyfile, gboolean internal)
if (strv) {
nm_strv_cleanup(strv, TRUE, TRUE, TRUE);
for (i = 0, j = 0; strv[i]; i++) {
- if (nm_utils_ipaddr_is_valid(AF_INET, strv[i])
- || nm_utils_ipaddr_is_valid(AF_INET6, strv[i]))
+ if (nm_inet_is_valid(AF_INET, strv[i]) || nm_inet_is_valid(AF_INET6, strv[i]))
strv[j++] = strv[i];
else
g_free(strv[i]);
@@ -1305,8 +1304,7 @@ global_dns_domain_from_dbus(char *name, GVariant *variant)
strv = g_variant_dup_strv(val, NULL);
nm_strv_cleanup(strv, TRUE, TRUE, TRUE);
for (i = 0, j = 0; strv && strv[i]; i++) {
- if (nm_utils_ipaddr_is_valid(AF_INET, strv[i])
- || nm_utils_ipaddr_is_valid(AF_INET6, strv[i]))
+ if (nm_inet_is_valid(AF_INET, strv[i]) || nm_inet_is_valid(AF_INET6, strv[i]))
strv[j++] = strv[i];
else
g_free(strv[i]);
diff --git a/src/core/nm-connectivity.c b/src/core/nm-connectivity.c
index 25ac3c7f8c..5bfae71a29 100644
--- a/src/core/nm-connectivity.c
+++ b/src/core/nm-connectivity.c
@@ -805,7 +805,7 @@ system_resolver_resolve_cb(GObject *source_object, GAsyncResult *res, gpointer u
for (iter = list; iter; iter = iter->next) {
GInetAddress *a = iter->data;
- char str_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char str_addr[NM_INET_ADDRSTRLEN];
int addr_family;
switch (g_inet_address_get_family(a)) {
@@ -830,7 +830,7 @@ system_resolver_resolve_cb(GObject *source_object, GAsyncResult *res, gpointer u
nm_str_buf_append_c(&strbuf_hosts, ',');
nm_str_buf_append(&strbuf_hosts,
- nm_utils_inet_ntop(addr_family, g_inet_address_to_bytes(a), str_addr));
+ nm_inet_ntop(addr_family, g_inet_address_to_bytes(a), str_addr));
next:;
}
@@ -905,7 +905,7 @@ systemd_resolved_resolve_cb(GObject *object, GAsyncResult *res, gpointer user_da
for (i = 0; i < no_addresses; i++) {
gs_unref_variant GVariant *address = NULL;
- char str_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char str_addr[NM_INET_ADDRSTRLEN];
const guchar *address_buf;
g_variant_get_child(addresses, i, "(ii@ay)", &ifindex, &addr_family, &address);
@@ -928,7 +928,7 @@ systemd_resolved_resolve_cb(GObject *object, GAsyncResult *res, gpointer user_da
} else
nm_str_buf_append_c(&strbuf_hosts, ',');
- nm_str_buf_append(&strbuf_hosts, nm_utils_inet_ntop(addr_family, address_buf, str_addr));
+ nm_str_buf_append(&strbuf_hosts, nm_inet_ntop(addr_family, address_buf, str_addr));
}
if (strbuf_hosts.len == 0) {
_LOG2D("systemd-resolve returned no usable IPv%c addresses",
diff --git a/src/core/nm-core-utils.c b/src/core/nm-core-utils.c
index 480e9b28f0..0d325f0fe1 100644
--- a/src/core/nm-core-utils.c
+++ b/src/core/nm-core-utils.c
@@ -4186,7 +4186,7 @@ nm_utils_get_reverse_dns_domains_ip_6(const struct in6_addr *ip, guint8 plen, GP
return;
memcpy(&addr, ip, sizeof(struct in6_addr));
- nm_utils_ip6_address_clear_host_address(&addr, NULL, plen);
+ nm_ip6_addr_clear_host_address(&addr, NULL, plen);
/* Number of nibbles to include in domains */
nibbles = (plen - 1) / 4 + 1;
diff --git a/src/core/nm-core-utils.h b/src/core/nm-core-utils.h
index d1a62a607f..5852bff33c 100644
--- a/src/core/nm-core-utils.h
+++ b/src/core/nm-core-utils.h
@@ -112,7 +112,7 @@ nm_hash_update_in6addr_prefix(NMHashState *h, const struct in6_addr *addr, guint
nm_assert(addr);
- nm_utils_ip6_address_clear_host_address(&a, addr, plen);
+ nm_ip6_addr_clear_host_address(&a, addr, plen);
/* we don't hash plen itself. The caller may want to do that.*/
nm_hash_update_in6addr(h, &a);
}
diff --git a/src/core/nm-firewall-utils.c b/src/core/nm-firewall-utils.c
index 1311f50399..54e3f429aa 100644
--- a/src/core/nm-firewall-utils.c
+++ b/src/core/nm-firewall-utils.c
@@ -50,12 +50,12 @@ _share_iptables_subnet_to_str(char buf[static _SHARE_IPTABLES_SUBNET_TO_STR
in_addr_t netmask;
int l;
- netmask = _nm_utils_ip4_prefix_to_netmask(plen);
+ netmask = nm_ip4_addr_netmask_from_prefix(plen);
l = g_snprintf(buf,
_SHARE_IPTABLES_SUBNET_TO_STR_LEN,
"%s/%u",
- _nm_utils_inet4_ntop(addr & netmask, buf_addr),
+ nm_inet4_ntop(addr & netmask, buf_addr),
plen);
nm_assert(l < _SHARE_IPTABLES_SUBNET_TO_STR_LEN);
return buf;
diff --git a/src/core/nm-ip-config.c b/src/core/nm-ip-config.c
index b191b54bb2..12f4fadff0 100644
--- a/src/core/nm-ip-config.c
+++ b/src/core/nm-ip-config.c
@@ -90,7 +90,7 @@ get_property_ip(GObject *object, guint prop_id, GValue *value, GParamSpec *pspec
NMIPConfig *self = NM_IP_CONFIG(object);
NMIPConfigPrivate *priv = NM_IP_CONFIG_GET_PRIVATE(self);
const int addr_family = nm_ip_config_get_addr_family(self);
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
const char *const *strv;
guint len;
int v_i;
@@ -108,7 +108,7 @@ get_property_ip(GObject *object, guint prop_id, GValue *value, GParamSpec *pspec
NMP_OBJECT_CAST_IP_ROUTE(priv->v_gateway.best_default_route));
g_value_set_variant(
value,
- g_variant_new_string(nm_utils_inet_ntop(addr_family, gateway, sbuf_addr)));
+ g_variant_new_string(nm_inet_ntop(addr_family, gateway, sbuf_addr)));
} else
g_value_set_variant(value, nm_g_variant_singleton_s_empty());
break;
@@ -333,7 +333,7 @@ get_property_ip4(GObject *object, guint prop_id, GValue *value, GParamSpec *pspe
{
NMIPConfig *self = NM_IP_CONFIG(object);
NMIPConfigPrivate *priv = NM_IP_CONFIG_GET_PRIVATE(self);
- char addr_str[NM_UTILS_INET_ADDRSTRLEN];
+ char addr_str[NM_INET_ADDRSTRLEN];
GVariantBuilder builder;
const in_addr_t *addrs;
guint len;
@@ -361,7 +361,7 @@ get_property_ip4(GObject *object, guint prop_id, GValue *value, GParamSpec *pspe
for (i = 0; i < len; i++) {
GVariantBuilder nested_builder;
- _nm_utils_inet4_ntop(addrs[i], addr_str);
+ nm_inet4_ntop(addrs[i], addr_str);
g_variant_builder_init(&nested_builder, G_VARIANT_TYPE("a{sv}"));
g_variant_builder_add(&nested_builder,
@@ -387,7 +387,7 @@ get_property_ip4(GObject *object, guint prop_id, GValue *value, GParamSpec *pspe
else {
g_variant_builder_init(&builder, G_VARIANT_TYPE("as"));
for (i = 0; i < len; i++)
- g_variant_builder_add(&builder, "s", _nm_utils_inet4_ntop(addrs[i], addr_str));
+ g_variant_builder_add(&builder, "s", nm_inet4_ntop(addrs[i], addr_str));
g_value_take_variant(value, g_variant_builder_end(&builder));
}
break;
diff --git a/src/core/nm-l3-config-data.c b/src/core/nm-l3-config-data.c
index bcd0b62a84..42467d50e8 100644
--- a/src/core/nm-l3-config-data.c
+++ b/src/core/nm-l3-config-data.c
@@ -352,7 +352,7 @@ nm_l3_config_data_log(const NML3ConfigData *self,
NMLogDomain log_domain)
{
char sbuf[NM_UTILS_TO_STRING_BUFFER_SIZE];
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
int IS_IPv4;
guint i;
@@ -484,9 +484,9 @@ nm_l3_config_data_log(const NML3ConfigData *self,
_L("nameserver%c[%u]: %s",
nm_utils_addr_family_to_char(addr_family),
i,
- nm_utils_inet_ntop(addr_family,
- _garray_inaddr_at(self->nameservers_x[IS_IPv4], IS_IPv4, i),
- sbuf_addr));
+ nm_inet_ntop(addr_family,
+ _garray_inaddr_at(self->nameservers_x[IS_IPv4], IS_IPv4, i),
+ sbuf_addr));
}
for (i = 0; i < nm_g_ptr_array_len(self->domains_x[IS_IPv4]); i++) {
@@ -514,12 +514,12 @@ nm_l3_config_data_log(const NML3ConfigData *self,
for (i = 0; i < nm_g_array_len(self->wins); i++) {
_L("wins[%u]: %s",
i,
- _nm_utils_inet4_ntop(g_array_index(self->wins, in_addr_t, i), sbuf_addr));
+ nm_inet4_ntop(g_array_index(self->wins, in_addr_t, i), sbuf_addr));
}
for (i = 0; i < nm_g_array_len(self->nis_servers); i++) {
_L("nis-server[%u]: %s",
i,
- _nm_utils_inet4_ntop(g_array_index(self->nis_servers, in_addr_t, i), sbuf_addr));
+ nm_inet4_ntop(g_array_index(self->nis_servers, in_addr_t, i), sbuf_addr));
}
if (self->nis_domain)
_L("nis-domain: %s", self->nis_domain->str);
@@ -621,8 +621,7 @@ nm_l3_config_data_log(const NML3ConfigData *self,
static gboolean
_route_valid_4(const NMPlatformIP4Route *r)
{
- return r && r->plen <= 32
- && r->network == nm_utils_ip4_address_clear_host_address(r->network, r->plen);
+ return r && r->plen <= 32 && r->network == nm_ip4_addr_clear_host_address(r->network, r->plen);
}
static gboolean
@@ -632,7 +631,7 @@ _route_valid_6(const NMPlatformIP6Route *r)
return r && r->plen <= 128
&& (memcmp(&r->network,
- nm_utils_ip6_address_clear_host_address(&n, &r->network, r->plen),
+ nm_ip6_addr_clear_host_address(&n, &r->network, r->plen),
sizeof(n))
== 0);
}
@@ -2185,8 +2184,7 @@ _dedup_multi_index_cmp(const NML3ConfigData *a,
NM_CMP_DIRECT(ra.metric, rb.metric);
NM_CMP_DIRECT(ra.plen, rb.plen);
- NM_CMP_RETURN_DIRECT(
- nm_utils_ip4_address_same_prefix_cmp(ra.network, rb.network, ra.plen));
+ NM_CMP_RETURN_DIRECT(nm_ip4_addr_same_prefix_cmp(ra.network, rb.network, ra.plen));
break;
}
case NMP_OBJECT_TYPE_IP6_ROUTE:
@@ -2197,7 +2195,7 @@ _dedup_multi_index_cmp(const NML3ConfigData *a,
NM_CMP_DIRECT(ra.metric, rb.metric);
NM_CMP_DIRECT(ra.plen, rb.plen);
NM_CMP_RETURN_DIRECT(
- nm_utils_ip6_address_same_prefix_cmp(&ra.network, &rb.network, ra.plen));
+ nm_ip6_addr_same_prefix_cmp(&ra.network, &rb.network, ra.plen));
break;
}
default:
@@ -2298,8 +2296,7 @@ nm_l3_config_data_cmp_full(const NML3ConfigData *a,
NM_CMP_DIRECT(ra.metric, rb.metric);
NM_CMP_DIRECT(ra.plen, rb.plen);
- NM_CMP_RETURN_DIRECT(
- nm_utils_ip4_address_same_prefix_cmp(ra.network, rb.network, ra.plen));
+ NM_CMP_RETURN_DIRECT(nm_ip4_addr_same_prefix_cmp(ra.network, rb.network, ra.plen));
} else {
NMPlatformIP6Route ra = def_route_a->ip6_route;
NMPlatformIP6Route rb = def_route_b->ip6_route;
@@ -2307,7 +2304,7 @@ nm_l3_config_data_cmp_full(const NML3ConfigData *a,
NM_CMP_DIRECT(ra.metric, rb.metric);
NM_CMP_DIRECT(ra.plen, rb.plen);
NM_CMP_RETURN_DIRECT(
- nm_utils_ip6_address_same_prefix_cmp(&ra.network, &rb.network, ra.plen));
+ nm_ip6_addr_same_prefix_cmp(&ra.network, &rb.network, ra.plen));
}
}
@@ -2425,10 +2422,7 @@ _data_get_direct_route_for_host(const NML3ConfigData *self,
if (nm_platform_route_table_uncoerce(item->rx.table_coerced, TRUE) != route_table)
continue;
- if (!nm_utils_ip_address_same_prefix(addr_family,
- host,
- item->rx.network_ptr,
- item->rx.plen))
+ if (!nm_ip_addr_same_prefix(addr_family, host, item->rx.network_ptr, item->rx.plen))
continue;
if (best_route && best_route->rx.metric <= item->rx.metric)
@@ -2478,9 +2472,9 @@ nm_l3_config_data_get_blacklisted_ip4_routes(const NML3ConfigData *self, gboolea
if (my_addr->plen == 0)
continue;
- network_4 = nm_utils_ip4_address_clear_host_address(my_addr->peer_address, my_addr->plen);
+ network_4 = nm_ip4_addr_clear_host_address(my_addr->peer_address, my_addr->plen);
- if (nm_utils_ip4_address_is_zeronet(network_4)) {
+ if (nm_ip4_addr_is_zeronet(network_4)) {
/* Kernel doesn't add device-routes for destinations that
* start with 0.x.y.z. Skip them. */
continue;
@@ -2672,9 +2666,9 @@ nm_l3_config_data_add_dependent_device_routes(NML3ConfigData *self,
a6 = &addr_src->a6.peer_address;
plen = 128;
} else {
- a6 = nm_utils_ip6_address_clear_host_address(&a6_stack,
- &addr_src->a6.address,
- addr_src->a6.plen);
+ a6 = nm_ip6_addr_clear_host_address(&a6_stack,
+ &addr_src->a6.address,
+ addr_src->a6.plen);
plen = addr_src->a6.plen;
}
@@ -2819,7 +2813,7 @@ _init_from_connection_ip(NML3ConfigData *self, int addr_family, NMConnection *co
plen = nm_ip_route_get_prefix(s_route);
- nm_utils_ipx_address_clear_host_address(addr_family, &network_bin, &network_bin, plen);
+ nm_ip_addr_clear_host_address(addr_family, &network_bin, &network_bin, plen);
if (IS_IPv4) {
r.r4 = (NMPlatformIP4Route){
@@ -2854,7 +2848,7 @@ _init_from_connection_ip(NML3ConfigData *self, int addr_family, NMConnection *co
NMIPAddr ip;
s = nm_setting_ip_config_get_dns(s_ip, i);
- if (!nm_utils_parse_inaddr_bin(addr_family, s, NULL, &ip))
+ if (!nm_inet_parse_bin(addr_family, s, NULL, &ip))
continue;
nm_l3_config_data_add_nameserver(self, addr_family, &ip);
}
diff --git a/src/core/nm-l3-ipv4ll.c b/src/core/nm-l3-ipv4ll.c
index 3fc1e165f5..ec871befc7 100644
--- a/src/core/nm-l3-ipv4ll.c
+++ b/src/core/nm-l3-ipv4ll.c
@@ -104,17 +104,17 @@ NM_UTILS_ENUM2STR_DEFINE(nm_l3_ipv4ll_state_to_string,
/*****************************************************************************/
-#define _ASSERT(self) \
- G_STMT_START \
- { \
- NML3IPv4LL *const _self = (self); \
- \
- nm_assert(NM_IS_L3_IPV4LL(_self)); \
- if (NM_MORE_ASSERTS > 5) { \
- nm_assert(_self->addr == 0u || nm_utils_ip4_address_is_link_local(_self->addr)); \
- nm_assert(!_self->l3cd || NM_IS_L3_CONFIG_DATA(_self->l3cd)); \
- } \
- } \
+#define _ASSERT(self) \
+ G_STMT_START \
+ { \
+ NML3IPv4LL *const _self = (self); \
+ \
+ nm_assert(NM_IS_L3_IPV4LL(_self)); \
+ if (NM_MORE_ASSERTS > 5) { \
+ nm_assert(_self->addr == 0u || nm_ip4_addr_is_link_local(_self->addr)); \
+ nm_assert(!_self->l3cd || NM_IS_L3_CONFIG_DATA(_self->l3cd)); \
+ } \
+ } \
G_STMT_END
/*****************************************************************************/
@@ -290,7 +290,7 @@ _ip4_address_is_link_local(const NMPlatformIP4Address *a)
{
nm_assert(a);
- return nm_utils_ip4_address_is_link_local(a->address) && a->plen == ADDR_IPV4LL_PREFIX_LEN
+ return nm_ip4_addr_is_link_local(a->address) && a->plen == ADDR_IPV4LL_PREFIX_LEN
&& a->address == a->peer_address;
}
@@ -322,7 +322,7 @@ _l3cd_config_create(int ifindex, in_addr_t addr, NMDedupMultiIndex *multi_idx)
{
nm_auto_unref_l3cd_init NML3ConfigData *l3cd = NULL;
- nm_assert(nm_utils_ip4_address_is_link_local(addr));
+ nm_assert(nm_ip4_addr_is_link_local(addr));
nm_assert(ifindex > 0);
nm_assert(multi_idx);
@@ -382,7 +382,7 @@ static void
_ipv4ll_addrgen(NML3IPv4LL *self, gboolean generate_new_addr)
{
CSipHash state;
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
gboolean seed_changed = FALSE;
in_addr_t addr_new;
guint64 h;
@@ -459,7 +459,7 @@ _ipv4ll_addrgen(NML3IPv4LL *self, gboolean generate_new_addr)
if (!seed_changed && !generate_new_addr) {
/* neither did the caller request a new address, nor was the seed changed. The current
* address is still to be used. */
- nm_assert(nm_utils_ip4_address_is_link_local(self->addr));
+ nm_assert(nm_ip4_addr_is_link_local(self->addr));
return;
}
@@ -492,9 +492,9 @@ gen_addr:
if (self->addr == addr_new || NM_IN_SET(ntohl(addr_new) & 0x0000FF00u, 0x0000u, 0xFF00u))
goto gen_addr;
- nm_assert(nm_utils_ip4_address_is_link_local(addr_new));
+ nm_assert(nm_ip4_addr_is_link_local(addr_new));
- _LOGT("addr-gen: set address %s", _nm_utils_inet4_ntop(addr_new, sbuf_addr));
+ _LOGT("addr-gen: set address %s", nm_inet4_ntop(addr_new, sbuf_addr));
self->addr = addr_new;
}
@@ -549,7 +549,7 @@ static void
_l3cd_config_add(NML3IPv4LL *self)
{
nm_auto_unref_l3cd const NML3ConfigData *l3cd = NULL;
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
gboolean changed;
_ASSERT(self);
@@ -571,7 +571,7 @@ _l3cd_config_add(NML3IPv4LL *self)
self->l3cd_timeout_msec_changed = FALSE;
_LOGT("add l3cd config with %s (acd-timeout %u msec%s)",
- _nm_utils_inet4_ntop(self->addr, sbuf_addr),
+ nm_inet4_ntop(self->addr, sbuf_addr),
self->reg_timeout_msec,
changed ? "" : " changed");
@@ -639,7 +639,7 @@ _ipv4ll_platform_ip4_address_lookup(NML3IPv4LL *self, in_addr_t addr)
if (addr == 0u)
return NULL;
- nm_assert(nm_utils_ip4_address_is_link_local(addr));
+ nm_assert(nm_ip4_addr_is_link_local(addr));
pladdr = nm_platform_ip4_address_get(nm_l3_ipv4ll_get_platform(self),
nm_l3_ipv4ll_get_ifindex(self),
@@ -658,7 +658,7 @@ _ipv4ll_l3cfg_get_acd_addr_info(NML3IPv4LL *self, in_addr_t addr)
if (addr == 0u)
return NULL;
- nm_assert(nm_utils_ip4_address_is_link_local(addr));
+ nm_assert(nm_ip4_addr_is_link_local(addr));
return nm_l3cfg_get_acd_addr_info(self->l3cfg, addr);
}
@@ -766,7 +766,7 @@ _ipv4ll_set_timed_out_update(NML3IPv4LL *self, TimedOutState new_state)
static gboolean
_ipv4ll_set_state(NML3IPv4LL *self, NML3IPv4LLState state)
{
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
char sbuf100[100];
if (self->state == state)
@@ -775,7 +775,7 @@ _ipv4ll_set_state(NML3IPv4LL *self, NML3IPv4LLState state)
self->notify_on_idle = TRUE;
_LOGT("state: set state %s (addr=%s)",
nm_l3_ipv4ll_state_to_string(state, sbuf100, sizeof(sbuf100)),
- _nm_utils_inet4_ntop(self->addr, sbuf_addr));
+ nm_inet4_ntop(self->addr, sbuf_addr));
return TRUE;
}
diff --git a/src/core/nm-l3-ipv6ll.c b/src/core/nm-l3-ipv6ll.c
index 2640c07554..1368e7fa4f 100644
--- a/src/core/nm-l3-ipv6ll.c
+++ b/src/core/nm-l3-ipv6ll.c
@@ -216,7 +216,7 @@ _emit_changed_on_idle_cb(gpointer user_data)
_LOGT("emit changed signal (state=%s%s%s)",
nm_l3_ipv6ll_state_to_string(state),
lladdr ? ", " : "",
- lladdr ? _nm_utils_inet6_ntop(lladdr, sbuf) : "");
+ lladdr ? nm_inet6_ntop(lladdr, sbuf) : "");
self->notify_fcn(self, state, lladdr, self->user_data);
@@ -525,14 +525,14 @@ _check(NML3IPv6LL *self)
if (_pladdr_is_ll_tentative(pladdr)) {
if (_set_cur_lladdr_obj(self, NM_L3_IPV6LL_STATE_DAD_IN_PROGRESS, pladdr)) {
_LOGT("changed: waiting for address %s to complete DAD",
- _nm_utils_inet6_ntop(&self->cur_lladdr, sbuf));
+ nm_inet6_ntop(&self->cur_lladdr, sbuf));
_lladdr_handle_changed(self);
}
return;
}
if (_set_cur_lladdr_obj(self, NM_L3_IPV6LL_STATE_READY, pladdr)) {
- _LOGT("changed: address %s is ready", _nm_utils_inet6_ntop(&self->cur_lladdr, sbuf));
+ _LOGT("changed: address %s is ready", nm_inet6_ntop(&self->cur_lladdr, sbuf));
_lladdr_handle_changed(self);
}
return;
@@ -545,9 +545,9 @@ _check(NML3IPv6LL *self)
NM_IN_SET(self->state, NM_L3_IPV6LL_STATE_DAD_IN_PROGRESS, NM_L3_IPV6LL_STATE_READY));
if (self->state == NM_L3_IPV6LL_STATE_DAD_IN_PROGRESS)
_LOGT("changed: address %s did not complete DAD",
- _nm_utils_inet6_ntop(&self->cur_lladdr, sbuf));
+ nm_inet6_ntop(&self->cur_lladdr, sbuf));
else {
- _LOGT("changed: address %s is gone", _nm_utils_inet6_ntop(&self->cur_lladdr, sbuf));
+ _LOGT("changed: address %s is gone", nm_inet6_ntop(&self->cur_lladdr, sbuf));
}
/* reset the state here, so that we are sure that the following
@@ -579,8 +579,7 @@ _check(NML3IPv6LL *self)
* If that does not happen within timeout, we assume that this address failed DAD. */
self->wait_for_addr_source = nm_g_timeout_add_source(2000, _wait_for_addr_timeout_cb, self);
if (_set_cur_lladdr_bin(self, NM_L3_IPV6LL_STATE_DAD_IN_PROGRESS, &lladdr)) {
- _LOGT("changed: starting DAD for address %s",
- _nm_utils_inet6_ntop(&self->cur_lladdr, sbuf));
+ _LOGT("changed: starting DAD for address %s", nm_inet6_ntop(&self->cur_lladdr, sbuf));
_lladdr_handle_changed(self);
}
return;
diff --git a/src/core/nm-l3cfg.c b/src/core/nm-l3cfg.c
index 69ea0d2623..963e381b14 100644
--- a/src/core/nm-l3cfg.c
+++ b/src/core/nm-l3cfg.c
@@ -358,16 +358,16 @@ G_DEFINE_TYPE(NML3Cfg, nm_l3cfg, G_TYPE_OBJECT)
} \
G_STMT_END
-#define _LOGT_acd(acd_data, ...) \
- G_STMT_START \
- { \
- char _sbuf_acd[NM_UTILS_INET_ADDRSTRLEN]; \
- \
- _LOGT("acd[%s, %s]: " _NM_UTILS_MACRO_FIRST(__VA_ARGS__), \
- _nm_utils_inet4_ntop((acd_data)->info.addr, _sbuf_acd), \
- _l3_acd_addr_state_to_string((acd_data)->info.state) \
- _NM_UTILS_MACRO_REST(__VA_ARGS__)); \
- } \
+#define _LOGT_acd(acd_data, ...) \
+ G_STMT_START \
+ { \
+ char _sbuf_acd[NM_INET_ADDRSTRLEN]; \
+ \
+ _LOGT("acd[%s, %s]: " _NM_UTILS_MACRO_FIRST(__VA_ARGS__), \
+ nm_inet4_ntop((acd_data)->info.addr, _sbuf_acd), \
+ _l3_acd_addr_state_to_string((acd_data)->info.state) \
+ _NM_UTILS_MACRO_REST(__VA_ARGS__)); \
+ } \
G_STMT_END
/*****************************************************************************/
@@ -548,7 +548,7 @@ _l3_config_notify_data_to_string(const NML3ConfigNotifyData *notify_data,
char *sbuf,
gsize sbuf_size)
{
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
char sbuf100[100];
char sbufobf[NM_HASH_OBFUSCATE_PTR_STR_BUF_SIZE];
char *s = sbuf;
@@ -577,7 +577,7 @@ _l3_config_notify_data_to_string(const NML3ConfigNotifyData *notify_data,
nm_strbuf_append(&s,
&l,
", addr=%s, state=%s",
- _nm_utils_inet4_ntop(notify_data->acd_event.info.addr, sbuf_addr),
+ nm_inet4_ntop(notify_data->acd_event.info.addr, sbuf_addr),
_l3_acd_addr_state_to_string(notify_data->acd_event.info.state));
break;
case NM_L3_CONFIG_NOTIFY_TYPE_PLATFORM_CHANGE:
@@ -603,7 +603,7 @@ _l3_config_notify_data_to_string(const NML3ConfigNotifyData *notify_data,
&l,
", ipv4ll=" NM_HASH_OBFUSCATE_PTR_FMT "%s%s, state=%s",
NM_HASH_OBFUSCATE_PTR(notify_data->ipv4ll_event.ipv4ll),
- NM_PRINT_FMT_QUOTED2(addr4 != 0, ", addr=", _nm_utils_inet4_ntop(addr4, sbuf_addr), ""),
+ NM_PRINT_FMT_QUOTED2(addr4 != 0, ", addr=", nm_inet4_ntop(addr4, sbuf_addr), ""),
nm_l3_ipv4ll_state_to_string(nm_l3_ipv4ll_get_state(notify_data->ipv4ll_event.ipv4ll),
sbuf100,
sizeof(sbuf100)));
@@ -2230,7 +2230,7 @@ _l3_acd_data_state_change(NML3Cfg *self,
gint64 now_msec;
const char *log_reason;
char sbuf256[256];
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
if (!p_now_msec) {
now_msec = 0;
@@ -2550,7 +2550,7 @@ handle_init:
if (!_l3_acd_data_defendconflict_warning_ratelimited(acd_data, p_now_msec)) {
_LOGI("IPv4 address %s is used on network connected to interface %d%s%s%s from "
"host %s",
- _nm_utils_inet4_ntop(acd_data->info.addr, sbuf_addr),
+ nm_inet4_ntop(acd_data->info.addr, sbuf_addr),
self->priv.ifindex,
NM_PRINT_FMT_QUOTED(self->priv.plobj_next,
" (",
@@ -2565,7 +2565,7 @@ handle_init:
nm_assert(acd_data->info.state == NM_L3_ACD_ADDR_STATE_DEFENDING);
_LOGT_acd(acd_data,
"address %s defended from %s",
- _nm_utils_inet4_ntop(acd_data->info.addr, sbuf_addr),
+ nm_inet4_ntop(acd_data->info.addr, sbuf_addr),
nm_ether_addr_to_string_a(sender_addr));
/* we just log an info message. Nothing else to do. */
return;
@@ -2575,7 +2575,7 @@ handle_init:
_LOGT_acd(acd_data,
"address conflict for %s detected with %s",
- _nm_utils_inet4_ntop(acd_data->info.addr, sbuf_addr),
+ nm_inet4_ntop(acd_data->info.addr, sbuf_addr),
nm_ether_addr_to_string_a(sender_addr));
if (!_l3_acd_data_defendconflict_warning_ratelimited(acd_data, p_now_msec)) {
@@ -2587,7 +2587,7 @@ handle_init:
NMP_OBJECT_CAST_LINK(self->priv.plobj_next)->name,
")",
""),
- _nm_utils_inet4_ntop(acd_data->info.addr, sbuf_addr),
+ nm_inet4_ntop(acd_data->info.addr, sbuf_addr),
nm_ether_addr_to_string_a(sender_addr));
}
@@ -4371,9 +4371,9 @@ _l3_commit_mptcp_af(NML3Cfg *self,
default:
if (IS_IPv4) {
/* We take all addresses, including rfc1918 private addresses
- * (nm_utils_ip_is_site_local()). */
+ * (nm_ip_addr_is_site_local()). */
} else {
- if (nm_utils_ip6_is_ula(&addr->a6.address)) {
+ if (nm_ip6_addr_is_ula(&addr->a6.address)) {
/* Exclude unique local IPv6 addresses fc00::/7. */
goto skip_addr;
} else {
diff --git a/src/core/nm-netns.c b/src/core/nm-netns.c
index 5ee6315292..81b7e2fc29 100644
--- a/src/core/nm-netns.c
+++ b/src/core/nm-netns.c
@@ -254,7 +254,7 @@ nm_netns_shared_ip_reserve(NMNetns *self)
NMNetnsSharedIPHandle *handle;
const in_addr_t addr_start = ntohl(0x0a2a0001u); /* 10.42.0.1 */
in_addr_t addr;
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
/* Find an unused address in the 10.42.x.x range */
@@ -284,10 +284,10 @@ nm_netns_shared_ip_reserve(NMNetns *self)
if (count > 0xFFu) {
if (handle->_ref_count == 1) {
_LOGE("shared-ip4: ran out of shared IP addresses. Reuse %s/24",
- _nm_utils_inet4_ntop(handle->addr, sbuf_addr));
+ nm_inet4_ntop(handle->addr, sbuf_addr));
} else {
_LOGD("shared-ip4: reserved IP address range %s/24 (duplicate)",
- _nm_utils_inet4_ntop(handle->addr, sbuf_addr));
+ nm_inet4_ntop(handle->addr, sbuf_addr));
}
handle->_ref_count++;
return handle;
@@ -304,8 +304,7 @@ nm_netns_shared_ip_reserve(NMNetns *self)
g_hash_table_add(priv->shared_ips, handle);
- _LOGD("shared-ip4: reserved IP address range %s/24",
- _nm_utils_inet4_ntop(handle->addr, sbuf_addr));
+ _LOGD("shared-ip4: reserved IP address range %s/24", nm_inet4_ntop(handle->addr, sbuf_addr));
return handle;
}
@@ -314,7 +313,7 @@ nm_netns_shared_ip_release(NMNetnsSharedIPHandle *handle)
{
NMNetns *self;
NMNetnsPrivate *priv;
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
g_return_if_fail(handle);
@@ -331,7 +330,7 @@ nm_netns_shared_ip_release(NMNetnsSharedIPHandle *handle)
nm_assert(handle->addr == ntohl(0x0A2AFF01u)); /* 10.42.255.1 */
handle->_ref_count--;
_LOGD("shared-ip4: release IP address range %s/24 (%d more references held)",
- _nm_utils_inet4_ntop(handle->addr, sbuf_addr),
+ nm_inet4_ntop(handle->addr, sbuf_addr),
handle->_ref_count);
return;
}
@@ -344,8 +343,7 @@ nm_netns_shared_ip_release(NMNetnsSharedIPHandle *handle)
g_object_unref(self);
}
- _LOGD("shared-ip4: release IP address range %s/24",
- _nm_utils_inet4_ntop(handle->addr, sbuf_addr));
+ _LOGD("shared-ip4: release IP address range %s/24", nm_inet4_ntop(handle->addr, sbuf_addr));
handle->_self = NULL;
nm_g_slice_free(handle);
diff --git a/src/core/nm-pacrunner-manager.c b/src/core/nm-pacrunner-manager.c
index 86a406326e..80db755fd7 100644
--- a/src/core/nm-pacrunner-manager.c
+++ b/src/core/nm-pacrunner-manager.c
@@ -129,7 +129,7 @@ get_ip_domains(GPtrArray *domains, const NML3ConfigData *l3cd, int addr_family)
char *cidr;
guint num;
guint i;
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
const NMPlatformIPAddress *address;
const NMPlatformIPRoute *route;
const char *const *strv;
@@ -144,7 +144,7 @@ get_ip_domains(GPtrArray *domains, const NML3ConfigData *l3cd, int addr_family)
nm_l3_config_data_iter_ip_address_for_each (&ipconf_iter, l3cd, addr_family, &address) {
cidr = g_strdup_printf("%s/%u",
- nm_utils_inet_ntop(addr_family, address->address_ptr, sbuf),
+ nm_inet_ntop(addr_family, address->address_ptr, sbuf),
address->plen);
g_ptr_array_add(domains, cidr);
}
@@ -153,7 +153,7 @@ get_ip_domains(GPtrArray *domains, const NML3ConfigData *l3cd, int addr_family)
if (NM_PLATFORM_IP_ROUTE_IS_DEFAULT(route))
continue;
cidr = g_strdup_printf("%s/%u",
- nm_utils_inet_ntop(addr_family, route->network_ptr, sbuf),
+ nm_inet_ntop(addr_family, route->network_ptr, sbuf),
route->plen);
g_ptr_array_add(domains, cidr);
}
diff --git a/src/core/nm-policy.c b/src/core/nm-policy.c
index 16b0211fa2..5999bc0590 100644
--- a/src/core/nm-policy.c
+++ b/src/core/nm-policy.c
@@ -167,11 +167,11 @@ static void
clear_ip6_prefix_delegation(gpointer data)
{
IP6PrefixDelegation *delegation = data;
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
_LOGD(LOGD_IP6,
"ipv6-pd: undelegating prefix %s/%d",
- _nm_utils_inet6_ntop(&delegation->prefix.address, sbuf),
+ nm_inet6_ntop(&delegation->prefix.address, sbuf),
delegation->prefix.plen);
g_hash_table_foreach(delegation->subnets, _clear_ip6_subnet, NULL);
@@ -204,7 +204,7 @@ ip6_subnet_from_delegation(IP6PrefixDelegation *delegation, NMDevice *device)
{
NMPlatformIP6Address *subnet;
int ifindex = nm_device_get_ifindex(device);
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
subnet = g_hash_table_lookup(delegation->subnets, GINT_TO_POINTER(ifindex));
if (!subnet) {
@@ -212,7 +212,7 @@ ip6_subnet_from_delegation(IP6PrefixDelegation *delegation, NMDevice *device)
if (delegation->next_subnet >= (1 << (64 - delegation->prefix.plen))) {
_LOGD(LOGD_IP6,
"ipv6-pd: no more prefixes in %s/%d",
- _nm_utils_inet6_ntop(&delegation->prefix.address, sbuf),
+ nm_inet6_ntop(&delegation->prefix.address, sbuf),
delegation->prefix.plen);
return FALSE;
}
@@ -241,7 +241,7 @@ ip6_subnet_from_delegation(IP6PrefixDelegation *delegation, NMDevice *device)
_LOGD(LOGD_IP6,
"ipv6-pd: %s allocated from a /%d prefix on %s",
- _nm_utils_inet6_ntop(&subnet->address, sbuf),
+ nm_inet6_ntop(&subnet->address, sbuf),
delegation->prefix.plen,
nm_device_get_iface(device));
@@ -312,11 +312,11 @@ device_ip6_prefix_delegated(NMDevice *device,
guint i;
const CList *tmp_list;
NMActiveConnection *ac;
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
_LOGI(LOGD_IP6,
"ipv6-pd: received a prefix %s/%d from %s",
- _nm_utils_inet6_ntop(&prefix->address, sbuf),
+ nm_inet6_ntop(&prefix->address, sbuf),
prefix->plen,
nm_device_get_iface(device));
diff --git a/src/core/platform/nm-fake-platform.c b/src/core/platform/nm-fake-platform.c
index a1ca5434cb..c0680fb10f 100644
--- a/src/core/platform/nm-fake-platform.c
+++ b/src/core/platform/nm-fake-platform.c
@@ -980,7 +980,7 @@ ipx_address_delete(NMPlatform *platform,
|| (plen && address->plen != *plen)
|| (peer_addr
&& (((peer_addr_i ^ address->peer_address)
- & _nm_utils_ip4_prefix_to_netmask(address->plen))
+ & nm_ip4_addr_netmask_from_prefix(address->plen))
!= 0)))
continue;
} else {
@@ -1151,8 +1151,8 @@ ip_route_add(NMPlatform *platform,
&o) {
if (addr_family == AF_INET) {
const NMPlatformIP4Route *item = NMP_OBJECT_CAST_IP4_ROUTE(o);
- guint32 n = nm_utils_ip4_address_clear_host_address(item->network, item->plen);
- guint32 g = nm_utils_ip4_address_clear_host_address(r4->gateway, item->plen);
+ guint32 n = nm_ip4_addr_clear_host_address(item->network, item->plen);
+ guint32 g = nm_ip4_addr_clear_host_address(r4->gateway, item->plen);
if (r->ifindex == item->ifindex && n == g) {
has_route_to_gw = TRUE;
@@ -1162,21 +1162,21 @@ ip_route_add(NMPlatform *platform,
const NMPlatformIP6Route *item = NMP_OBJECT_CAST_IP6_ROUTE(o);
if (r->ifindex == item->ifindex
- && nm_utils_ip6_address_same_prefix(&r6->gateway, &item->network, item->plen)) {
+ && nm_ip6_addr_same_prefix(&r6->gateway, &item->network, item->plen)) {
has_route_to_gw = TRUE;
break;
}
}
}
if (!has_route_to_gw) {
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
if (addr_family == AF_INET) {
nm_log_warn(
LOGD_PLATFORM,
"Fake platform: failure adding ip4-route '%d: %s/%d %d': Network Unreachable",
r->ifindex,
- _nm_utils_inet4_ntop(r4->network, sbuf),
+ nm_inet4_ntop(r4->network, sbuf),
r->plen,
r->metric);
} else {
@@ -1184,7 +1184,7 @@ ip_route_add(NMPlatform *platform,
LOGD_PLATFORM,
"Fake platform: failure adding ip6-route '%d: %s/%d %d': Network Unreachable",
r->ifindex,
- _nm_utils_inet6_ntop(&r6->network, sbuf),
+ nm_inet6_ntop(&r6->network, sbuf),
r->plen,
r->metric);
}
diff --git a/src/core/platform/tests/test-common.c b/src/core/platform/tests/test-common.c
index 34ec5cc2c5..0a7b337762 100644
--- a/src/core/platform/tests/test-common.c
+++ b/src/core/platform/tests/test-common.c
@@ -217,13 +217,13 @@ _nmtstp_platform_ip_addresses_assert(const char *filename,
}
if (!addr_bin->found) {
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
g_error("%s:%d: IPv%c address %s was not found on ifindex %d",
filename,
lineno,
nm_utils_addr_family_to_char(addr_bin->addr_family),
- nm_utils_inet_ntop(addr_bin->addr_family, &addr_bin->addr, sbuf),
+ nm_inet_ntop(addr_bin->addr_family, &addr_bin->addr, sbuf),
ifindex);
}
}
@@ -582,7 +582,7 @@ _nmtstp_assert_ip4_route_exists(const char *file,
r = _ip4_route_get(platform, ifindex, network, plen, metric, tos, &c);
if (c != c_exists && c_exists != -1) {
- char sbuf[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf[NM_INET_ADDRSTRLEN];
NM_PRAGMA_WARNING_DISABLE_DANGLING_POINTER
g_error("[%s:%u] %s(): The ip4 route %s/%d metric %u tos %u shall exist %u times, but "
@@ -590,7 +590,7 @@ _nmtstp_assert_ip4_route_exists(const char *file,
file,
line,
func,
- _nm_utils_inet4_ntop(network, sbuf),
+ nm_inet4_ntop(network, sbuf),
plen,
metric,
tos,
@@ -676,8 +676,8 @@ _nmtstp_assert_ip6_route_exists(const char *file,
r = _ip6_route_get(platform, ifindex, network, plen, metric, src, src_plen, &c);
if (c != c_exists && c_exists != -1) {
- char s_src[NM_UTILS_INET_ADDRSTRLEN];
- char s_network[NM_UTILS_INET_ADDRSTRLEN];
+ char s_src[NM_INET_ADDRSTRLEN];
+ char s_network[NM_INET_ADDRSTRLEN];
NM_PRAGMA_WARNING_DISABLE_DANGLING_POINTER
g_error("[%s:%u] %s(): The ip6 route %s/%d metric %u src %s/%d shall exist %u times, but "
@@ -685,10 +685,10 @@ _nmtstp_assert_ip6_route_exists(const char *file,
file,
line,
func,
- _nm_utils_inet6_ntop(network, s_network),
+ nm_inet6_ntop(network, s_network),
plen,
metric,
- _nm_utils_inet6_ntop(src, s_src),
+ nm_inet6_ntop(src, s_src),
src_plen,
c_exists,
c);
@@ -1051,8 +1051,8 @@ _ip_address_add(NMPlatform *platform,
gs_free char *s_valid = NULL;
gs_free char *s_preferred = NULL;
gs_free char *s_label = NULL;
- char b1[NM_UTILS_INET_ADDRSTRLEN];
- char b2[NM_UTILS_INET_ADDRSTRLEN];
+ char b1[NM_INET_ADDRSTRLEN];
+ char b2[NM_INET_ADDRSTRLEN];
ifname = nm_platform_link_get_name(platform, ifindex);
g_assert(ifname);
@@ -1065,18 +1065,18 @@ _ip_address_add(NMPlatform *platform,
s_label = g_strdup_printf("%s:%s", ifname, label);
if (is_v4) {
- char s_peer[NM_UTILS_INET_ADDRSTRLEN + 50];
+ char s_peer[NM_INET_ADDRSTRLEN + 50];
g_assert(flags == 0);
if (peer_address->addr4 != address->addr4 || nmtst_get_rand_uint32() % 2) {
/* If the peer is the same as the local address, we can omit it. The result should be identical */
- nm_sprintf_buf(s_peer, " peer %s", _nm_utils_inet4_ntop(peer_address->addr4, b2));
+ nm_sprintf_buf(s_peer, " peer %s", nm_inet4_ntop(peer_address->addr4, b2));
} else
s_peer[0] = '\0';
nmtstp_run_command_check("ip address change %s%s/%d dev %s%s%s%s",
- _nm_utils_inet4_ntop(address->addr4, b1),
+ nm_inet4_ntop(address->addr4, b1),
s_peer,
plen,
ifname,
@@ -1089,10 +1089,10 @@ _ip_address_add(NMPlatform *platform,
/* flags not implemented (yet) */
g_assert(flags == 0);
nmtstp_run_command_check("ip address change %s%s%s/%d dev %s%s%s%s",
- _nm_utils_inet6_ntop(&address->addr6, b1),
+ nm_inet6_ntop(&address->addr6, b1),
!IN6_IS_ADDR_UNSPECIFIED(&peer_address->addr6) ? " peer " : "",
!IN6_IS_ADDR_UNSPECIFIED(&peer_address->addr6)
- ? _nm_utils_inet6_ntop(&peer_address->addr6, b2)
+ ? nm_inet6_ntop(&peer_address->addr6, b2)
: "",
plen,
ifname,
@@ -1299,8 +1299,8 @@ _ip_address_del(NMPlatform *platform,
if (external_command) {
const char *ifname;
- char b1[NM_UTILS_INET_ADDRSTRLEN];
- char b2[NM_UTILS_INET_ADDRSTRLEN];
+ char b1[NM_INET_ADDRSTRLEN];
+ char b2[NM_INET_ADDRSTRLEN];
int success;
gboolean had_address;
@@ -1318,18 +1318,17 @@ _ip_address_del(NMPlatform *platform,
had_address = !!nm_platform_ip6_address_get(platform, ifindex, &address->addr6);
if (is_v4) {
- success = nmtstp_run_command("ip address delete %s%s%s/%d dev %s",
- _nm_utils_inet4_ntop(address->addr4, b1),
- peer_address->addr4 != address->addr4 ? " peer " : "",
- peer_address->addr4 != address->addr4
- ? _nm_utils_inet4_ntop(peer_address->addr4, b2)
- : "",
- plen,
- ifname);
+ success = nmtstp_run_command(
+ "ip address delete %s%s%s/%d dev %s",
+ nm_inet4_ntop(address->addr4, b1),
+ peer_address->addr4 != address->addr4 ? " peer " : "",
+ peer_address->addr4 != address->addr4 ? nm_inet4_ntop(peer_address->addr4, b2) : "",
+ plen,
+ ifname);
} else {
g_assert(!peer_address);
success = nmtstp_run_command("ip address delete %s/%d dev %s",
- _nm_utils_inet6_ntop(&address->addr6, b1),
+ nm_inet6_ntop(&address->addr6, b1),
plen,
ifname);
}
@@ -1732,8 +1731,8 @@ nmtstp_link_gre_add(NMPlatform *platform,
name,
type,
dev ?: "",
- _nm_utils_inet4_ntop(lnk->local, b1),
- _nm_utils_inet4_ntop(lnk->remote, b2),
+ nm_inet4_ntop(lnk->local, b1),
+ nm_inet4_ntop(lnk->remote, b2),
lnk->ttl,
lnk->tos,
lnk->path_mtu_discovery ? "pmtudisc" : "nopmtudisc");
@@ -1756,8 +1755,8 @@ nmtstp_link_ip6tnl_add(NMPlatform *platform,
{
const NMPlatformLink *pllink = NULL;
gboolean success;
- char b1[NM_UTILS_INET_ADDRSTRLEN];
- char b2[NM_UTILS_INET_ADDRSTRLEN];
+ char b1[NM_INET_ADDRSTRLEN];
+ char b2[NM_INET_ADDRSTRLEN];
char encap[20];
char tclass[20];
gboolean encap_ignore;
@@ -1798,8 +1797,8 @@ nmtstp_link_ip6tnl_add(NMPlatform *platform,
name,
mode,
dev,
- _nm_utils_inet6_ntop(&lnk->local, b1),
- _nm_utils_inet6_ntop(&lnk->remote, b2),
+ nm_inet6_ntop(&lnk->local, b1),
+ nm_inet6_ntop(&lnk->remote, b2),
lnk->ttl,
tclass_inherit ? "inherit" : nm_sprintf_buf(tclass, "%02x", lnk->tclass),
encap_ignore ? "none" : nm_sprintf_buf(encap, "%u", lnk->encap_limit),
@@ -1822,8 +1821,8 @@ nmtstp_link_ip6gre_add(NMPlatform *platform,
{
const NMPlatformLink *pllink = NULL;
gboolean success;
- char b1[NM_UTILS_INET_ADDRSTRLEN];
- char b2[NM_UTILS_INET_ADDRSTRLEN];
+ char b1[NM_INET_ADDRSTRLEN];
+ char b2[NM_INET_ADDRSTRLEN];
char tclass[20];
gboolean tclass_inherit;
@@ -1848,8 +1847,8 @@ nmtstp_link_ip6gre_add(NMPlatform *platform,
name,
lnk->is_tap ? "ip6gretap" : "ip6gre",
dev,
- _nm_utils_inet6_ntop(&lnk->local, b1),
- _nm_utils_inet6_ntop(&lnk->remote, b2),
+ nm_inet6_ntop(&lnk->local, b1),
+ nm_inet6_ntop(&lnk->remote, b2),
lnk->ttl,
tclass_inherit ? "inherit" : nm_sprintf_buf(tclass, "%02x", lnk->tclass),
lnk->flow_label);
@@ -1901,8 +1900,8 @@ nmtstp_link_ipip_add(NMPlatform *platform,
"ip tunnel add %s mode ipip %s local %s remote %s ttl %u tos %02x %s",
name,
dev,
- _nm_utils_inet4_ntop(lnk->local, b1),
- _nm_utils_inet4_ntop(lnk->remote, b2),
+ nm_inet4_ntop(lnk->local, b1),
+ nm_inet4_ntop(lnk->remote, b2),
lnk->ttl,
lnk->tos,
lnk->path_mtu_discovery ? "pmtudisc" : "nopmtudisc");
@@ -1997,8 +1996,8 @@ nmtstp_link_sit_add(NMPlatform *platform,
!nmtstp_run_command("ip tunnel add %s mode sit%s local %s remote %s ttl %u tos %02x %s",
name,
dev,
- _nm_utils_inet4_ntop(lnk->local, b1),
- _nm_utils_inet4_ntop(lnk->remote, b2),
+ nm_inet4_ntop(lnk->local, b1),
+ nm_inet4_ntop(lnk->remote, b2),
lnk->ttl,
lnk->tos,
lnk->path_mtu_discovery ? "pmtudisc" : "nopmtudisc");
@@ -2132,24 +2131,24 @@ nmtstp_link_vxlan_add(NMPlatform *platform,
if (external_command) {
gs_free char *dev = NULL;
- char local[NM_UTILS_INET_ADDRSTRLEN];
- char group[NM_UTILS_INET_ADDRSTRLEN];
+ char local[NM_INET_ADDRSTRLEN];
+ char group[NM_INET_ADDRSTRLEN];
if (lnk->parent_ifindex)
dev =
g_strdup_printf("dev %s", nm_platform_link_get_name(platform, lnk->parent_ifindex));
if (lnk->local)
- _nm_utils_inet4_ntop(lnk->local, local);
+ nm_inet4_ntop(lnk->local, local);
else if (memcmp(&lnk->local6, &in6addr_any, sizeof(in6addr_any)))
- _nm_utils_inet6_ntop(&lnk->local6, local);
+ nm_inet6_ntop(&lnk->local6, local);
else
local[0] = '\0';
if (lnk->group)
- _nm_utils_inet4_ntop(lnk->group, group);
+ nm_inet4_ntop(lnk->group, group);
else if (memcmp(&lnk->group6, &in6addr_any, sizeof(in6addr_any)))
- _nm_utils_inet6_ntop(&lnk->group6, group);
+ nm_inet6_ntop(&lnk->group6, group);
else
group[0] = '\0';
@@ -2732,7 +2731,7 @@ nmtstp_acd_defender_new(int ifindex, in_addr_t ip_addr, const NMEtherAddr *mac_a
NAcdProbe *probe = NULL;
int fd;
int r;
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
g_assert_cmpint(ifindex, >, 0);
g_assert(mac_addr);
@@ -2773,7 +2772,7 @@ nmtstp_acd_defender_new(int ifindex, in_addr_t ip_addr, const NMEtherAddr *mac_a
NM_HASH_OBFUSCATE_PTR(defender),
ifindex,
NM_ETHER_ADDR_FORMAT_VAL(mac_addr),
- _nm_utils_inet4_ntop(ip_addr, sbuf_addr));
+ nm_inet4_ntop(ip_addr, sbuf_addr));
n_acd_probe_set_userdata(defender->probe, defender);
diff --git a/src/core/platform/tests/test-link.c b/src/core/platform/tests/test-link.c
index b72bcb65b2..29e75446ad 100644
--- a/src/core/platform/tests/test-link.c
+++ b/src/core/platform/tests/test-link.c
@@ -1183,7 +1183,7 @@ _test_wireguard_change(NMPlatform *platform, int ifindex, int test_mode)
for (i = 0; i < num_peers; i++) {
NMPWireGuardPeer peer;
- char s_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char s_addr[NM_INET_ADDRSTRLEN];
NMSockAddrUnion endpoint;
guint i_allowed_ips, n_allowed_ips;
NMPWireGuardAllowedIP *allowed_ips;
diff --git a/src/core/platform/tests/test-route.c b/src/core/platform/tests/test-route.c
index 148ed7922d..ba8a626b95 100644
--- a/src/core/platform/tests/test-route.c
+++ b/src/core/platform/tests/test-route.c
@@ -27,7 +27,7 @@ _wait_for_ipv4_addr_device_route(NMPlatform *platform,
/* Wait that the addresses gets a device-route. After adding a address,
* the device route is not added immediately. It takes a moment... */
- addr = nm_utils_ip4_address_clear_host_address(addr, plen);
+ addr = nm_ip4_addr_clear_host_address(addr, plen);
NMTST_WAIT_ASSERT(400, {
NMDedupMultiIter iter;
NMPLookup lookup;
@@ -41,7 +41,7 @@ _wait_for_ipv4_addr_device_route(NMPlatform *platform,
&o) {
const NMPlatformIP4Route *r = NMP_OBJECT_CAST_IP4_ROUTE(o);
- if (r->plen == plen && addr == nm_utils_ip4_address_clear_host_address(r->network, plen)
+ if (r->plen == plen && addr == nm_ip4_addr_clear_host_address(r->network, plen)
&& r->metric == 0 && r->scope_inv == nm_platform_route_scope_inv(RT_SCOPE_LINK)
&& r->rt_source == NM_IP_CONFIG_SOURCE_RTPROT_KERNEL)
return;
@@ -918,7 +918,7 @@ test_ip(gconstpointer test_data)
const NMPlatformLink *l;
char ifname[IFNAMSIZ];
char ifname2[IFNAMSIZ];
- char s1[NM_UTILS_INET_ADDRSTRLEN];
+ char s1[NM_INET_ADDRSTRLEN];
NMPlatform *platform = NM_PLATFORM_GET;
const int EX_ = -1;
struct {
@@ -1278,7 +1278,7 @@ _rule_create_random(NMPlatform *platform)
guint32 p;
int addr_size;
guint i;
- char saddr[NM_UTILS_INET_ADDRSTRLEN];
+ char saddr[NM_INET_ADDRSTRLEN];
static struct {
guint32 uid;
guint32 euid;
diff --git a/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c b/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c
index 6452d72a48..46df18b777 100644
--- a/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c
+++ b/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c
@@ -739,7 +739,7 @@ read_full_ip4_address(shvarFile *ifcfg,
int prefix = 0;
gboolean has_key;
guint32 a;
- char inet_buf[NM_UTILS_INET_ADDRSTRLEN];
+ char inet_buf[NM_INET_ADDRSTRLEN];
g_return_val_if_fail(which >= -1, FALSE);
g_return_val_if_fail(ifcfg != NULL, FALSE);
@@ -761,7 +761,7 @@ read_full_ip4_address(shvarFile *ifcfg,
if (!read_ip4_address(ifcfg, numbered_tag(tag, "GATEWAY", which), &has_key, &a, error))
return FALSE;
if (has_key)
- *out_gateway = nm_utils_inet4_ntop_dup(a);
+ *out_gateway = nm_inet4_ntop_dup(a);
}
/* Prefix */
@@ -782,16 +782,16 @@ read_full_ip4_address(shvarFile *ifcfg,
if (!read_ip4_address(ifcfg, numbered_tag(tag, "NETMASK", which), &has_key, &a, error))
return FALSE;
if (has_key)
- prefix = _nm_utils_ip4_netmask_to_prefix(a);
+ prefix = nm_ip4_addr_netmask_to_prefix(a);
else {
if (base_addr)
prefix = nm_ip_address_get_prefix(base_addr);
else {
/* Try to autodetermine the prefix for the address' class */
- prefix = _nm_utils_ip4_get_default_prefix(ipaddr);
+ prefix = nm_ip4_addr_get_default_prefix(ipaddr);
PARSE_WARNING("missing %s, assuming %s/%d",
prefix_tag,
- _nm_utils_inet4_ntop(ipaddr, inet_buf),
+ nm_inet4_ntop(ipaddr, inet_buf),
prefix);
}
}
@@ -1282,7 +1282,7 @@ parse_line_type_addr_with_prefix:
int prefix = -1;
if (p_info->type == PARSE_LINE_TYPE_ADDR) {
- if (!nm_utils_parse_inaddr_bin(addr_family, s, NULL, &p_data->v.addr.addr)) {
+ if (!nm_inet_parse_bin(addr_family, s, NULL, &p_data->v.addr.addr)) {
if (p_info == &parse_infos[PARSE_LINE_ATTR_ROUTE_VIA]
&& nm_streq(s, "(null)")) {
/* Due to a bug, would older versions of NM write "via (null)"
@@ -1313,11 +1313,11 @@ parse_line_type_addr_with_prefix:
if (p_info == &parse_infos[PARSE_LINE_ATTR_ROUTE_TO] && nm_streq(s, "default")) {
memset(&p_data->v.addr.addr, 0, sizeof(p_data->v.addr.addr));
prefix = 0;
- } else if (!nm_utils_parse_inaddr_prefix_bin(addr_family,
- s,
- NULL,
- &p_data->v.addr.addr,
- &prefix)) {
+ } else if (!nm_inet_parse_with_prefix_bin(addr_family,
+ s,
+ NULL,
+ &p_data->v.addr.addr,
+ &prefix)) {
g_set_error(error,
NM_SETTINGS_ERROR,
NM_SETTINGS_ERROR_INVALID_CONNECTION,
@@ -1468,7 +1468,7 @@ read_one_ip4_route(shvarFile *ifcfg, guint32 which, NMIPRoute **out_route, GErro
const char *v;
gs_free char *value = NULL;
gint64 prefix, metric;
- char inet_buf[NM_UTILS_INET_ADDRSTRLEN];
+ char inet_buf[NM_INET_ADDRSTRLEN];
g_return_val_if_fail(ifcfg != NULL, FALSE);
g_return_val_if_fail(out_route && !*out_route, FALSE);
@@ -1496,14 +1496,14 @@ read_one_ip4_route(shvarFile *ifcfg, guint32 which, NMIPRoute **out_route, GErro
error))
return FALSE;
if (has_key) {
- prefix = _nm_utils_ip4_netmask_to_prefix(netmask);
- if (netmask != _nm_utils_ip4_prefix_to_netmask(prefix)) {
+ prefix = nm_ip4_addr_netmask_to_prefix(netmask);
+ if (netmask != nm_ip4_addr_netmask_from_prefix(prefix)) {
g_set_error(error,
NM_SETTINGS_ERROR,
NM_SETTINGS_ERROR_INVALID_CONNECTION,
"Invalid IP4 netmask '%s' \"%s\"",
netmask_tag,
- _nm_utils_inet4_ntop(netmask, inet_buf));
+ nm_inet4_ntop(netmask, inet_buf));
return FALSE;
}
} else {
@@ -1667,7 +1667,7 @@ parse_full_ip6_address(shvarFile *ifcfg,
nm_assert(out_address && !*out_address);
nm_assert(!error || !*error);
- if (!nm_utils_parse_inaddr_prefix_bin(AF_INET6, addr_str, NULL, &addr_bin, &prefix)) {
+ if (!nm_inet_parse_with_prefix_bin(AF_INET6, addr_str, NULL, &addr_bin, &prefix)) {
g_set_error(error,
NM_SETTINGS_ERROR,
NM_SETTINGS_ERROR_INVALID_CONNECTION,
@@ -2027,7 +2027,7 @@ make_ip4_setting(shvarFile *ifcfg,
"because the connection has no static addresses",
f);
} else
- gateway = nm_utils_inet4_ntop_dup(a);
+ gateway = nm_inet4_ntop_dup(a);
}
}
}
@@ -2055,10 +2055,10 @@ make_ip4_setting(shvarFile *ifcfg,
if (!v)
break;
- if (nm_utils_ipaddr_is_valid(AF_INET, v)) {
+ if (nm_inet_is_valid(AF_INET, v)) {
if (!nm_setting_ip_config_add_dns(s_ip4, v))
PARSE_WARNING("duplicate DNS server %s", tag);
- } else if (nm_utils_ipaddr_is_valid(AF_INET6, v)) {
+ } else if (nm_inet_is_valid(AF_INET6, v)) {
/* Ignore IPv6 addresses */
} else {
g_set_error(error,
@@ -2546,7 +2546,7 @@ make_ip6_setting(shvarFile *ifcfg, shvarFile *network_ifcfg, gboolean routes_rea
if ((ptr = strchr(v, '%')) != NULL)
*ptr = '\0'; /* remove %interface prefix if present */
- if (!nm_utils_ipaddr_is_valid(AF_INET6, v)) {
+ if (!nm_inet_is_valid(AF_INET6, v)) {
if (!is_disabled) {
g_set_error(error,
NM_SETTINGS_ERROR,
@@ -2594,14 +2594,14 @@ make_ip6_setting(shvarFile *ifcfg, shvarFile *network_ifcfg, gboolean routes_rea
if (!v)
break;
- if (nm_utils_ipaddr_is_valid(AF_INET6, v)) {
+ if (nm_inet_is_valid(AF_INET6, v)) {
if (is_disabled) {
PARSE_WARNING("ignore DNS server addresses with method disabled/ignore");
break;
}
if (!nm_setting_ip_config_add_dns(s_ip6, v))
PARSE_WARNING("duplicate DNS server %s", tag);
- } else if (nm_utils_ipaddr_is_valid(AF_INET, v)) {
+ } else if (nm_inet_is_valid(AF_INET, v)) {
/* Ignore IPv4 addresses */
} else {
if (is_disabled)
diff --git a/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c b/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c
index 96efc9e5d7..d8c6a839f0 100644
--- a/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c
+++ b/src/core/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c
@@ -2409,8 +2409,8 @@ write_route_file_svformat(const char *filename, NMSettingIPConfig *s_ip4)
svSetValueStr(routefile, addr_key, nm_ip_route_get_dest(route));
- netmask = _nm_utils_ip4_prefix_to_netmask(nm_ip_route_get_prefix(route));
- svSetValueStr(routefile, netmask_key, _nm_utils_inet4_ntop(netmask, buf));
+ netmask = nm_ip4_addr_netmask_from_prefix(nm_ip_route_get_prefix(route));
+ svSetValueStr(routefile, netmask_key, nm_inet4_ntop(netmask, buf));
svSetValueStr(routefile, gw_key, nm_ip_route_get_next_hop(route));
@@ -2819,9 +2819,7 @@ write_ip4_setting(NMConnection *connection,
if (has_netmask) {
char buf[INET_ADDRSTRLEN];
- svSetValueStr(ifcfg,
- tag,
- _nm_utils_inet4_ntop(_nm_utils_ip4_prefix_to_netmask(prefix), buf));
+ svSetValueStr(ifcfg, tag, nm_inet4_ntop(nm_ip4_addr_netmask_from_prefix(prefix), buf));
}
n++;
diff --git a/src/core/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c b/src/core/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c
index 9fdae4bd25..0ba9dc6b23 100644
--- a/src/core/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c
+++ b/src/core/settings/plugins/ifcfg-rh/tests/test-ifcfg-rh.c
@@ -2082,7 +2082,7 @@ test_read_wired_aliases_good(gconstpointer test_data)
g_assert(ip4_addr != NULL);
addr = nm_ip_address_get_address(ip4_addr);
- g_assert(nm_utils_ipaddr_is_valid(AF_INET, addr));
+ g_assert(nm_inet_is_valid(AF_INET, addr));
for (j = 0; j < expected_num_addresses; j++) {
if (!g_strcmp0(addr, expected_address[j]))
diff --git a/src/core/settings/plugins/ifupdown/nms-ifupdown-parser.c b/src/core/settings/plugins/ifupdown/nms-ifupdown-parser.c
index a1d6781b41..3bdd78c9a5 100644
--- a/src/core/settings/plugins/ifupdown/nms-ifupdown-parser.c
+++ b/src/core/settings/plugins/ifupdown/nms-ifupdown-parser.c
@@ -451,7 +451,7 @@ update_ip4_setting_from_if_block(NMConnection *connection, if_block *block, GErr
netmask_v);
return FALSE;
} else {
- netmask_int = _nm_utils_ip4_netmask_to_prefix(tmp_mask);
+ netmask_int = nm_ip4_addr_netmask_to_prefix(tmp_mask);
}
}
@@ -470,7 +470,7 @@ update_ip4_setting_from_if_block(NMConnection *connection, if_block *block, GErr
/* gateway */
gateway_v = ifparser_getkey(block, "gateway");
if (gateway_v) {
- if (!nm_utils_ipaddr_is_valid(AF_INET, gateway_v)) {
+ if (!nm_inet_is_valid(AF_INET, gateway_v)) {
g_set_error(error,
NM_SETTINGS_ERROR,
NM_SETTINGS_ERROR_INVALID_CONNECTION,
@@ -579,7 +579,7 @@ update_ip6_setting_from_if_block(NMConnection *connection, if_block *block, GErr
gateway_v = ifparser_getkey(block, "gateway");
if (gateway_v) {
- if (!nm_utils_ipaddr_is_valid(AF_INET6, gateway_v)) {
+ if (!nm_inet_is_valid(AF_INET6, gateway_v)) {
g_set_error(error,
NM_SETTINGS_ERROR,
NM_SETTINGS_ERROR_INVALID_CONNECTION,
diff --git a/src/core/supplicant/nm-supplicant-interface.c b/src/core/supplicant/nm-supplicant-interface.c
index fa8b4e3713..5b5d86229c 100644
--- a/src/core/supplicant/nm-supplicant-interface.c
+++ b/src/core/supplicant/nm-supplicant-interface.c
@@ -3174,7 +3174,7 @@ _signal_handle(NMSupplicantInterface *self,
_set_p2p_assigned_addr(iface,
addr_data,
- _nm_utils_ip4_netmask_to_prefix(netmask));
+ nm_ip4_addr_netmask_to_prefix(netmask));
} else {
_LOGW("P2P: GroupStarted signaled invalid IP Address information");
}
diff --git a/src/core/tests/test-core.c b/src/core/tests/test-core.c
index c260788e1a..07309518f1 100644
--- a/src/core/tests/test-core.c
+++ b/src/core/tests/test-core.c
@@ -40,7 +40,7 @@ test_config_h(void)
/*****************************************************************************/
-/* Reference implementation for nm_utils_ip6_address_clear_host_address.
+/* Reference implementation for nm_ip6_addr_clear_host_address.
* Taken originally from set_address_masked(), src/ndisc/nm-lndp-ndisc.c
**/
static void
@@ -95,14 +95,14 @@ test_nm_utils_ip6_address_clear_host_address(void)
_randomize_in6_addr(&addr1, r);
_randomize_in6_addr(&addr2, r);
addr1 = addr_src;
- nm_utils_ip6_address_clear_host_address(&addr2, &addr1, plen);
+ nm_ip6_addr_clear_host_address(&addr2, &addr1, plen);
g_assert_cmpint(memcmp(&addr1, &addr_src, sizeof(struct in6_addr)), ==, 0);
g_assert_cmpint(memcmp(&addr2, &addr_ref, sizeof(struct in6_addr)), ==, 0);
/* test for self assignment/inplace update. */
_randomize_in6_addr(&addr1, r);
addr1 = addr_src;
- nm_utils_ip6_address_clear_host_address(&addr1, &addr1, plen);
+ nm_ip6_addr_clear_host_address(&addr1, &addr1, plen);
g_assert_cmpint(memcmp(&addr1, &addr_ref, sizeof(struct in6_addr)), ==, 0);
}
}
@@ -155,11 +155,11 @@ _test_same_prefix(const char *a1, const char *a2, guint8 plen)
struct in6_addr a = *nmtst_inet6_from_string(a1);
struct in6_addr b = *nmtst_inet6_from_string(a2);
- g_assert(nm_utils_ip6_address_same_prefix(&a, &b, plen));
+ g_assert(nm_ip6_addr_same_prefix(&a, &b, plen));
}
static void
-test_nm_utils_ip6_address_same_prefix(void)
+test_nm_ip_addr_same_prefix(void)
{
guint n, i;
const guint N = 100;
@@ -202,7 +202,7 @@ again_plen:
} else
b = a;
- result = nm_utils_ip6_address_same_prefix(&a.val, &b.val, plen);
+ result = nm_ip6_addr_same_prefix(&a.val, &b.val, plen);
g_assert(result == is_same);
g_assert(NM_IN_SET(result, TRUE, FALSE));
}
@@ -214,12 +214,12 @@ again_plen:
plen = nmtst_get_rand_uint32() % 129;
memset(addrmask.ptr, 0xFF, sizeof(addrmask));
- nm_utils_ip6_address_clear_host_address(&addrmask.val, &addrmask.val, plen);
+ nm_ip6_addr_clear_host_address(&addrmask.val, &addrmask.val, plen);
for (i = 0; i < sizeof(a); i++)
b.ptr[i] = (a.ptr[i] & addrmask.ptr[i]) | (b.ptr[i] & ~addrmask.ptr[i]);
- g_assert(nm_utils_ip6_address_same_prefix(&a.val, &b.val, plen) == TRUE);
+ g_assert(nm_ip6_addr_same_prefix(&a.val, &b.val, plen) == TRUE);
}
/* test#3 */
@@ -234,10 +234,10 @@ again_plen:
continue;
memset(addrmask.ptr, 0xFF, sizeof(addrmask));
- nm_utils_ip6_address_clear_host_address(&addrmask.val, &addrmask.val, plen);
+ nm_ip6_addr_clear_host_address(&addrmask.val, &addrmask.val, plen);
memset(addrmask_bit.ptr, 0xFF, sizeof(addrmask_bit));
- nm_utils_ip6_address_clear_host_address(&addrmask_bit.val, &addrmask_bit.val, plen - 1);
+ nm_ip6_addr_clear_host_address(&addrmask_bit.val, &addrmask_bit.val, plen - 1);
for (i = 0; i < sizeof(a); i++)
b.ptr[i] = (a.ptr[i] & addrmask.ptr[i]) | (b.ptr[i] & ~addrmask.ptr[i]);
@@ -254,7 +254,7 @@ again_plen:
}
g_assert(reached);
- g_assert(nm_utils_ip6_address_same_prefix(&a.val, &b.val, plen) == FALSE);
+ g_assert(nm_ip6_addr_same_prefix(&a.val, &b.val, plen) == FALSE);
}
/* test#4 */
@@ -2594,10 +2594,9 @@ main(int argc, char **argv)
g_test_add_func("/general/nm_strbuf_append", test_nm_utils_strbuf_append);
- g_test_add_func("/general/nm_utils_ip6_address_clear_host_address",
+ g_test_add_func("/general/nm_ip6_addr_clear_host_address",
test_nm_utils_ip6_address_clear_host_address);
- g_test_add_func("/general/nm_utils_ip6_address_same_prefix",
- test_nm_utils_ip6_address_same_prefix);
+ g_test_add_func("/general/nm_ip6_addr_same_prefix", test_nm_ip_addr_same_prefix);
g_test_add_func("/general/nm_utils_log_connection_diff", test_nm_utils_log_connection_diff);
g_test_add_func("/general/nm_utils_sysctl_ip_conf_path", test_nm_utils_sysctl_ip_conf_path);
diff --git a/src/core/tests/test-l3cfg.c b/src/core/tests/test-l3cfg.c
index a9ac400496..67c030197a 100644
--- a/src/core/tests/test-l3cfg.c
+++ b/src/core/tests/test-l3cfg.c
@@ -572,7 +572,7 @@ _test_l3_ipv4ll_signal_notify(NML3Cfg *l3cfg,
const NML3ConfigNotifyData *notify_data,
TestL3IPv4LLData *tdata)
{
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
g_assert(NM_IS_L3CFG(l3cfg));
g_assert(tdata);
@@ -593,9 +593,9 @@ _test_l3_ipv4ll_signal_notify(NML3Cfg *l3cfg,
if (tdata->f->test_idx == 2 && nmtst_get_rand_bool()) {
tdata->addr_commit++;
tdata->addr_commit_addr = nm_l3_ipv4ll_get_addr(tdata->l3ipv4ll);
- g_assert(nm_utils_ip4_address_is_link_local(tdata->addr_commit_addr));
+ g_assert(nm_ip4_addr_is_link_local(tdata->addr_commit_addr));
_LOGT("add address %s that passed ACD",
- _nm_utils_inet4_ntop(tdata->addr_commit_addr, sbuf_addr));
+ nm_inet4_ntop(tdata->addr_commit_addr, sbuf_addr));
if (!nm_l3cfg_add_config(nm_l3_ipv4ll_get_l3cfg(tdata->l3ipv4ll),
TEST_L3_IPV4LL_TAG(tdata, 1),
nmtst_get_rand_bool(),
@@ -630,9 +630,9 @@ _test_l3_ipv4ll_signal_notify(NML3Cfg *l3cfg,
if (tdata->addr_commit > 0) {
g_assert_cmpint(tdata->addr_commit, ==, 1);
tdata->addr_commit--;
- g_assert(nm_utils_ip4_address_is_link_local(tdata->addr_commit_addr));
+ g_assert(nm_ip4_addr_is_link_local(tdata->addr_commit_addr));
_LOGT("remove address %s that previously passed ACD",
- _nm_utils_inet4_ntop(tdata->addr_commit_addr, sbuf_addr));
+ nm_inet4_ntop(tdata->addr_commit_addr, sbuf_addr));
if (!nm_l3cfg_remove_config_all(nm_l3_ipv4ll_get_l3cfg(tdata->l3ipv4ll),
TEST_L3_IPV4LL_TAG(tdata, 1)))
g_assert_not_reached();
@@ -663,7 +663,7 @@ test_l3_ipv4ll(gconstpointer test_data)
gint64 start_time_msec;
gint64 total_poll_time_msec;
nm_auto_remove_l3ipv4ll_registration NML3IPv4LLRegistration *l3ipv4ll_reg = NULL;
- char sbuf_addr[NM_UTILS_INET_ADDRSTRLEN];
+ char sbuf_addr[NM_INET_ADDRSTRLEN];
_LOGD("test start (/l3-ipv4ll/%d)", TEST_IDX);
@@ -733,12 +733,12 @@ test_l3_ipv4ll(gconstpointer test_data)
if (tdata->f->test_idx == 2 && nmtst_get_rand_one_case_in(3)) {
in_addr_t a = nm_l3_ipv4ll_get_addr(l3ipv4ll);
- g_assert(nm_utils_ip4_address_is_link_local(a));
+ g_assert(nm_ip4_addr_is_link_local(a));
_test_l3_ipv4ll_maybe_add_addr_4(tdata,
tdata->f->ifindex1,
2,
&tdata->add_conflict_done,
- _nm_utils_inet4_ntop(a, sbuf_addr));
+ nm_inet4_ntop(a, sbuf_addr));
g_assert_cmpint(tdata->f->hwaddr1.len, ==, sizeof(NMEtherAddr));
acd_defender_2 =
nmtstp_acd_defender_new(tdata->f->ifindex1, a, &tdata->f->hwaddr1.ether_addr);
@@ -768,12 +768,11 @@ test_l3_ipv4ll(gconstpointer test_data)
if (tdata->addr_commit == 1 && !tdata->add_conflict_checked) {
tdata->add_conflict_checked = TRUE;
- _test_l3_ipv4ll_maybe_add_addr_4(
- tdata,
- tdata->f->ifindex1,
- 2,
- &tdata->add_conflict_done,
- _nm_utils_inet4_ntop(tdata->addr_commit_addr, sbuf_addr));
+ _test_l3_ipv4ll_maybe_add_addr_4(tdata,
+ tdata->f->ifindex1,
+ 2,
+ &tdata->add_conflict_done,
+ nm_inet4_ntop(tdata->addr_commit_addr, sbuf_addr));
if (tdata->add_conflict_done)
total_poll_time_msec += L3IPV4LL_ACD_TIMEOUT_MSEC / 2;
g_assert_cmpint(tdata->f->hwaddr1.len, ==, sizeof(NMEtherAddr));
diff --git a/src/core/vpn/nm-vpn-connection.c b/src/core/vpn/nm-vpn-connection.c
index bbb7355016..860b3086d3 100644
--- a/src/core/vpn/nm-vpn-connection.c
+++ b/src/core/vpn/nm-vpn-connection.c
@@ -1217,7 +1217,7 @@ _parent_device_l3cd_add_gateway_route(NML3ConfigData *l3cd,
if (!nm_ip_addr_is_null(addr_family, gw)) {
nm_ip_addr_set(addr_family, &parent_gw, gw);
has_parent_gw = TRUE;
- } else if (nm_utils_ip_is_site_local(addr_family, vpn_gw))
+ } else if (nm_ip_addr_is_site_local(addr_family, vpn_gw))
has_parent_gw = TRUE;
else if ((obj = nm_device_get_best_default_route(parent_device, addr_family))
&& nm_ip_addr_is_null(
@@ -2104,9 +2104,8 @@ _dbus_signal_ip_config_cb(NMVpnConnection *self, int addr_family, GVariant *dict
if (plen > 32)
break;
- route.r4.plen = plen;
- route.r4.network =
- nm_utils_ip4_address_clear_host_address(route.r4.network, plen);
+ route.r4.plen = plen;
+ route.r4.network = nm_ip4_addr_clear_host_address(route.r4.network, plen);
if (priv->ip_data_4.gw_external.addr4
&& route.r4.network == priv->ip_data_4.gw_external.addr4
@@ -2146,9 +2145,7 @@ _dbus_signal_ip_config_cb(NMVpnConnection *self, int addr_family, GVariant *dict
nm_ip_addr_set_from_variant(AF_INET6, &route.r6.gateway, next_hop, NULL);
- nm_utils_ip6_address_clear_host_address(&route.r6.network,
- &route.r6.network,
- route.r6.plen);
+ nm_ip6_addr_clear_host_address(&route.r6.network, &route.r6.network, route.r6.plen);
if (!IN6_IS_ADDR_UNSPECIFIED(&priv->ip_data_6.gw_external.addr6)
&& IN6_ARE_ADDR_EQUAL(&route.r6.network, &priv->ip_data_6.gw_external.addr6)