diff options
| author | Thomas Haller <thaller@redhat.com> | 2016-02-28 18:12:28 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2016-03-03 18:54:20 +0100 |
| commit | cd4f84b7381707bff6e5fcc3cee84492e12c6879 (patch) | |
| tree | 1dbe34839e59cf1d1d61e63dc3da56034a4c3508 /libnm-core | |
| parent | 6265398b6e33ea67d73c592dd3a88f3fafc5bc7a (diff) | |
| download | NetworkManager-cd4f84b7381707bff6e5fcc3cee84492e12c6879.tar.gz | |
all: don't include error->code in log messages
GError codes are only unique per domain, so logging the code without
also indicating the domain is not helpful. And anyway, if the error
messages are not distinctive enough to tell the whole story then we
should fix the error messages.
Based-on-patch-by: Dan Winship <danw@gnome.org>
Diffstat (limited to 'libnm-core')
| -rw-r--r-- | libnm-core/nm-setting-8021x.c | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/libnm-core/nm-setting-8021x.c b/libnm-core/nm-setting-8021x.c index 0ecb988af2..cc8ea66ed7 100644 --- a/libnm-core/nm-setting-8021x.c +++ b/libnm-core/nm-setting-8021x.c @@ -2907,8 +2907,7 @@ set_property (GObject *object, guint prop_id, g_bytes_unref (priv->ca_cert); priv->ca_cert = set_cert_prop_helper (value, NM_SETTING_802_1X_CA_CERT, &error); if (error) { - g_warning ("Error setting certificate (invalid data): (%d) %s", - error->code, error->message); + g_warning ("Error setting certificate (invalid data): %s", error->message); g_error_free (error); } break; @@ -2929,8 +2928,7 @@ set_property (GObject *object, guint prop_id, g_bytes_unref (priv->client_cert); priv->client_cert = set_cert_prop_helper (value, NM_SETTING_802_1X_CLIENT_CERT, &error); if (error) { - g_warning ("Error setting certificate (invalid data): (%d) %s", - error->code, error->message); + g_warning ("Error setting certificate (invalid data): %s", error->message); g_error_free (error); } break; @@ -2959,8 +2957,7 @@ set_property (GObject *object, guint prop_id, g_bytes_unref (priv->phase2_ca_cert); priv->phase2_ca_cert = set_cert_prop_helper (value, NM_SETTING_802_1X_PHASE2_CA_CERT, &error); if (error) { - g_warning ("Error setting certificate (invalid data): (%d) %s", - error->code, error->message); + g_warning ("Error setting certificate (invalid data): %s", error->message); g_error_free (error); } break; @@ -2981,8 +2978,7 @@ set_property (GObject *object, guint prop_id, g_bytes_unref (priv->phase2_client_cert); priv->phase2_client_cert = set_cert_prop_helper (value, NM_SETTING_802_1X_PHASE2_CLIENT_CERT, &error); if (error) { - g_warning ("Error setting certificate (invalid data): (%d) %s", - error->code, error->message); + g_warning ("Error setting certificate (invalid data): %s", error->message); g_error_free (error); } break; @@ -3006,8 +3002,7 @@ set_property (GObject *object, guint prop_id, g_bytes_unref (priv->private_key); priv->private_key = set_cert_prop_helper (value, NM_SETTING_802_1X_PRIVATE_KEY, &error); if (error) { - g_warning ("Error setting private key (invalid data): (%d) %s", - error->code, error->message); + g_warning ("Error setting private key (invalid data): %s", error->message); g_error_free (error); } break; @@ -3023,8 +3018,7 @@ set_property (GObject *object, guint prop_id, g_bytes_unref (priv->phase2_private_key); priv->phase2_private_key = set_cert_prop_helper (value, NM_SETTING_802_1X_PHASE2_PRIVATE_KEY, &error); if (error) { - g_warning ("Error setting private key (invalid data): (%d) %s", - error->code, error->message); + g_warning ("Error setting private key (invalid data): %s", error->message); g_error_free (error); } break; |