shared,all: return boolean success from nm_utils_file_get_contents()

... and nm_utils_fd_get_contents() and nm_utils_file_set_contents().

Don't mix negative errno return value with a GError output. Instead,
return a boolean result indicating success or failure.

Also, optionally

  - output GError

  - set out_errsv to the positive errno (or 0 on success)

Obviously, the return value and the output arguments (contents, length,
out_errsv, error) must all agree in their success/failure result.
That means, you may check any of the return value, out_errsv, error, and
contents to reliably detect failure or success.

Also note that out_errsv gives the positive(!) errno. But you probably
shouldn't care about the distinction and use nm_errno_native() either
way to normalize the value.

1 files changed, 2 insertions, 1 deletions

diff --git a/libnm-core/nm-crypto.c b/libnm-core/nm-crypto.c
index e0c3b7fde5..37ffd6b121 100644
--- a/libnm-core/nm-crypto.c
+++ b/libnm-core/nm-crypto.c
@@ -444,7 +444,8 @@ file_read_contents (const char *filename,
 	                                   NM_UTILS_FILE_GET_CONTENTS_FLAG_SECRET,
 	                                   &out_contents->str,
 	                                   &out_contents->len,
-	                                   error) >= 0;
+	                                   NULL,
+	                                   error);
 }
 
 GBytes *