diff options
author | Thomas Haller <thaller@redhat.com> | 2020-05-26 18:55:26 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2020-05-29 12:49:04 +0200 |
commit | 9c236416c854ddfb1e99ddd7215cc197e8b86c64 (patch) | |
tree | 4c361ff45b04b06f49262c670d7f42b4e7dfad39 /Makefile.examples | |
parent | da3b534d456c00f226fb0c89ff805d4ca90ef35b (diff) | |
download | NetworkManager-9c236416c854ddfb1e99ddd7215cc197e8b86c64.tar.gz |
device: only ready existing ethtool ring settings if needed
Imagine you have a veth device. That device supports certain offload features
(like "ethtool.feature-rx-checksum") but doesn't support any ring
options. Even trying to read the current ring settings will fail.
If you try to activate that profile, NMDevice previously would always
try to fetch the ring options and log a warning and extra debugging
messages:
<trace> [1590511552.3943] ethtool[31]: ETHTOOL_GRINGPARAM, v: failed: Operation not supported
<trace> [1590511552.3944] ethtool[31]: get-ring: failure getting ring settings
<warn> [1590511552.3944] device (v): ethtool: failure getting ring settings (cannot read)
It does so, although you didn't specify any ring settings and there
was no need to fetch the ring settings to begin with.
Avoid this extra logging by only fetching the ring option when they
are actually required.
Diffstat (limited to 'Makefile.examples')
0 files changed, 0 insertions, 0 deletions