diff options
author | Dan Winship <danw@gnome.org> | 2014-10-20 14:04:23 -0400 |
---|---|---|
committer | Dan Winship <danw@gnome.org> | 2014-10-20 14:06:36 -0400 |
commit | a63eb550004fbf657e64bd133d5998663ea6fbdf (patch) | |
tree | a67020c235eb0cea2c7102c0aa3ef7abe5b96dec | |
parent | 03ab33af4c33a53971617909390147b1c2141601 (diff) | |
download | NetworkManager-danw/bgo735900-dbus-errors.tar.gz |
fixup! core: drop all remaining core-internal error domainsdanw/bgo735900-dbus-errors
-rw-r--r-- | src/vpn-manager/nm-vpn-manager.c | 14 | ||||
-rw-r--r-- | src/vpn-manager/nm-vpn-manager.h | 14 | ||||
-rw-r--r-- | src/vpn-manager/nm-vpn-service.c | 2 |
3 files changed, 3 insertions, 27 deletions
diff --git a/src/vpn-manager/nm-vpn-manager.c b/src/vpn-manager/nm-vpn-manager.c index a6f9f1a510..a431aa3a54 100644 --- a/src/vpn-manager/nm-vpn-manager.c +++ b/src/vpn-manager/nm-vpn-manager.c @@ -43,15 +43,6 @@ typedef struct { guint monitor_id; } NMVpnManagerPrivate; -GQuark -nm_vpn_manager_error_quark (void) -{ - static GQuark quark = 0; - if (!quark) - quark = g_quark_from_static_string ("nm-vpn-manager-error"); - return quark; -} - static NMVpnService * get_service_by_namefile (NMVpnManager *self, const char *namefile) @@ -95,7 +86,7 @@ nm_vpn_manager_activate_connection (NMVpnManager *manager, g_assert (device); if ( nm_device_get_state (device) != NM_DEVICE_STATE_ACTIVATED && nm_device_get_state (device) != NM_DEVICE_STATE_SECONDARIES) { - g_set_error_literal (error, NM_VPN_MANAGER_ERROR, NM_VPN_MANAGER_ERROR_DEVICE_NOT_ACTIVE, + g_set_error_literal (error, NM_MANAGER_ERROR, NM_MANAGER_ERROR_DEPENDENCY_FAILED, "The base device for the VPN connection was not active."); return FALSE; } @@ -109,7 +100,7 @@ nm_vpn_manager_activate_connection (NMVpnManager *manager, g_assert (service_name); service = g_hash_table_lookup (NM_VPN_MANAGER_GET_PRIVATE (manager)->services, service_name); if (!service) { - g_set_error (error, NM_VPN_MANAGER_ERROR, NM_VPN_MANAGER_ERROR_SERVICE_INVALID, + g_set_error (error, NM_MANAGER_ERROR, NM_MANAGER_ERROR_CONNECTION_NOT_AVAILABLE, "The VPN service '%s' was not installed.", service_name); return FALSE; @@ -303,7 +294,6 @@ nm_vpn_manager_class_init (NMVpnManagerClass *manager_class) /* virtual methods */ object_class->dispose = dispose; - dbus_g_error_domain_register (NM_VPN_MANAGER_ERROR, NULL, NM_TYPE_VPN_MANAGER_ERROR); dbus_g_error_domain_register (NM_VPN_PLUGIN_ERROR, NM_VPN_DBUS_PLUGIN_INTERFACE, NM_TYPE_VPN_PLUGIN_ERROR); diff --git a/src/vpn-manager/nm-vpn-manager.h b/src/vpn-manager/nm-vpn-manager.h index bb272be9a6..b75a617955 100644 --- a/src/vpn-manager/nm-vpn-manager.h +++ b/src/vpn-manager/nm-vpn-manager.h @@ -33,20 +33,6 @@ #define NM_IS_VPN_MANAGER_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), NM_TYPE_VPN_MANAGER)) #define NM_VPN_MANAGER_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), NM_TYPE_VPN_MANAGER, NMVpnManagerClass)) -typedef enum -{ - NM_VPN_MANAGER_ERROR_DEVICE_NOT_ACTIVE = 0, /*< nick=BaseDeviceNotActive >*/ - NM_VPN_MANAGER_ERROR_CONNECTION_INVALID, /*< nick=ConnectionInvalid >*/ - NM_VPN_MANAGER_ERROR_SERVICE_INVALID, /*< nick=ServiceInvalid >*/ - NM_VPN_MANAGER_ERROR_SERVICE_START_FAILED, /*< nick=ServiceStartFailed >*/ -} NMVpnManagerError; - -#define NM_VPN_MANAGER_ERROR (nm_vpn_manager_error_quark ()) - -GQuark nm_vpn_manager_error_quark (void); -GType nm_vpn_manager_error_get_type (void); - - typedef struct { GObject parent; } NMVpnManager; diff --git a/src/vpn-manager/nm-vpn-service.c b/src/vpn-manager/nm-vpn-service.c index a142a30ac8..142644a2d0 100644 --- a/src/vpn-manager/nm-vpn-service.c +++ b/src/vpn-manager/nm-vpn-service.c @@ -218,7 +218,7 @@ nm_vpn_service_daemon_exec (NMVpnService *service, GError **error) spawn_error && spawn_error->message ? spawn_error->message : "(unknown)"); g_set_error (error, - NM_VPN_MANAGER_ERROR, NM_VPN_MANAGER_ERROR_SERVICE_START_FAILED, + NM_MANAGER_ERROR, NM_MANAGER_ERROR_FAILED, "%s", spawn_error ? spawn_error->message : "unknown g_spawn_async() error"); nm_vpn_service_stop_connections (service, FALSE, NM_VPN_CONNECTION_STATE_REASON_SERVICE_START_FAILED); |