diff options
author | Aleksander Morgado <aleksandermj@chromium.org> | 2023-05-11 11:13:35 +0000 |
---|---|---|
committer | Aleksander Morgado <aleksandermj@chromium.org> | 2023-05-11 11:13:35 +0000 |
commit | 1564b54cff0b7097c93f4152a320da5cbbfa2b16 (patch) | |
tree | dad5800e7cbec8449b3c67f9ff8be498f480bb1f | |
parent | ecea0a16e1678ad5fd17aac64c68e0c443a3d6d7 (diff) | |
download | ModemManager-1564b54cff0b7097c93f4152a320da5cbbfa2b16.tar.gz |
broadband-modem-mbim: non-zero interval when enabling thresholds
Fix bug in Fibocom FM350 modem where a non-zero signal strength
interval needs to be configured as part of threshold setup.
Fixes #733
-rw-r--r-- | src/mm-broadband-modem-mbim.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c index e18fd7afc..6c6536f1b 100644 --- a/src/mm-broadband-modem-mbim.c +++ b/src/mm-broadband-modem-mbim.c @@ -6850,8 +6850,13 @@ modem_signal_setup_thresholds (MMIfaceModemSignal *self, if (error_rate_threshold) coded_error_rate_threshold = 1; /* minimum value when enabled */ + /* setting signal strength interval to 0 disables threshold-based + * notifications on certain modems (FM350). + * hence, it is being set to 5 as per FBC's recommendation. + * typically, setting this parameter to 0 should make the modem + * set the value to its internal default as per spec. */ message = (mbim_message_signal_state_set_new ( - 0, /* signal strength interval set to default always */ + 5, /* non-zero default signal strength interval */ coded_rssi_threshold, coded_error_rate_threshold, NULL)); |