| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
| |
For consistency reasons and because the POSIX functions are more
consistent and simple, this also allows us to set the mode on file
creation and detect if a file already exists.
|
| |
|
|
| |
For the consistency reasons listed in earlier commits.
|
| |
|
|
|
| |
Since we now use POSIX file functions only in tbdiff-create, we
no longer need tbd_stat_fopen, so it's been removed.
|
| |
|
|
|
|
|
|
| |
This keeps the code consistent by using the same file functions
internally as are used when reading from or writing to the stream.
The code is also simplified somewhat since POSIX file operations
are cleaner and more consistent than stdio.
|
| |
|
|
|
|
|
| |
POSIX file functions are more consistent and simple, originally
stdio was used to make the code as portable as possible, however
since it now relies on POSIX functionality anyway there's no need
for the inconsistency.
|
| |
|
|
|
|
|
|
|
| |
Quoted includes should be used when including headers which
represent declarations in local source files. The source files have
been modified to reflect this.
This makes it more clear which headers are system headers and which
are part of the tbdiff codebase.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
POSIX reserves the use of the underscore T postfix for types,
since most of the time we don't actually need to typedef the types
and since it's more clear to prefix structs and enums with the
struct and enum keywords, I've removed all uses of typedef and
gone with the more simple approach used in the kernel.
One typedef remains which is tbd_cmd_type, since this should be
a native type of a fixed size. The postfix changed to type to show
that it's a type and to ensure it doesn't collide with POSIX.
|
| |
|
|
|
|
| |
The extern keyword is not needed since it's the default property
for a function, it also takes up extra space on the line which
leads to more wrapping.
|
| |
|
|
|
|
| |
The compiler currently warns that the result of chown is ignored,
for now we'll print a warning when the chown operation fails, but
it'll need to be handled as an error eventually.
|
| |
|
|
|
| |
Use the TBD_DEBUG macro since it will be disabled when debug is
disabled, otherwise we'd always print the error message.
|
| |
|
|
|
| |
We now use the TBD_DEBUG macro rather than fprintf, this means that
debug messages aren't printed when debugging is disabled.
|
| |
|
|
|
|
|
| |
Added TBD_WARN and TBD_DEBUG macros to allow for warnings and
debug messages to be printed. This will make current debugging
messages cleaner and allow us to warn when the chown operation
fails.
|
| | |
|
| |
|
|
|
|
|
|
| |
The implementation currently uses fread and fwrite which are
specific functions in stdlib, however this is an implementation
detail and in the future these functions may not be used, so it
doesn't make sense to name the higher level functions based on
the function they use underneath.
|
| |
|
|
|
| |
Also removed because size_t can vary in size across platforms,
which makes it unsuitable for storing in our diff stream.
|
| | |
|
| |
|
|
|
| |
The externs are not required but it's inkeeping with the other
headers which all currently have them.
|
| |
|
|
|
|
|
|
| |
Simplify the endian swapping by always calling the endian macro
and only implementing it when the platform is big-endain.
The endian swapping function has also been made a little more
obvious and now uses a byteswap inline function to swap the bytes.
|
| | |
|
| |
|
|
|
|
|
| |
The parent pointer in tbd_stat_t was void since it pointed to
itself, to make the code more clear I've typedef'd the struct
above so that the pointer can now point to itself as an
incomplete type.
|
| |
|
|
|
|
| |
Previously commands were just treated as a uint8_t and given the value of
and enum. This is now made more clear in the code by defining tbd_cmd_t as
a uint8_t below the enum in tbdiff-common.h.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
There were a lot of instances where on error the code would fail
to close the opened file pointer.
|
| |
|
|
| |
On error the duplicated string in 'name' would have leaked.
|
| |
|
|
|
|
| |
The man page for lsetxattr says that ENOATTR is a synonym of ENODATA,
since ENOATTR is not always available in sys/xattr.h we'll use
ENODATA instead.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
On my system tbdiff failed to build because attr/xattr doesn't
exist, also the attr package was not easy to find.
On searching I discovered that the functionality we use in attr.h
is provided by modern versions of libc, as shown here:
https://bugzilla.kernel.org/show_bug.cgi?id=70141
This patch falls back to using libc sys/xattr.h when attr/xattr.h
is unavailable.
|
|
|
This commit converts tbdiff to being an autotools-based project. This
means that we now support the usual
autoreconf -i && ./configure && make && make install
process, plus we provide 'make check' for the tbdiff test suite.
The tbdiff library is now build as a shared library and is also
installed into the system for others to use. The library is
libtool-versioned and ships a pkg-config file (tbdiff-1.pc).
The headers were adjusted so that only tbdiff/tbdiff.h may be included
directly; all others are considered internal. The tbdiff-create and
tbdiff-deploy tools were changed to include this header file.
The tbdiff library is still GPL, not LGPL. We might want to change this
in the future.
Thanks to switching to autotools we now have a way to make releases by
means of 'make dist' and 'make distcheck'. Unfortunately, the latter
currently fails, probably due to something being missing in
tbdiff/Makefile.am.
|
