Unify local and remote repo cache modules

There's not really any reason you'd want to use the RemoteRepoCache
class except as a workaround for the slow speed of some LocalRepoCache
operations, so I can't see this ruining anyone's day.

The main reason for doing this is so we can simply the sourceresolver
code. One reason that the sourceresolver class is so hopelessly
complicated is that it right now has to use two incompatible interfaces
for Git repo caches.

I've taken the opportunity to detangle the RepoCache class from the
App class. Now all of the configuration for the RepoCache class is
passed into the constructor explicitly. This makes the class usable from
outside Morph:

    resolver = morphlib.repoaliasresolver.RepoAliasResolver(aliases=[])
    repo_cache = morphlib.repocache.RepoCache('/src/cache/gits', resolver)

Change-Id: I596c81d7645b67504c88e555172a8c238f4f8a66

1 files changed, 1 insertions, 19 deletions

diff --git a/morphlib/plugins/show_dependencies_plugin.py b/morphlib/plugins/show_dependencies_plugin.py
index 42f8f273..bfe4d6c2 100644
--- a/morphlib/plugins/show_dependencies_plugin.py
+++ b/morphlib/plugins/show_dependencies_plugin.py
@@ -1,4 +1,4 @@
-# Copyright (C) 2012-2015  Codethink Limited
+# Copyright (C) 2012-2016  Codethink Limited
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -42,24 +42,6 @@ class ShowDependenciesPlugin(cliapp.Plugin):
         of build dependencies of the constituent components.
 
         '''
-
-        if not os.path.exists(self.app.settings['cachedir']):
-            os.mkdir(self.app.settings['cachedir'])
-        cachedir = os.path.join(self.app.settings['cachedir'], 'gits')
-        tarball_base_url = self.app.settings['tarball-server']
-        repo_resolver = morphlib.repoaliasresolver.RepoAliasResolver(
-            self.app.settings['repo-alias'])
-        lrc = morphlib.localrepocache.LocalRepoCache(
-            self.app, cachedir, repo_resolver, tarball_base_url)
-
-        remote_url = morphlib.util.get_git_resolve_cache_server(
-            self.app.settings)
-        if remote_url:
-            rrc = morphlib.remoterepocache.RemoteRepoCache(
-                remote_url, repo_resolver)
-        else:
-            rrc = None
-            
         build_command = morphlib.buildcommand.BuildCommand(self.app)
 
         # traverse the morphs to list all the sources