Get rid of the CachedRepo class (almost)

For a long time the CachedRepo class has basically been a wrapper around
the GitDir class, but with a few extra methods that don't really even
belong there.

It is now a tiny class in the localrepocache module which just keeps
track of a few extra attributes. All other functionality is provided
by the gitdir module.

This commit also removes the `git clone` approach for copying repos out
of the cache. The alternative approach implemented by
git.copy_repository() was slightly faster when I tested, so for now we
should use that everywhere. Longer term we should find out why this is
quicker than `git clone`, and fix Git itself to be fast.

Change-Id: I1686ab43253d44c3903d9a0bad8bb75528e9cf75

1 files changed, 13 insertions, 1 deletions

diff --git a/morphlib/gitdir_tests.py b/morphlib/gitdir_tests.py
index 0ec7b0f1..4da98bbc 100644
--- a/morphlib/gitdir_tests.py
+++ b/morphlib/gitdir_tests.py
@@ -1,4 +1,4 @@
-# Copyright (C) 2013-2015  Codethink Limited
+# Copyright (C) 2013-2016  Codethink Limited
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -15,6 +15,8 @@
 # =*= License: GPL-2 =*=
 
 
+import fs.tempfs
+
 import contextlib
 import datetime
 import os
@@ -305,6 +307,16 @@ class GitDirectoryContentsTests(unittest.TestCase):
         morphlib.git.gitcmd(gd._runcmd, 'reset', '--hard')
         self.assertEqual(gd.describe(), 'example')
 
+    def test_extract_commit_into_new_directory(self):
+        gd = morphlib.gitdir.GitDirectory(self.dirname)
+
+        unpack_dir = fs.tempfs.TempFS().getsyspath('unpack-dir')
+        gd.extract_commit('master', unpack_dir)
+        self.assertTrue(os.path.exists(unpack_dir))
+
+        morph_filename = os.path.join(unpack_dir, 'bar.morph')
+        self.assertTrue(os.path.exists(morph_filename))
+
 
 class GitDirectoryFileTypeTests(unittest.TestCase):