Stop using bare except: statements

It is almost never a good idea to catch all exceptions, and then do
nothing about them. This patch logs all caught exceptions so that the
user has some possibilty to debug what is happening.

Also, make ./check check for bare excepts and fail the test suite if it
finds anything.

1 files changed, 2 insertions, 2 deletions

diff --git a/morphlib/app.py b/morphlib/app.py
index 859019f9..1d4d6fb0 100755
--- a/morphlib/app.py
+++ b/morphlib/app.py
@@ -253,8 +253,8 @@ class Morph(cliapp.Application):
                                 reponame=reponame,
                                 ref=ref,
                                 chatty=True)
-            except:
-                pass
+            except BaseException, e:
+                logging.warning('Caught (and ignored) exception: %s' % str(e))
         if absref is None:
             if update:
                 self.status(msg='Caching git repository %(reponame)s',