diff options
| author | Pekka Paalanen <pekka.paalanen@collabora.com> | 2020-12-15 15:10:04 +0200 |
|---|---|---|
| committer | Daniel Stone <daniels@collabora.com> | 2020-12-15 14:42:46 +0000 |
| commit | 593d5af43a8e2c2a3371088fa7ae430d0517c82d (patch) | |
| tree | 48e08ec30b44b874615dafcb75f5ea6b8060e009 /libweston/renderer-gl/gl-renderer-internal.h | |
| parent | 2d738b856d73c9257aabc441f0e8517a9b13c129 (diff) | |
| download | weston-593d5af43a8e2c2a3371088fa7ae430d0517c82d.tar.gz | |
gl-renderer: require GL_EXT_unpack_subimage
Require GL_EXT_unpack_subimage unconditionally in GL-renderer. Without
this extension, it would take considerable effort in GL-renderer to
handle correctly images that contain row padding, either as a temporary
copy to remove padding or doing SubImage updates row by row.
I would guess that this path has gone long completely untested, and if
it was exercised, the rows never had padding thanks to 32-bit pixel
formats. Instead of writing tests to poke the corner cases and fixing
it, remove it.
This will make it easier to fix other problems in GL-renderer in this
area in the future - one less path to consider and many restrictions in
GL API gone.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Diffstat (limited to 'libweston/renderer-gl/gl-renderer-internal.h')
| -rw-r--r-- | libweston/renderer-gl/gl-renderer-internal.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/libweston/renderer-gl/gl-renderer-internal.h b/libweston/renderer-gl/gl-renderer-internal.h index 529cb2f9..01e8b944 100644 --- a/libweston/renderer-gl/gl-renderer-internal.h +++ b/libweston/renderer-gl/gl-renderer-internal.h @@ -68,8 +68,6 @@ struct gl_renderer { PFNEGLCREATEPLATFORMWINDOWSURFACEEXTPROC create_platform_window; bool has_platform_base; - bool has_unpack_subimage; - PFNEGLBINDWAYLANDDISPLAYWL bind_display; PFNEGLUNBINDWAYLANDDISPLAYWL unbind_display; PFNEGLQUERYWAYLANDBUFFERWL query_buffer; |