summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Prep for release 1.4.0v1.4.0Cole Robinson2016-06-1847-37349/+42125
|
* tests: uitests: Fix with gitCole Robinson2016-06-172-3/+1
|
* tests_inject: Update to use standard --only optionCole Robinson2016-06-173-35/+12
| | | | Rather than custom --distro option. And fix the URL list
* appdata: Modernize, and translate itCole Robinson2016-06-173-32/+50
| | | | | This also revealed our translations were busted for .desktop files as well, so rework the POTFILES.in generation to account for it
* guest: Fix multiple address.type=pci auto allocate requestsCole Robinson2016-06-173-3/+14
| | | | | And test it for aarch64, which is the only place it's really interesting at the moment
* Apparently -tt doesn't work with #!/usr/bin/env ...Cole Robinson2016-06-176-6/+6
|
* delete: Don't offer to delete floppy media by defaultCole Robinson2016-06-171-7/+11
| | | | | | Even if it's not marked readonly or shareable, floppy media is very likely to be a shared resource and not something that belongs to the VM that the user will want to delete by default.
* Use #!/usr/bin/env for python scriptsCole Robinson2016-06-177-6/+14
| | | | | | | | | This is recommended for upstream, but not for downstream, like Fedora. So change /usr/bin/env to /usr/bin/python2 at RPM install time to match the ideal Fedora config. https://fedoraproject.org/wiki/Features/SystemPythonExecutablesUseSystemPython https://bugzilla.redhat.com/show_bug.cgi?id=1303282
* virtinst: Add --transient flag.Richard W.M. Jones2016-06-174-16/+43
| | | | | | | | If this flag is specified, --import|--boot will create a transient libvirt domain, ie. one which goes away when the guest shuts down or the host is rebooted. (crobinso: some tweaks and tests)
* virt-install: Uncontionally use domain.isActive()Cole Robinson2016-06-171-70/+21
| | | | | | | It's been around for seven years, and even RHEL5 has it... I don't think we need to work around platforms that don't have support for it. Use this as an opportunity to simplify the surrounding code
* tests: Add virt-install --wait test, and tweak the logic a bitCole Robinson2016-06-172-7/+11
|
* virt-install: Access domain in place via guest.domainCole Robinson2016-06-172-24/+15
| | | | | And stop returning the domain object from Guest.start_install, it's redundant
* tests: Add some virt-install autoconsole testsCole Robinson2016-06-172-3/+13
|
* guest: Rename noboot -> dobootCole Robinson2016-06-172-21/+12
| | | | It's a bit easier to follow the logic IMO
* guest: Rename start_xml -> install_xmlCole Robinson2016-06-171-9/+9
| | | | Make it more clear what the case is
* guest: Use newer named CreateXML APICole Robinson2016-06-172-3/+3
| | | | | CreateLinux is the very old style name. CreateXML has been around since at least 2009, which covers our minimum libvirt-python version
* virtinst: break out kernel/initrd vol upload to its own fileCole Robinson2016-06-172-126/+158
|
* virtinst: Move initrdinject handling to its own fileCole Robinson2016-06-173-111/+132
|
* virtinst: guest: drop 'continue_install' conceptCole Robinson2016-06-177-331/+44
| | | | | | | | | | | | | | | | | | | | | | continue_install is intended to facilitate windows XP style 3 stage installs: stage 1: initial dos style disk setup, reboot stage 2: actual full installer, reboot stage 3: OS is functional, virt-install is done The code assumed that we needed to keep the cdrom as the primary boot device for the second stage, so virt-install/virt-manager needed to hang around through the second stage run, wait until the VM shutdown, then encode the final XML to boot of the disk. Windows is and always has been smart enough to handle that case though... after the initial boot, if we set the hd as the primary boot device for stage 2, the disk bits that windows already installed will make use of the cdrom as necessary. So the entire premise of continue_install is irrelevant. Maybe back when it was added, when xen didn't even have working ACPI support, this served a purpose, but I'm pretty sure we can safely drop it nowadays.
* storage: Detect backing_store format automaticallyCole Robinson2016-06-163-3/+53
| | | | | | | By attempting to manage/import the passed path. This makes it work via both virt-install and virt-manager https://bugzilla.redhat.com/show_bug.cgi?id=1235406
* cli: Add --disk backing_format= optionCole Robinson2016-06-166-2/+17
|
* create: customize: Fix inadvertent disk removal on install failCole Robinson2016-06-161-0/+1
| | | | | | | | | If the first install attempt fails, then the second attempt succeeds, we were still removing the disk images we created as though the install never succeeded. We need to clear out the cached failed_guest value via the customize dialog callback https://bugzilla.redhat.com/show_bug.cgi?id=1342043
* tests: fix a testcase failure by --os-variantChen Hanxiao2016-06-161-1/+1
| | | | | | | | | | Current libosinfo release on fedora23 and centos7 didn't know fedora23. Change --os-variant fedora22 as a workaroud. df1c3e74a introduce this issue. Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
* virtManager.details: show firmware options also for XEN guestsPavel Hrdina2016-06-161-2/+4
|
* virtinst.capabilities: return recommended machine for XENPavel Hrdina2016-06-163-3/+8
| | | | | | | | This is required in order to ask for correct domcapabilities. If you don't specify any machine libvirt will return domcapabilities for default machine which is xenpv. Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
* virtManager.create: don't clear recommended machine if none is selectedPavel Hrdina2016-06-161-1/+5
| | | | | | | This improves loading domcapabilities to get domcapabilities for recommended machine, not for default machine. Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
* maint: update all libvirt checks for version from 1.3.6 to 2.0.0Pavel Hrdina2016-06-152-4/+4
| | | | | | | There want be 1.3.6 version, libvirt switched to new release numbering, for more information see <http://libvirt.org/downloads.html#numbering>. Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
* storagelist: code cleanupJovanka Gulicoska2016-06-141-4/+1
| | | | | Remove cb() function calling pool.refresh, instead use pool.refresh in vmmAsyncJob
* cli: Support --cpu cellX.id (and cpus, and memory)Cole Robinson2016-06-1410-10/+76
| | | | | | This allows configuring <cpu><numa><cell> bits via the command line. This uses the optional numbering scheme described in the previous commit.
* cli: Support --disk seclabelX.model (and relabel, and label)Cole Robinson2016-06-147-10/+61
| | | | | | | | | | | | | | This adds support for setting VirtualDisk <seclabel> XML. This invents a new command line scheme for cases like this where there are possibly multiple child elements that we want to specify on the command line. So if you just want to specify one <seclabel> block, you can do the expected --disk ...,seclabel.model=dac,relabel=no However if you want to specify 2 <seclabel> blocks you need to do: --disk ...,seclabel0.model=dac,seclabel0.relabel=no,seclabel1.model=selinux,seclabel1.relabel=no
* cli: Only instantiate VirtCLIArguments at parse timeCole Robinson2016-06-143-122/+138
| | | | | | | | We register the VirtCLIArgument classes with the static parse instructions, but instantiate it with the actual key=val pair from the command line. This fixes some layering violations, and gives callers access to the actual command line key that we are parsing, if that's interesting.
* cli: Separate out can_comma handlingCole Robinson2016-06-141-30/+33
| | | | Clarify things by taking it out of the main parse loop
* cli: Pass virtarg and parser to setter callbackCole Robinson2016-06-141-140/+83
| | | | | This should provide access to every bit of info we could possibly want from the setter callbacks
* cli: Rework VirtCLIParser instantiationCole Robinson2016-06-143-447/+443
| | | | | | | | | | | | Only initialize VirtCLIParser at actual parse time. The data that's passed to __init__ is the particular data for that parse task, like the option string, and the Guest object we are editing. As a result we can drop the whole parsermap handling, since the parserlist is immutable. There's a bunch of other reworks mixed in like dropping the VirtOptionString abstraction...
* cli: Improve comments for _VirtCLIArgumentCole Robinson2016-06-141-7/+17
|
* cli: Drop unused VirtCLIParser.option_variable_nameCole Robinson2016-06-132-38/+30
|
* cli: Move introspection checking out of Parser classCole Robinson2016-06-131-12/+13
| | | | | We can do that at the cli entry point, and only have the parser print its subargs
* cli: Register VirtCLIArguments at class definition timeCole Robinson2016-06-131-682/+666
| | | | | | | | | | | The VirtCLIArguments, (for example, path=, size=, etc. for --disk) are only registered when a VirtCLIParser is actually initialized. This seems backwards, since those arguments are really more immutable factors of the actual command line parsing, so make more sense only initializing them once, at class definition time. This switches to use that pattern. This makes the parsing flow a bit cleaner and can be a basis for future improvements.
* cli: Tweak clearxml argument setupCole Robinson2016-06-131-25/+25
| | | | Just unnest the callback to make it a little easier to follow
* cli: More shared 'address.*' handling output VirtCLIParserCole Robinson2016-06-131-41/+41
| | | | | Make it a global function rather than complicating VirtCLIParser any further with irrelevant functions
* conn: Stop using VirtOptionParserCole Robinson2016-06-132-65/+87
| | | | | | It only needs a minimal portion of the functionality, so separate that out and use it explicitly. Clean up some of the surrounding cli.py bits as well
* cli: Separate param parse and lookupCole Robinson2016-06-121-21/+34
| | | | Makes the code a bit easier to follow
* pylint: Skip bad-option-value to make f23 pylint more quietCole Robinson2016-06-121-1/+1
| | | | f24 pylint seems to have this behavior by default
* virtinst: rename .seclabel->.seclabelsCole Robinson2016-06-123-7/+7
| | | | | Since guest and disk can have multiple of these, make it clear to callers
* cli: Rename opts.opts -> opts.optdictCole Robinson2016-06-122-56/+56
| | | | | To make it more clear to callers what type of structure they are dealing with
* Fix some pylintCole Robinson2016-06-121-1/+0
|
* cli: Use OrderedDict for tracking cli valuesCole Robinson2016-06-121-7/+5
| | | | Allows us to drop the single 'orderedopts' usage
* virtinst: disk: Fix seclabel testingCole Robinson2016-06-114-5/+19
| | | | | | disk devices don't have a full <seclabel> under their <source> element, just a smaller one with only a few options. Fix things to match what libvirt does
* cli: Wrap setter_cb bits in a classCole Robinson2016-06-111-78/+72
| | | | Will make it less churny if we want to add new bits in the future
* cli: add --graphics listen=socket supportCole Robinson2016-06-115-3/+24
| | | | | | This is the new style socket support, where we request libvirt to allocate a socket path for us. Plus this is the only way to enable socket support for type=spice