diff options
| author | Cole Robinson <crobinso@redhat.com> | 2014-03-10 08:56:51 -0400 |
|---|---|---|
| committer | Cole Robinson <crobinso@redhat.com> | 2014-03-10 08:57:11 -0400 |
| commit | cfc52051b71bcfbf3f58ea6eddf457298f186727 (patch) | |
| tree | b5d5828219755840e3d9128ca98e6d1aec9a225a | |
| parent | 27db4dac8fe75527374948807b1143e2ac28afbe (diff) | |
| download | virt-manager-cfc52051b71bcfbf3f58ea6eddf457298f186727.tar.gz | |
storagebrowse: Duplicate tooltip logic for 'new volume' button
| -rw-r--r-- | virtManager/storagebrowse.py | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/virtManager/storagebrowse.py b/virtManager/storagebrowse.py index 314a6abc..3f61352b 100644 --- a/virtManager/storagebrowse.py +++ b/virtManager/storagebrowse.py @@ -208,7 +208,8 @@ class vmmStorageBrowser(vmmGObjectUI): self.local_args["dialog_type"] = data.get("dialog_type") self.local_args["choose_button"] = data.get("choose_button") - self.widget("new-volume").set_visible(self.can_new_volume) + self.widget("new-volume").set_visible( + self.can_new_volume and self.allow_create()) # Convenience helpers @@ -302,13 +303,17 @@ class vmmStorageBrowser(vmmGObjectUI): def pool_selected(self, src_ignore=None): pool = self.current_pool() - newvol = bool(pool) + can_new_vol = False + tt = "" if pool: pool.tick() - newvol = pool.is_active() + can_new_vol = (pool.is_active() and + pool.supports_volume_creation()) + if not can_new_vol: + tt = _("Pool does not support volume creation") - newvol = newvol and self.allow_create() - self.widget("new-volume").set_sensitive(newvol) + self.widget("new-volume").set_sensitive(can_new_vol) + self.widget("new-volume").set_tooltip_text(tt) self.populate_storage_volumes() |