diff options
| author | Cole Robinson <crobinso@redhat.com> | 2020-11-13 13:11:57 -0500 |
|---|---|---|
| committer | Cole Robinson <crobinso@redhat.com> | 2020-11-13 13:17:41 -0500 |
| commit | 41023192cabfb46dd5ad75aa1f923a9aa9f50704 (patch) | |
| tree | 511e8ab79b33c6da396644b551e81319ac144ea7 | |
| parent | b7b75ab8fcdde49be727d5961d5f724f846ae10b (diff) | |
| download | virt-manager-41023192cabfb46dd5ad75aa1f923a9aa9f50704.tar.gz | |
fsdetails: Stop showing the 'driver' combo for qemu
The only valid value now is 'path' which is also the default,
so drop the UI
Signed-off-by: Cole Robinson <crobinso@redhat.com>
| -rw-r--r-- | tests/uitests/test_details.py | 1 | ||||
| -rw-r--r-- | virtManager/device/fsdetails.py | 9 | ||||
| -rw-r--r-- | virtinst/devices/filesystem.py | 1 |
3 files changed, 2 insertions, 9 deletions
diff --git a/tests/uitests/test_details.py b/tests/uitests/test_details.py index b3c54062..c8d6fe6c 100644 --- a/tests/uitests/test_details.py +++ b/tests/uitests/test_details.py @@ -576,7 +576,6 @@ def testDetailsEditDevices2(app): # Filesystem tweaks tab = _select_hw(app, win, "Filesystem /target/", "filesystem-tab") - tab.combo_select("Driver:", "Path") tab.find("Source path:", "text").set_text("/frib1") tab.find("Target path:", "text").set_text("newtarget") tab.find_fuzzy("Export filesystem", "check box").click() diff --git a/virtManager/device/fsdetails.py b/virtManager/device/fsdetails.py index 7fca3218..0f7e5481 100644 --- a/virtManager/device/fsdetails.py +++ b/virtManager/device/fsdetails.py @@ -99,8 +99,6 @@ class vmmFSDetails(vmmGObjectUI): simple_store_set("fs-mode-combo", DeviceFilesystem.MODES + [None]) drivers = [] - if self.conn.is_qemu() or self.conn.is_test(): - drivers += [DeviceFilesystem.DRIVER_PATH] if self.conn.is_lxc() or self.conn.is_test(): drivers += [DeviceFilesystem.DRIVER_LOOP, DeviceFilesystem.DRIVER_NBD] @@ -179,9 +177,7 @@ class vmmFSDetails(vmmGObjectUI): fstype == DeviceFilesystem.TYPE_MOUNT or self.conn.is_qemu() or self.conn.is_test()) - show_mode = bool(ismount and - (fsdriver == DeviceFilesystem.DRIVER_PATH or - fsdriver is None)) + show_mode = bool(ismount) uiutil.set_grid_row_visible(self.widget("fs-mode-combo"), show_mode) show_ram_source = fstype == DeviceFilesystem.TYPE_RAM @@ -202,8 +198,7 @@ class vmmFSDetails(vmmGObjectUI): else: source_text = _("_Source path:") show_mode_combo = self.conn.is_qemu() or self.conn.is_test() - show_driver_combo = (self.conn.is_qemu() or - self.conn.is_lxc() or + show_driver_combo = (self.conn.is_lxc() or self.conn.is_test()) self.widget("fs-source-title").set_text(source_text) diff --git a/virtinst/devices/filesystem.py b/virtinst/devices/filesystem.py index dbe38208..dd6969c4 100644 --- a/virtinst/devices/filesystem.py +++ b/virtinst/devices/filesystem.py @@ -24,7 +24,6 @@ class DeviceFilesystem(Device): MODE_SQUASH = "squash" MODES = [MODE_PASSTHROUGH, MODE_MAPPED, MODE_SQUASH] - DRIVER_PATH = "path" DRIVER_LOOP = "loop" DRIVER_NBD = "nbd" |