summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCole Robinson <crobinso@redhat.com>2013-02-06 15:41:43 -0500
committerCole Robinson <crobinso@redhat.com>2013-02-06 15:41:43 -0500
commit12dcebcc0a614a234d154116a1356327503a2e0b (patch)
tree7350c7a05dee923310aab2899221637a5307f0c4
parent0ca8cf6d4316d1b3f55226c3782a3ac92eb34967 (diff)
downloadvirt-manager-12dcebcc0a614a234d154116a1356327503a2e0b.tar.gz
Disable a bunch of pep8 tests I won't fix before gtk3 port
-rw-r--r--src/virtManager/addhardware.py6
-rwxr-xr-xtests/pylint-virt-manager.sh16
2 files changed, 19 insertions, 3 deletions
diff --git a/src/virtManager/addhardware.py b/src/virtManager/addhardware.py
index be40ff84..baad136c 100644
--- a/src/virtManager/addhardware.py
+++ b/src/virtManager/addhardware.py
@@ -1241,8 +1241,8 @@ class vmmAddHardware(vmmGObjectUI):
fmt = self.get_config_disk_format()
controller_model = None
if bus == "virtio-scsi":
- bus = "scsi"
- controller_model = "virtio-scsi"
+ bus = "scsi"
+ controller_model = "virtio-scsi"
# Make sure default pool is running
if self.is_default_storage():
@@ -1346,7 +1346,7 @@ class vmmAddHardware(vmmGObjectUI):
disk.vmm_controller = controller
for d in controllers:
if controller_model == d.model:
- disk.vmm_controller = None
+ disk.vmm_controller = None
self._dev = disk
return True
diff --git a/tests/pylint-virt-manager.sh b/tests/pylint-virt-manager.sh
index b4b02677..51ffc084 100755
--- a/tests/pylint-virt-manager.sh
+++ b/tests/pylint-virt-manager.sh
@@ -139,16 +139,32 @@ skip_pep8() {
SKIP_PEP8="${SKIP_PEP8}$1"
}
+skip_pep8 "E121"
+skip_pep8 "E122"
+skip_pep8 "E123"
+skip_pep8 "E124"
+skip_pep8 "E125" # Continuation line indents
+skip_pep8 "E126"
+skip_pep8 "E127"
+skip_pep8 "E128"
+
skip_pep8 "E203" # Space before : in dictionary defs
skip_pep8 "E221" # Multiple spaces before operator (warns
# about column aligning assigments
skip_pep8 "E241" # Space after , column alignment nono
+skip_pep8 "E251" # No space around keyword
skip_pep8 "E261" # 2 spaces before inline comment?
+skip_pep8 "E271" # Multiple spaces before keyword
+skip_pep8 "E272" # Multiple spaces before keyword
+
skip_pep8 "E301" # 1 blank line between methods
skip_pep8 "E302" # 2 blank lines between function defs
skip_pep8 "E303" # Too many blank lines
skip_pep8 "E501" # Line too long
+skip_pep8 "E711" # Comparison to False
+skip_pep8 "E712" # Comparison to None
+
echo "Running pep8"
pep8 -r --exclude=$IGNOREFILES --ignore $SKIP_PEP8 \
$PYLINT_FILES