| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Problem: Cannot specify an ID for each item with prop_add_list(). (Sergey
Vlasov)
Solution: Add an optional fifth number to the item. (closes #11360)
|
| |
|
|
|
| |
Problem: prop_add_list() gives multiple errors for invalid argument.
Solution: Only give one error message.
|
| |
|
|
|
|
| |
Problem: Using "end_lnum" with virtual text causes problems.
Solution: Disallow using "end_lnum" with virtual text. (closes #11151)
Also disallow "end_col" and "length".
|
| |
|
|
|
|
| |
Problem: Virtual text wrong after adding line break after line.
Solution: Pass an "eol" flag to where text properties are adjusted.
(closes #11131)
|
| |
|
|
|
| |
Problem: ASAN warning for integer overflow.
Solution: Check for tp_col to be MAXCOL.
|
| |
|
|
|
|
| |
Problem: Splitting a line with a text prop "above" moves it to a new line
below.
Solution: Keep an "above" text prop above the first line.
|
| |
|
|
|
|
| |
Problem: Visual highlighting extends into virtual text prop.
Solution: Do not highlight what isn't actually selected. Fix ordering of
stored text props.
|
| |
|
|
|
| |
Problem: Virtual text "above" does not work with 'nowrap'.
Solution: Do wrap the line after. (closes #11084)
|
| |
|
|
|
| |
Problem: Cannot put virtual text above a line.
Solution: Add the "above" value for "text_align".
|
| |
|
|
|
| |
Problem: Error message for list argument could be clearer.
Solution: Include the argument number. (Yegappan Lakshmanan, closes #11027)
|
| |
|
|
|
| |
Problem: Checks for Dictionary argument often give a vague error message.
Solution: Give a useful error message. (Yegappan Lakshmanan, closes #11009)
|
| |
|
|
|
|
| |
Problem: Cursor in wrong place after virtual text.
Solution: Do not change the length of a virtual text property.
(closes #10964)
|
| |
|
|
|
| |
Problem: Cannot add padding to virtual text without highlight.
Solution: Add the "text_padding_left" argument. (issue #10906)
|
| |
|
|
|
| |
Problem: Removing multiple text properties takes many calls.
Solution: Pass a list to prop_remove(). (Ben Jackson, closes #10945)
|
| |
|
|
|
|
| |
Problem: Splitting a line may duplicate virtual text. (Ben Jackson)
Solution: Don't duplicate a text property with virtual text. Make
auto-indenting work better. (closes #10919)
|
| |
|
|
|
| |
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
|
| |
|
|
|
|
|
| |
Problem: Cursor in wrong position when inserting after virtual text. (Ben
Jackson)
Solution: Put the cursor after the virtual text, where the text will be
inserted. (closes #10914)
|
| |
|
|
|
|
|
| |
Problem: cursor in a wrong positoin if 'wrap' is off and using two right
aligned text props in one line.
Solution: Count an extra line for a right aligned text property after a
below or right aligned text property. (issue #10909)
|
| |
|
|
|
|
| |
Problem: Cursor displayed in wrong position after removing text prop. (Ben
Jackson)
Solution: Invalidate the cursor position. (closes #10898)
|
| |
|
|
|
|
| |
Problem: Strange effects when using virtual text with "text_align" and
non-zero column. (Martin Tournoij)
Solution: Give an error. (closes #10888)
|
| |
|
|
|
|
| |
Problem: Trying to allocate zero bytes.
Solution: Do not allocate the proptype array when there are none.
(closes #10867)
|
| |
|
|
|
| |
Problem: Insufficient testing for line2byte() with text properties.
Solution: Add tests with a lot of text.
|
| |
|
|
|
|
| |
Problem: Checking for text properties could be a bit more efficient.
Solution: Return early when there are no text properties. Update TODO
items.
|
| |
|
|
|
| |
Problem: Looking up a text property type by ID is slow.
Solution: Keep an array of property types sorted on ID.
|
| |
|
|
|
| |
Problem: Text properties wrong after splitting a line.
Solution: Check for text properties after the line. (closes #10857)
|
| |
|
|
|
|
| |
Problem: A "below" aligned text property does not work with 'nowrap'.
Solution: Start a new screen line to display the virtual text.
(closes #10851)
|
| |
|
|
|
| |
Problem: Substitute that joins lines drops text properties.
Solution: Move text properties of the last line to the new line.
|
| |
|
|
|
|
| |
Problem: Text property cannot override 'cursorline' highlight.
Solution: Add the "override" flag to prop_type_add(). (closes #5533,
closes #8225).
|
| |
|
|
|
|
| |
Problem: Virtual text after line moves to joined line. (Yegappan
Lakshmanan)
Solution: When joining lines only keep virtual text after the last line.
|
| |
|
|
|
| |
Problem: Virtual text with Tab is not displayed correctly.
Solution: Change any Tab to a space.
|
| |
|
|
|
| |
Problem: Cannot put virtual text after or below a line.
Solution: Add "text_align" and "text_wrap" arguments.
|
| |
|
|
|
|
| |
Problem: Text of removed textprop with text is not freed.
Solution: Free the text when the property is removed. Reduce the array size
to ignore NULLs at the end.
|
| |
|
|
|
| |
Problem: Cannot show virtual text.
Solution: Initial changes for virtual text support, using text properties.
|
| |
|
|
|
| |
Problem: Too many type casts for dict_get functions.
Solution: Change the key argument from "char_u *" to "char *".
|
| |
|
|
|
|
|
| |
Problem: Reproducing memory access errors can be difficult.
Solution: When testing, copy each line to allocated memory, so that valgrind
can detect accessing memory before and/or after it. Fix uncovered
problems.
|
| |
|
|
|
|
| |
Problem: Some callers of rettv_list_alloc() check for not OK. (Christ van
Willegen)
Solution: Use "==" instead of "!=" when checking the return value.
|
| |
|
|
|
|
| |
Problem: Byte offsets are wrong when using text properties.
Solution: Make sure text properties do not affect the byte counts.
(Paul Ollis, closes #10474)
|
| |
|
|
|
| |
Problem: Inserting line breaks text property spanning more then one line.
Solution: Check TP_FLAG_CONT_PREV and TP_FLAG_CONT_NEXT. (closes #10423)
|
| |
|
|
|
| |
Problem: prop_find() does not find the right property.
Solution: Fix the scan order. (closes #10220)
|
| |
|
|
|
| |
Problem: Verbose check with dict_find() to see if a key is present.
Solution: Add dict_has_key(). (Yegappan Lakshmanan, closes #10074)
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move the last error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
|
| |
|
|
|
| |
Problem: No error for passing an invalid line number to append().
Solution: In Vim9 script check for a non-negative number. (closes #9417)
|
| |
|
|
|
|
| |
Problem: Can only get text properties one line at a time.
Solution: Add options to prop_list() to use a range of lines and filter by
types. (Yegappan Lakshmanan, closes #9138)
|
| |
|
|
|
|
| |
Problem: Adding many text properties requires a lot of function calls.
Solution: Add the prop_add_list() function. (Yegappan Lakshmanan,
closes #8751)
|
| |
|
|
|
| |
Problem: Cannot use id zero with prop_find(). (Naohiro Ono)
Solution: Also accept id zero.
|
| |
|
|
|
| |
Problem: prop_find() finds property with ID -2.
Solution: Use a separate flag to indicate an ID was specified. (issue #8674)
|
