| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Problem: ml_get error when resizing window and using text property.
Solution: Validate botline of the right window. (closes #7528)
|
|
|
|
|
| |
Problem: Various typos.
Solution: Fix spelling mistakes. (closes #7494)
|
|
|
|
|
|
| |
Problem: Text properties corrupted with substitute command. (Filipe
Brandenburger)
Solution: Get the changed line again after using u_savesub(). (closes #6984)
|
|
|
|
|
| |
Problem: Vim9: cannot pass "true" to prop_type_add().
Solution: Use tv_get_bool(). (closes #6850)
|
|
|
|
|
| |
Problem: Vim9: cannot pass "true" to prop_remove().
Solution: Use dict_get_bool(). (closes #6853)
|
|
|
|
|
| |
Problem: Vim9: cannot use "true" for "skipstart" in prop_find().
Solution: Use dict_get_bool() instead of tv_get_number(). (closes #6852)
|
|
|
|
|
|
| |
Problem: prop_find() skips properties in the same line if "skipstart" is
used.
Solution: Use "continue" instead of "break". (closes #6840)
|
|
|
|
|
| |
Problem: Not checking if saving for undo succeeds.
Solution: Bail out if u_savesub() returns FAIL.
|
|
|
|
|
|
| |
Problem: Text properties crossing lines not handled correctly.
Solution: When joining lines merge text properties if possible.
(Axel Forsman, closes #5839, closes #5683)
|
|
|
|
|
| |
Problem: Gcc warns for ambiguous else.
Solution: Add braces. (Dominique Pelle, closes #5778)
|
|
|
|
|
| |
Problem: prop_find() does not find all props.
Solution: Check being in the start line. (Axel Forsman, closes #5776)
|
|
|
|
|
|
| |
Problem: Prop_find() may not find text property at start of the line.
Solution: Adjust the loop to find properties. (Axel Forsman, closes #5761,
closes #5663)
|
|
|
|
|
|
| |
Problem: Cannot delete a text property matching both id and type. (Axel
Forsman)
Solution: Add the "both" argument.
|
|
|
|
|
|
|
| |
Problem: Text property not updated correctly when inserting/deleting.
Solution: Use the right column when deleting. Make zero-width text
properties respect start_incl and end_incl. (Axel Forsman,
closes #5696, closes #5679)
|
|
|
|
|
| |
Problem: prop_find() is not implemented.
Solution: Implement prop_find(). (Ryan Hackett, closes #5421, closes #4970)
|
|
|
|
|
| |
Problem: Dead code in builtin functions.
Solution: Clean up the code.
|
|
|
|
|
| |
Problem: FEAT_TEXT_PROP is a confusing name.
Solution: Use FEAT_PROP_POPUP. (Naruhiko Nishino, closes #5291)
|
|
|
|
|
| |
Problem: Deleting text before zero-width textprop removes it.
Solution: Keep zero-width textprop when deleting text.
|
|
|
|
|
| |
Problem: Missing part of 8.1.2296.
Solution: s/test/text/
|
|
|
|
|
|
| |
Problem: Typos in comments.
Solution: Fix the typos. (Dominique Pelle, closes #5160) Also adjust
formatting a bit.
|
|
|
|
|
| |
Problem: Unreachable code in adjusting text prop columns.
Solution: Remove the code. (Christian Brabandt)
|
|
|
|
|
| |
Problem: No tests for text property popup window.
Solution: Add a few tests.
|
|
|
|
|
|
|
| |
Problem: Popup windows don't move with the text when making changes.
Solution: Add the 'textprop" property to the popup window options, position
the popup relative to a text property. (closes #4560)
No tests yet.
|
|
|
|
|
| |
Problem: Functions used in one file are global.
Solution: Add "static". (Yegappan Lakshmanan, closes #4840)
|
|
|
|
|
| |
Problem: Buffer no longer unloaded when adding text properties to it.
Solution: Do not create the memfile. (closes #4808)
|
|
|
|
|
|
| |
Problem: Allocating more memory than needed for extended structs.
Solution: Use offsetof() instead of sizeof(). (Dominique Pelle,
closes #4786)
|
|
|
|
|
| |
Problem: Gcc warns for uninitialized variable.
Solution: Put usage inside "if". (Ken Takata)
|
|
|
|
|
|
| |
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
|
|
|
|
|
| |
Problem: Popup_create() does not support text properties.
Solution: Support the third form of the text argument.
|
|
|
|
|
| |
Problem: Unnecessary type casts.
Solution: Remove type casts from alloc() and lalloc() calls. (Mike Williams)
|
|
|
|
|
|
| |
Problem: Errors when calling prop_remove() for an unloaded buffer.
Solution: Bail out when the buffer is not loaded. Add a few more tests for
failing when the buffer number is invalid.
|
|
|
|
|
|
| |
Problem: Calling prop_add() in an empty buffer doesn't work. (Dominique
Pelle)
Solution: Open the memline before adding a text property. (closes #4412)
|
|
|
|
|
| |
Problem: Unessesary type casts for lalloc().
Solution: Remove type casts. Change lalloc(size, TRUE) to alloc(size).
|
|
|
|
|
| |
Problem: Warnings for size_t/int mixups.
Solution: Change types, add type casts. (Mike Williams)
|
|
|
|
|
|
| |
Problem: Text property wrong after :substitute with backslash.
Solution: Adjust text property columns when removing backslashes.
(closes #4397)
|
|
|
|
|
| |
Problem: Text property wrong after :substitute.
Solution: Save for undo before changing any text properties.
|
|
|
|
|
| |
Problem: Text properties not adjusted for Visual block mode delete.
Solution: Call adjust_prop_columns(). (closes #4384)
|
|
|
|
|
| |
Problem: Text properties are lost when joining lines.
Solution: Move the text properties to the joined line.
|
|
|
|
|
| |
Problem: Attributes from 'cursorline' overwrite textprop.
Solution: Combine the attributes. (closes #3912)
|
|
|
|
|
| |
Problem: Get empty text prop when splitting line just after text prop.
Solution: Do not create an empty text prop at the start of the line.
|
|
|
|
|
|
| |
Problem: Text properties don't always move after changes.
Solution: Update properties before reporting changes to listeners. Move text
property when splitting a line.
|
|
|
|
|
| |
Problem: Missing change for "combine" field.
Solution: Also change the textprop implementation.
|
|
|
|
|
| |
Problem: prop_remove() second argument is not optional.
Solution: Fix argument count. Use "buf" instead of "curbuf". (closes #4147)
|
|
|
|
|
|
| |
Problem: Using STRNCPY() wrongly. Warning for uninitialized variable.
Solution: Use mch_memmove(). Initialize variable. (Yasuhiro Matsumoto,
closes #3979)
|
|
|
|
|
|
|
|
| |
Problem: Giving error messages is not flexible.
Solution: Add semsg(). Change argument from "char_u *" to "char *", also
for msg() and get rid of most MSG macros. (Ozaki Kiichi, closes
#3302) Also make emsg() accept a "char *" argument. Get rid of
an enormous number of type casts.
|
|
|
|
|
| |
Problem: Compiler warnings with 64-bit compiler.
Solution: Change types, add type casts. (Mike Williams)
|
|
|
|
|
|
| |
Problem: When using text props may free memory that is not allocated.
(Andy Massimino)
Solution: Allocate the line when adjusting text props. (closes #3766)
|
|
|
|
|
| |
Problem: Text properties are not adjusted for :substitute.
Solution: Adjust text properties as well as possible.
|
|
|
|
|
| |
Problem: get_buf_tv() is named inconsistently.
Solution: Rename it to tv_get_buf(). (Yegappan Lakshmanan, closes #3759)
|
|
|
|
|
| |
Problem: Warnings from 64-bit compiler.
Solution: Add type casts. (Mike Williams)
|