| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Problem: Channel test is still flaky on OS X.
Solution: Add a short sleep.
|
| |
|
|
|
| |
Problem: Two JSON messages are sent without a separator.
Solution: Separate messages with a NL. (closes #1001)
|
| |
|
|
|
|
| |
Problem: No test for an invalid Ex command on a channel.
Solution: Test handling an invalid command gracefully. Avoid getting an
error message, do write it to the channel log.
|
| |
|
|
|
| |
Problem: No test for special characters in channel eval command.
Solution: Testing sending and receiving text with special characters.
|
| |
|
|
|
| |
Problem: Channel test doesn't work with Python 2.6.
Solution: Add number in formatting placeholder. (Wiredool)
|
| |
|
|
|
| |
Problem: When a JSON message is split it isn't decoded.
Solution: Wait a short time for the rest of the message to arrive.
|
| |
|
|
|
| |
Problem: Malformed channel request causes a hang.
Solution: Drop malformed message. (Damien)
|
| |
|
|
|
|
| |
Problem: Wrong callback invoked for zero-id messages.
Solution: Don't use the first one-time callback when the sequence number
doesn't match.
|
| |
|
|
|
| |
Problem: A one-time callback is not used for a raw channel.
Solution: Use a one-time callback when it exists.
|
| |
|
|
|
| |
Problem: The close-cb option is not implemented yet.
Solution: Implemente close-cb. (Yasuhiro Matsumoto)
|
| |
|
|
|
|
|
| |
Problem: Calling a Vim function over a channel requires turning the
arguments into a string.
Solution: Add the "call" command. (Damien) Also merge "expr" and "eval"
into one.
|
| |
|
|
|
| |
Problem: The Python test script may keep on running.
Solution: Join the threads. (Yasuhiro Matsumoto)
|
| |
|
|
|
|
|
| |
Problem: When the port isn't opened yet when ch_open() is called it may
fail instead of waiting for the specified time.
Solution: Loop when select() succeeds but when connect() failed. Also use
channel logging for jobs. Add ch_log().
|
| |
|
|
|
| |
Problem: Using a channel handle does not allow for freeing it when unused.
Solution: Add the Channel variable type.
|
| |
|
|
|
|
|
| |
Problem: When the server sends a message with ID zero the channel handler
is not invoked. (Christian J. Robinson)
Solution: Recognize zero value for the request ID. Add a test for invoking
the channel handler.
|
| |
|
|
|
| |
Problem: On MS-Windows the channel test server doesn't quit.
Solution: Use return instead of break. (Ken Takata)
|
| |
|
|
|
| |
Problem: When jsonencode() fails it still returns something.
Solution: Return an empty string on failure.
|
| |
|
|
|
| |
Problem: Not all channel commands are tested.
Solution: Add a test for "normal", "expr" and "redraw".
|
| |
|
|
|
| |
Problem: Crash when receiving an empty array.
Solution: Check for array with wrong number of arguments. (Damien)
|
| |
|
|
|
| |
Problem: On Mac sys.exit(0) doesn't kill the test server.
Solution: Use self.server.shutdown(). (Jun Takimoto)
|
| |
|
|
|
| |
Problem: Crash for channel "eval" command without third argument.
Solution: Check for missing argument.
|
| |
|
|
|
| |
Problem: Opening a second channel causes a crash. (Ken Takata)
Solution: Don't re-allocate the array with channels.
|
| |
|
|
|
|
| |
Problem: Python test server not displaying second of two commands.
Solaris doesn't have "pkill --full".
Solution: Also echo the second command. Use "pkill -f".
|
| |
|
|
|
| |
Problem: The channel test server may receive two messages concatenated.
Solution: Split the messages.
|
| |
|
|
|
|
| |
Problem: Crash when the process a channel is connected to exits.
Solution: Use the file descriptor properly. Add a test. (Damien)
Also add a test for eval().
|
| |
|
|
|
|
|
| |
Problem: Can't reliably stop the channel test server. Can't start the
server if the python file is not executable.
Solution: Use "pkill" instead of "killall". Run the python file as an
argument instead of as an executable.
|
| |
|
|
|
| |
Problem: The channel test doesn't run on MS-Windows.
Solution: Make it work on the MS-Windows console. (Ken Takata)
|
| | |
|
|
|
Problem: The channel functionality isn't tested.
Solution: Add a test using a Python test server.
|
